[jira] [Commented] (FLINK-6013) Add Datadog HTTP metrics reporter

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973388#comment-15973388 ] 

ASF GitHub Bot commented on FLINK-6013:
---------------------------------------

GitHub user bowenli86 opened a pull request:

    https://github.com/apache/flink/pull/3736

    [Flink-6013][metrics] Add Datadog HTTP metrics reporter

    I'm adding a DatadogHttpReporter for Flink metrics system.
    
    The implementation, including making parameters in Flink's metrics as Datadog tags, is a best practice based on our long time working experience and understanding of Datadog. It might be a bit different than how other metrics reporters work, but it truly helps developers to find and filter metrics quickly, better categorize metrics, and visualize them on Datadog dashboards, especially when users (like OfferUp) have a dozen individual Flink clusters.
    
    ------
    
    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-6013] Add Datadog HTTP metrics reporter")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bowenli86/flink FLINK-6013

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3736.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3736
    
----
commit 72037bde640258bde618ddc10b8bd10645bbaf8d
Author: Bowen Li <bo...@gmail.com>
Date:   2017-04-18T17:27:17Z

    [FLINK-6013][metrics] Add Datadog HTTP metrics reporter

commit e8ced6d03eac47150648401566afce6f12ea03d0
Author: Bowen Li <bo...@gmail.com>
Date:   2017-04-18T17:27:54Z

    Merge branch 'master' into FLINK-6013

commit 27ae0584eb79bd1339934c06d4a4266be9264fb2
Author: Bowen Li <bo...@gmail.com>
Date:   2017-04-18T18:23:10Z

    move okhttp dependencies to flink-metrics

commit 4b48f4d32a8b122f35dfd6322174e469ff0a5a89
Author: Bowen Li <bo...@gmail.com>
Date:   2017-04-18T18:57:11Z

    add Apache License file header

commit a9ca61a92e4f0beb37652da361acfdcd50d11523
Author: Bowen Li <bo...@gmail.com>
Date:   2017-04-18T19:12:24Z

    add more code comments

commit cfe2fdf8d7456d657bd35e937e0f7618086af024
Author: Bowen Li <bo...@gmail.com>
Date:   2017-04-18T19:47:15Z

    remove okhttp from flink-metrics

commit 76b54b8ab7fc6eaad8c2bd7d54e79791110d9690
Author: Bowen Li <bo...@gmail.com>
Date:   2017-04-18T19:53:14Z

    add more doc

----


> Add Datadog HTTP metrics reporter
> ---------------------------------
>
>                 Key: FLINK-6013
>                 URL: https://issues.apache.org/jira/browse/FLINK-6013
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.2.0
>            Reporter: Bowen Li
>            Assignee: Bowen Li
>            Priority: Critical
>             Fix For: 1.3.0, 1.2.1
>
>
> We at OfferUp use Datadog a lot for metrics and dashboards, and I believe a lot other companies also do.
> Flink right now only has a StatsD metrics reporter, and users have to set up Datadog Agent in order to receive metrics from StatsD and transport them to Datadog. We don't like this approach.
> We prefer to have a Datadog metrics reporter directly contacting Datadog http endpoint.
> I'll take this ticket myself.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)