You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/12/17 02:29:22 UTC

[GitHub] [commons-geometry] darkma773r commented on a change in pull request #121: [GEOMETRY-105] - Replace the try-catch pattern with assertThrows()

darkma773r commented on a change in pull request #121:
URL: https://github.com/apache/commons-geometry/pull/121#discussion_r544764724



##########
File path: commons-geometry-core/src/test/java/org/apache/commons/geometry/core/partitioning/AbstractConvexHyperplaneBoundedRegionTest.java
##########
@@ -33,6 +33,8 @@
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
+import static org.junit.jupiter.api.Assertions.assertThrows;

Review comment:
       Agreed. For consistency, we should use the qualified `Assertions.assertThrows(...)` instead of just `assertThrows(...)`. This convention is used in commons-math and commons-numbers as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org