You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/25 14:19:49 UTC

[GitHub] [arrow] lidavidm commented on a change in pull request #10579: ARROW-11932: [C++] Implement ArrayBuilder::AppendScalar

lidavidm commented on a change in pull request #10579:
URL: https://github.com/apache/arrow/pull/10579#discussion_r658801294



##########
File path: cpp/src/arrow/array/builder_base.h
##########
@@ -116,6 +116,10 @@ class ARROW_EXPORT ArrayBuilder {
   /// This method is useful when appending null values to a parent nested type.
   virtual Status AppendEmptyValues(int64_t length) = 0;
 
+  /// \brief Append a value from a scalar
+  virtual Status AppendScalar(const Scalar& scalar);
+  virtual Status AppendScalars(const ScalarVector& scalars);

Review comment:
       Good point, I've added the overload.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org