You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/10/20 17:54:15 UTC

[kudu-CR] tool action test.cc: specify lambda return type 

Hello Adar Dembo,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/4773

to review the following change.

Change subject: tool_action_test.cc: specify lambda return type
......................................................................

tool_action_test.cc: specify lambda return type

A user reported that they were unable to compile tool_action_test.cc on
OS X 10.11 with either the system Clang or thirdparty Clang. It appears
that these toolchains are not able to infer the correct return type for
a lambda. I'm not able to repro the failure, but the original user
confirmed that this patch fixed the issue. Failure:

    /Users/<user>/ProjectFiles/kudu/src/kudu/tools/tool_action_test.cc:384:5: error: return type 'kudu::Status' must match previous return type 'const ::kudu::Status' when lambda
          expression has unspecified explicit return type
        return Status::OK();
        ^
    1 error generated.

Change-Id: I52824e85a37c67bea8a2373264e8198d8d2294f4
---
M src/kudu/tools/tool_action_test.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/4773/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I52824e85a37c67bea8a2373264e8198d8d2294f4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>

[kudu-CR] tool action test.cc: specify lambda return type

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.

Change subject: tool_action_test.cc: specify lambda return type
......................................................................


tool_action_test.cc: specify lambda return type

A user reported that they were unable to compile tool_action_test.cc on
OS X 10.11 with either the system Clang or thirdparty Clang. It appears
that these toolchains are not able to infer the correct return type for
a lambda. I'm not able to repro the failure, but the original user
confirmed that this patch fixed the issue. Failure:

    /Users/<user>/ProjectFiles/kudu/src/kudu/tools/tool_action_test.cc:384:5: error: return type 'kudu::Status' must match previous return type 'const ::kudu::Status' when lambda
          expression has unspecified explicit return type
        return Status::OK();
        ^
    1 error generated.

Change-Id: I52824e85a37c67bea8a2373264e8198d8d2294f4
Reviewed-on: http://gerrit.cloudera.org:8080/4773
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/tools/tool_action_test.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I52824e85a37c67bea8a2373264e8198d8d2294f4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] tool action test.cc: specify lambda return type

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: tool_action_test.cc: specify lambda return type
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52824e85a37c67bea8a2373264e8198d8d2294f4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No