You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by xiaosuo <gi...@git.apache.org> on 2017/03/20 06:44:10 UTC
[GitHub] thrift pull request #1217: TSocket: Don't close connections when failing to ...
GitHub user xiaosuo opened a pull request:
https://github.com/apache/thrift/pull/1217
TSocket: Don't close connections when failing to read/write
Sockets maybe registered to a event base of libevent, so the
following epoll_ctl(2) may fail due to EBADF, or may
delete other sockets. Chaos occurs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xiaosuo/thrift close-early
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1217.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1217
----
commit 6947f4d4664f0bfbd028760fdf5c3b03e3cd24ba
Author: Changli Gao <xi...@gmail.com>
Date: 2017-03-20T06:36:57Z
TSocket: Don't close connections when failing to read/write
Sockets maybe registered to a event base of libevent, so the
following epoll_ctl(2) may fail due to EBADF, or may
delete other sockets. Chaos occurs.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1217: TSocket: Don't close connections when failing to read/wr...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1217
THRIFT-4162
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1217: TSocket: Don't close connections when failing to ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1217
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1217: TSocket: Don't close connections when failing to read/wr...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1217
Please rebase against upstream/master and force push to kick a new build. I'd like to see CI pass (or get much closer) before merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1217: TSocket: Don't close connections when failing to read/wr...
Posted by xiaosuo <gi...@git.apache.org>.
Github user xiaosuo commented on the issue:
https://github.com/apache/thrift/pull/1217
I checked other call sites, and found no issue. Because we will close the connection in the destructor, we won't leak fds at least.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---