You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Kay Kay (JIRA)" <ji...@apache.org> on 2009/12/28 05:22:29 UTC
[jira] Created: (HADOOP-6471) StringBuilder -> StringBuilder
unnecessary references
StringBuilder -> StringBuilder unnecessary references
------------------------------------------------------
Key: HADOOP-6471
URL: https://issues.apache.org/jira/browse/HADOOP-6471
Project: Hadoop Common
Issue Type: Bug
Reporter: Kay Kay
Fix For: 0.20.2
Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6471) StringBuffer -> StringBuilder -
conversion of references as necessary
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797676#action_12797676 ]
Tom White commented on HADOOP-6471:
-----------------------------------
Changing the return type of a public method is still an incompatible change, however. The old method needs to be deprecated first, before removing it. The new method would have to have a different name since methods can't be overloaded on return type alone.
> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HADOOP-6471.patch, HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6471) StringBuffer -> StringBuilder -
conversion of references as necessary
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated HADOOP-6471:
----------------------------
Issue Type: Improvement (was: Bug)
> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.20.2
>
> Attachments: HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6471) StringBuffer -> StringBuilder -
conversion of references as necessary
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated HADOOP-6471:
----------------------------
Fix Version/s: (was: 0.20.2)
0.21.0
Moving to higher revision as it is not a bug fix.
> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6471) StringBuffer -> StringBuilder -
conversion of references as necessary
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848661#action_12848661 ]
Hudson commented on HADOOP-6471:
--------------------------------
Integrated in Hadoop-Common-trunk #285 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/285/])
. StringBuffer -> StringBuilder - conversion of references as necessary. Contributed by Kay Kay.
> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 0.22.0
>
> Attachments: HADOOP-6471.patch, HADOOP-6471.patch, HADOOP-6471.patch, HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6471) StringBuffer -> StringBuilder -
conversion of references as necessary
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated HADOOP-6471:
----------------------------
Status: Open (was: Patch Available)
> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HADOOP-6471.patch, HADOOP-6471.patch, HADOOP-6471.patch, HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6471) StringBuffer -> StringBuilder -
conversion of references as necessary
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated HADOOP-6471:
----------------------------
Status: Patch Available (was: Open)
> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HADOOP-6471.patch, HADOOP-6471.patch, HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6471) StringBuffer -> StringBuilder -
conversion of references as necessary
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated HADOOP-6471:
----------------------------
Status: Patch Available (was: Open)
> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HADOOP-6471.patch, HADOOP-6471.patch, HADOOP-6471.patch, HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6471) StringBuffer -> StringBuilder -
conversion of references as necessary
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803988#action_12803988 ]
Kay Kay commented on HADOOP-6471:
---------------------------------
can somebody help review this ..
> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HADOOP-6471.patch, HADOOP-6471.patch, HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6471) StringBuffer -> StringBuilder -
conversion of references as necessary
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12799519#action_12799519 ]
Hadoop QA commented on HADOOP-6471:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12429959/HADOOP-6471.patch
against trunk revision 897023.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 12 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/271/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/271/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/271/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/271/console
This message is automatically generated.
> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HADOOP-6471.patch, HADOOP-6471.patch, HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6471) StringBuffer -> StringBuilder -
conversion of references as necessary
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated HADOOP-6471:
----------------------------
Attachment: HADOOP-6471.patch
Methods deprecated:
Environment.runCommand(String)
Enrivonment.runCommand(String[])
LocalStore.pack(SerializedRecord)
Methods added:
Environment.runCommandGeneric(String)
Environment.runCommandGeneric(String[])
LocalStore.packConcurrent(SerializedRecord)
$ grep '^-' HADOOP-6471.patch | grep public
returns no entries.
> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HADOOP-6471.patch, HADOOP-6471.patch, HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6471) StringBuffer -> StringBuilder -
conversion of references as necessary
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797775#action_12797775 ]
Kay Kay commented on HADOOP-6471:
---------------------------------
{quote}
Changing the return type of a public method is still an incompatible change, however. The old method needs to be deprecated first, before removing it. The new method would have to have a different name since methods can't be overloaded on return type alone.
{quote}
Understandable. Will post a revised one with the deprecated marker as well.
> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HADOOP-6471.patch, HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6471) StringBuilder -> StringBuilder
unnecessary references
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated HADOOP-6471:
----------------------------
Status: Patch Available (was: Open)
> StringBuilder -> StringBuilder unnecessary references
> ------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Kay Kay
> Fix For: 0.20.2
>
> Attachments: HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6471) StringBuilder -> StringBuilder
unnecessary references
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794764#action_12794764 ]
Hadoop QA commented on HADOOP-6471:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12429003/HADOOP-6471.patch
against trunk revision 893666.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 12 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/242/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/242/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/242/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/242/console
This message is automatically generated.
> StringBuilder -> StringBuilder unnecessary references
> ------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Kay Kay
> Fix For: 0.20.2
>
> Attachments: HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6471) StringBuffer -> StringBuilder -
conversion of references as necessary
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797582#action_12797582 ]
Steve Loughran commented on HADOOP-6471:
----------------------------------------
that would be OK to me, and this is a contrib/ so it's less critical. What do others think?
> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HADOOP-6471.patch, HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6471) StringBuffer -> StringBuilder -
conversion of references as necessary
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831652#action_12831652 ]
Hadoop QA commented on HADOOP-6471:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12434582/HADOOP-6471.patch
against trunk revision 907956.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 12 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/349/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/349/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/349/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/349/console
This message is automatically generated.
> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HADOOP-6471.patch, HADOOP-6471.patch, HADOOP-6471.patch, HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6471) StringBuffer -> StringBuilder -
conversion of references as necessary
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated HADOOP-6471:
----------------------------
Status: Open (was: Patch Available)
> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HADOOP-6471.patch, HADOOP-6471.patch, HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6471) StringBuffer -> StringBuilder -
conversion of references as necessary
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842373#action_12842373 ]
Kay Kay commented on HADOOP-6471:
---------------------------------
This patch seems to pass the test cases. Can somebody with committer access help look into this before the patch becomes out of sync with the trunk.
> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HADOOP-6471.patch, HADOOP-6471.patch, HADOOP-6471.patch, HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6471) StringBuffer -> StringBuilder -
conversion of references as necessary
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797657#action_12797657 ]
Kay Kay commented on HADOOP-6471:
---------------------------------
Actually CharSequence fits the syntax better. Revised patch attached.
> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HADOOP-6471.patch, HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6471) StringBuffer -> StringBuilder -
conversion of references as necessary
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-6471:
------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.21.0)
0.22.0
Assignee: Kay Kay
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
+1 I've just committed this. Thanks Kay Kay!
> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 0.22.0
>
> Attachments: HADOOP-6471.patch, HADOOP-6471.patch, HADOOP-6471.patch, HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6471) StringBuffer -> StringBuilder -
conversion of references as necessary
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848294#action_12848294 ]
Hudson commented on HADOOP-6471:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #207 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/207/])
. StringBuffer -> StringBuilder - conversion of references as necessary. Contributed by Kay Kay.
> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kay Kay
> Assignee: Kay Kay
> Fix For: 0.22.0
>
> Attachments: HADOOP-6471.patch, HADOOP-6471.patch, HADOOP-6471.patch, HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6471) StringBuilder -> StringBuilder
unnecessary references
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated HADOOP-6471:
----------------------------
Attachment: HADOOP-6471.patch
> StringBuilder -> StringBuilder unnecessary references
> ------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Kay Kay
> Fix For: 0.20.2
>
> Attachments: HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6471) StringBuffer -> StringBuilder -
conversion of references as necessary
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated HADOOP-6471:
----------------------------
Attachment: HADOOP-6471.patch
> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HADOOP-6471.patch, HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6471) StringBuffer -> StringBuilder -
conversion of references as necessary
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797053#action_12797053 ]
Steve Loughran commented on HADOOP-6471:
----------------------------------------
I'm +1 to going s/StringBuffer/r/StringBuilder/ inside methods, but this patch also changes some of the public methods in classes in contrib/failmon, which could have compatibility issues. Better to omit those, or, if there is a pressing need to change their signature, switch them to returning a string or a char sequence, either of which will hide the details of how the string is built up
> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6471) StringBuffer -> StringBuilder -
conversion of references as necessary
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated HADOOP-6471:
----------------------------
Attachment: HADOOP-6471.patch
sync-ing with trunk
> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HADOOP-6471.patch, HADOOP-6471.patch, HADOOP-6471.patch, HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6471) StringBuffer -> StringBuilder -
conversion of references as necessary
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797431#action_12797431 ]
Kay Kay commented on HADOOP-6471:
---------------------------------
| I'm +1 to going s/StringBuffer/r/StringBuilder/ inside methods, but this patch also changes some of the public methods in classes in contrib/failmon, which could have compatibility issues. Better to omit those, or, if there is a pressing need to change their signature, switch them to returning a string or a char sequence, either of which will hide the details of how the string is built up
Those changes were because they were used by one of the internal methods using StringBuffer - so they go in with this change. Agree about loosely coupled type in the signature though. Woud java.lang.Appendable be ok ?
> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6471) StringBuffer -> StringBuilder -
conversion of references as necessary
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated HADOOP-6471:
----------------------------
Summary: StringBuffer -> StringBuilder - conversion of references as necessary (was: StringBuilder -> StringBuilder unnecessary references )
> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
> Key: HADOOP-6471
> URL: https://issues.apache.org/jira/browse/HADOOP-6471
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Kay Kay
> Fix For: 0.20.2
>
> Attachments: HADOOP-6471.patch
>
>
> Across hadoop-common codebase, a good number of StringBuffer-s being used are actually candidates for StringBuilders , since the reference does not escape the scope of the method and no concurrency is needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.