You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/06/28 17:26:27 UTC
[Impala-ASF-CR] [tools] Comment out empty export
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18677
Change subject: [tools] Comment out empty export
......................................................................
[tools] Comment out empty export
Startup scripts require that IMPALA_CLUSTER_MAX_MEM_GB be set to a valid
value, or not set. In zsh, calling `export FOO` twice results in setting
the variable to an empty string (arguably a bug), so sourcing
impala-config.sh is non-idempotent.
Comments out `export IMPALA_CLUSTER_MAX_MEM_GB` so it won't be marked
for export. Preserves it as documentation.
Change-Id: I288281704480e1564a27984d5e23a54fd39b5570
---
M bin/impala-config.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/18677/1
--
To view, visit http://gerrit.cloudera.org:8080/18677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I288281704480e1564a27984d5e23a54fd39b5570
Gerrit-Change-Number: 18677
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] [tools] Comment out empty export
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18677 )
Change subject: [tools] Comment out empty export
......................................................................
[tools] Comment out empty export
Startup scripts require that IMPALA_CLUSTER_MAX_MEM_GB be set to a valid
value, or not set. In zsh, calling `export FOO` twice results in setting
the variable to an empty string (arguably a bug), so sourcing
impala-config.sh is non-idempotent.
Comments out `export IMPALA_CLUSTER_MAX_MEM_GB` so it won't be marked
for export and updates it to provide clearer documentation.
Change-Id: I288281704480e1564a27984d5e23a54fd39b5570
Reviewed-on: http://gerrit.cloudera.org:8080/18677
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
---
M bin/impala-config.sh
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved
Michael Smith: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I288281704480e1564a27984d5e23a54fd39b5570
Gerrit-Change-Number: 18677
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] [tools] Comment out empty export
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18677 )
Change subject: [tools] Comment out empty export
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I288281704480e1564a27984d5e23a54fd39b5570
Gerrit-Change-Number: 18677
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 May 2023 20:30:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Comment out empty export
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Riza Suminto, Joe McDonnell, Impala Public Jenkins, John Sherman,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18677
to look at the new patch set (#4).
Change subject: [tools] Comment out empty export
......................................................................
[tools] Comment out empty export
Startup scripts require that IMPALA_CLUSTER_MAX_MEM_GB be set to a valid
value, or not set. In zsh, calling `export FOO` twice results in setting
the variable to an empty string (arguably a bug), so sourcing
impala-config.sh is non-idempotent.
Comments out `export IMPALA_CLUSTER_MAX_MEM_GB` so it won't be marked
for export and updates it to provide clearer documentation.
Change-Id: I288281704480e1564a27984d5e23a54fd39b5570
---
M bin/impala-config.sh
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/18677/4
--
To view, visit http://gerrit.cloudera.org:8080/18677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I288281704480e1564a27984d5e23a54fd39b5570
Gerrit-Change-Number: 18677
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] [tools] Comment out empty export
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18677 )
Change subject: [tools] Comment out empty export
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10893/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I288281704480e1564a27984d5e23a54fd39b5570
Gerrit-Change-Number: 18677
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jun 2022 17:48:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Comment out empty export
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18677 )
Change subject: [tools] Comment out empty export
......................................................................
Patch Set 5: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9269/
--
To view, visit http://gerrit.cloudera.org:8080/18677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I288281704480e1564a27984d5e23a54fd39b5570
Gerrit-Change-Number: 18677
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 May 2023 01:51:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Comment out empty export
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has removed a vote on this change.
Change subject: [tools] Comment out empty export
......................................................................
Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/18677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I288281704480e1564a27984d5e23a54fd39b5570
Gerrit-Change-Number: 18677
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] [tools] Comment out empty export
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18677 )
Change subject: [tools] Comment out empty export
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12904/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I288281704480e1564a27984d5e23a54fd39b5570
Gerrit-Change-Number: 18677
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 May 2023 20:12:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Comment out empty export
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18677 )
Change subject: [tools] Comment out empty export
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18677/3/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/18677/3/bin/impala-config.sh@132
PS3, Line 132: # To limit maximum memory available for the mini-cluster and CDH cluster, add the
: # following in $IMPALA_HOME/bin/im
> Nit: Can we update the comment to tell people they can set the maximum memo
Done
--
To view, visit http://gerrit.cloudera.org:8080/18677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I288281704480e1564a27984d5e23a54fd39b5570
Gerrit-Change-Number: 18677
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 May 2023 19:51:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [tools] Comment out empty export
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18677 )
Change subject: [tools] Comment out empty export
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9274/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I288281704480e1564a27984d5e23a54fd39b5570
Gerrit-Change-Number: 18677
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 May 2023 16:00:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Comment out empty export
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18677 )
Change subject: [tools] Comment out empty export
......................................................................
Patch Set 4: Code-Review+2
Thanks, this looks good
--
To view, visit http://gerrit.cloudera.org:8080/18677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I288281704480e1564a27984d5e23a54fd39b5570
Gerrit-Change-Number: 18677
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 May 2023 19:53:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Comment out empty export
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18677 )
Change subject: [tools] Comment out empty export
......................................................................
Patch Set 6: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9274/
--
To view, visit http://gerrit.cloudera.org:8080/18677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I288281704480e1564a27984d5e23a54fd39b5570
Gerrit-Change-Number: 18677
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 May 2023 21:21:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Comment out empty export
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18677 )
Change subject: [tools] Comment out empty export
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9269/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I288281704480e1564a27984d5e23a54fd39b5570
Gerrit-Change-Number: 18677
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 May 2023 20:30:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Comment out empty export
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18677 )
Change subject: [tools] Comment out empty export
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
This makes sense to me. If we could modify the sentence that we leave there to tell people to put it in bin/impala-config-local.sh, then that works for me.
http://gerrit.cloudera.org:8080/#/c/18677/3/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/18677/3/bin/impala-config.sh@132
PS3, Line 132: # Maximum memory available for mini-cluster and CDH cluster
: # export IMPALA_CLUSTER_MAX_MEM_GB
Nit: Can we update the comment to tell people they can set the maximum memory available by adding "export IMPALA_CLUSTER_MAX_MEM_GB=value" in bin/impala-config-local.sh?
--
To view, visit http://gerrit.cloudera.org:8080/18677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I288281704480e1564a27984d5e23a54fd39b5570
Gerrit-Change-Number: 18677
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 May 2023 19:04:51 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [tools] Comment out empty export
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18677 )
Change subject: [tools] Comment out empty export
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I288281704480e1564a27984d5e23a54fd39b5570
Gerrit-Change-Number: 18677
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 May 2023 16:00:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Comment out empty export
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18677 )
Change subject: [tools] Comment out empty export
......................................................................
Patch Set 6: Verified+1
Passed all tests across two different runs. Latest was a known issue with python-check-ub2004 that's been fixed but not picked up in a rebase.
--
To view, visit http://gerrit.cloudera.org:8080/18677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I288281704480e1564a27984d5e23a54fd39b5570
Gerrit-Change-Number: 18677
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 May 2023 21:29:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Comment out empty export
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18677 )
Change subject: [tools] Comment out empty export
......................................................................
Patch Set 3: Code-Review+1
I'm using zsh and hit this a lot.
Either of commenting it like this, or wrapping it with branch detecting shell type is not zsh is fine to me.
--
To view, visit http://gerrit.cloudera.org:8080/18677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I288281704480e1564a27984d5e23a54fd39b5570
Gerrit-Change-Number: 18677
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Apr 2023 19:18:20 +0000
Gerrit-HasComments: No