You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cayenne.apache.org by Aristedes Maniatis <ar...@maniatis.org> on 2009/12/12 05:22:01 UTC

sqlite failed tests

Yes, sqlite isn't a 'real' database. But we support it, so clearly documenting (within Cayenne) what it can't do is important. So for instance, the org.apache.cayenne.merge functions should perhaps return 'unsupported' exceptions when trying to run on that database. Perhaps each adaptor needs a supportsMerging() feature.

I'd like to leave this test running on Hudson for a while. Perhaps someone who knows something about sqlite (I've never used it) can suggest what we need to do with it. Far better for users to get a relevant exception than for things to silently fail.

I'm far less keen on hacking the unit tests to stop them complaining. Then users will try to use the features which don't work and get unexpected and wrong results.

Ari


On 12/12/09 3:09 PM, Apache Hudson Server wrote:
> Failed tests:
>    testAddTable(org.apache.cayenne.merge.CreateTableToModelTest)
>    testForreignKey(org.apache.cayenne.merge.DropRelationshipToModelTest)
>    test(org.apache.cayenne.merge.ValueForNullTest)
>    testSimpleColumn(org.apache.cayenne.merge.DropColumnToModelTest)
>    testRemoveFKColumnWithoutRelationshipInDb(org.apache.cayenne.merge.DropColumnToModelTest)
>    test(org.apache.cayenne.merge.SetPrimaryKeyToDbTest)
>    test(org.apache.cayenne.merge.SetAllowNullToDbTest)
>    testAddAndDropColumnToDb(org.apache.cayenne.merge.MergerFactoryTest)
>    testChangeVarcharSizeToDb(org.apache.cayenne.merge.MergerFactoryTest)
>    testMultipleTokensToDb(org.apache.cayenne.merge.MergerFactoryTest)
>    testAddTableToDb(org.apache.cayenne.merge.MergerFactoryTest)
>    testAddForeignKeyWithTable(org.apache.cayenne.merge.MergerFactoryTest)
>    testAddForeignKeyAfterTable(org.apache.cayenne.merge.MergerFactoryTest)
>    test(org.apache.cayenne.merge.SetNotNullToDbTest)
>    testMerging(org.apache.cayenne.util.EntityMergeSupportTest)
>    testSQLTemplateTimestamp(org.apache.cayenne.access.DateTimeTypesTest)
>    testSQLTemplateDate(org.apache.cayenne.access.DateTimeTypesTest)
>    testSQLTemplateTime(org.apache.cayenne.access.DateTimeTypesTest)
>    testAddColumn(org.apache.cayenne.merge.AddColumnToModelTest)
>    testDropTable(org.apache.cayenne.merge.DropTableToModelTest)
>
> Tests in error:
>    testLongIn(org.apache.cayenne.exp.ExpressionFactoryTest)
>    testMultiDBUpdate(org.apache.cayenne.access.DataContextCrossDBTest)
>    testSelectCompound1(org.apache.cayenne.access.DataContextFlattenedAttributesTest)
>    testSelectCompound2(org.apache.cayenne.access.DataContextFlattenedAttributesTest)
>    testSelectEJQBQL(org.apache.cayenne.access.DataContextFlattenedAttributesTest)
>    testWithoutResultDirective(org.apache.cayenne.access.jdbc.ResultDirectiveTest)
>    testWithOnlyResultDirective(org.apache.cayenne.access.jdbc.ResultDirectiveTest)
>    testWithMixedDirectiveUse1(org.apache.cayenne.access.jdbc.ResultDirectiveTest)
>    testWithMixedDirectiveUse2(org.apache.cayenne.access.jdbc.ResultDirectiveTest)
>    testBindingForCollection(org.apache.cayenne.access.jdbc.BindDirectiveTest)
>    testBindForPassedNullParam(org.apache.cayenne.access.jdbc.BindDirectiveTest)
>    testBindWithJDBCForPassedNullParam(org.apache.cayenne.access.jdbc.BindDirectiveTest)
>    testBindForNotPassedParam(org.apache.cayenne.access.jdbc.BindDirectiveTest)
>    testBindWithJDBCForNotPassedParam(org.apache.cayenne.access.jdbc.BindDirectiveTest)
>    testNewObject(org.apache.cayenne.access.IdentityColumnsTest)
>    testCAY823(org.apache.cayenne.access.IdentityColumnsTest)
>    testUnrelatedUpdate(org.apache.cayenne.access.IdentityColumnsTest)
>    testMultipleNewObjectsSeparateTables(org.apache.cayenne.access.IdentityColumnsTest)
>    testMultipleNewObjects(org.apache.cayenne.access.IdentityColumnsTest)
>    testCompoundPKWithGeneratedColumn(org.apache.cayenne.access.IdentityColumnsTest)
>    testUpdateDependentWithNewMaster(org.apache.cayenne.access.IdentityColumnsTest)
>    testPropagateToDependent(org.apache.cayenne.access.IdentityColumnsTest)

-- 

-------------------------->
Aristedes Maniatis
GPG fingerprint CBFB 84B4 738D 4E87 5E5C  5EFA EF6A 7D2E 3E49 102A

Re: sqlite failed tests

Posted by Andrus Adamchik <an...@objectstyle.org>.
Thanks for disabling the emails. I guess that's all we need to do on  
the short run.

Andrus

On Dec 12, 2009, at 6:24 PM, Aristedes Maniatis wrote:

> On 13/12/09 6:24 AM, Andrus Adamchik wrote:
>> Now it looks like we'll be getting hudson failure emails on every  
>> commit
>> :-/
>
> Yeah, I think that's because the tests don't just fail, they have  
> errors. I'll disable the emails for now since they are getting  
> annoying. We need to figure out why the errors are occuring, but I  
> don't think I'll have time this side of Christmas.
>
> Ari
>
> -- 
>
> -------------------------->
> Aristedes Maniatis
> GPG fingerprint CBFB 84B4 738D 4E87 5E5C  5EFA EF6A 7D2E 3E49 102A
>


Re: sqlite failed tests

Posted by Aristedes Maniatis <ar...@maniatis.org>.
On 13/12/09 6:24 AM, Andrus Adamchik wrote:
> Now it looks like we'll be getting hudson failure emails on every commit
> :-/

Yeah, I think that's because the tests don't just fail, they have errors. I'll disable the emails for now since they are getting annoying. We need to figure out why the errors are occuring, but I don't think I'll have time this side of Christmas.

Ari

-- 

-------------------------->
Aristedes Maniatis
GPG fingerprint CBFB 84B4 738D 4E87 5E5C  5EFA EF6A 7D2E 3E49 102A

Re: sqlite failed tests

Posted by Andrus Adamchik <an...@objectstyle.org>.
Now it looks like we'll be getting hudson failure emails on every  
commit :-/

On Dec 11, 2009, at 11:22 PM, Aristedes Maniatis wrote:

> Yes, sqlite isn't a 'real' database. But we support it, so clearly  
> documenting (within Cayenne) what it can't do is important. So for  
> instance, the org.apache.cayenne.merge functions should perhaps  
> return 'unsupported' exceptions when trying to run on that database.  
> Perhaps each adaptor needs a supportsMerging() feature.
>
> I'd like to leave this test running on Hudson for a while. Perhaps  
> someone who knows something about sqlite (I've never used it) can  
> suggest what we need to do with it. Far better for users to get a  
> relevant exception than for things to silently fail.
>
> I'm far less keen on hacking the unit tests to stop them  
> complaining. Then users will try to use the features which don't  
> work and get unexpected and wrong results.
>
> Ari
>
>
> On 12/12/09 3:09 PM, Apache Hudson Server wrote:
>> Failed tests:
>>   testAddTable(org.apache.cayenne.merge.CreateTableToModelTest)
>>    
>> testForreignKey(org.apache.cayenne.merge.DropRelationshipToModelTest)
>>   test(org.apache.cayenne.merge.ValueForNullTest)
>>   testSimpleColumn(org.apache.cayenne.merge.DropColumnToModelTest)
>>    
>> testRemoveFKColumnWithoutRelationshipInDb 
>> (org.apache.cayenne.merge.DropColumnToModelTest)
>>   test(org.apache.cayenne.merge.SetPrimaryKeyToDbTest)
>>   test(org.apache.cayenne.merge.SetAllowNullToDbTest)
>>    
>> testAddAndDropColumnToDb(org.apache.cayenne.merge.MergerFactoryTest)
>>    
>> testChangeVarcharSizeToDb(org.apache.cayenne.merge.MergerFactoryTest)
>>   testMultipleTokensToDb(org.apache.cayenne.merge.MergerFactoryTest)
>>   testAddTableToDb(org.apache.cayenne.merge.MergerFactoryTest)
>>    
>> testAddForeignKeyWithTable 
>> (org.apache.cayenne.merge.MergerFactoryTest)
>>    
>> testAddForeignKeyAfterTable 
>> (org.apache.cayenne.merge.MergerFactoryTest)
>>   test(org.apache.cayenne.merge.SetNotNullToDbTest)
>>   testMerging(org.apache.cayenne.util.EntityMergeSupportTest)
>>    
>> testSQLTemplateTimestamp(org.apache.cayenne.access.DateTimeTypesTest)
>>   testSQLTemplateDate(org.apache.cayenne.access.DateTimeTypesTest)
>>   testSQLTemplateTime(org.apache.cayenne.access.DateTimeTypesTest)
>>   testAddColumn(org.apache.cayenne.merge.AddColumnToModelTest)
>>   testDropTable(org.apache.cayenne.merge.DropTableToModelTest)
>>
>> Tests in error:
>>   testLongIn(org.apache.cayenne.exp.ExpressionFactoryTest)
>>   testMultiDBUpdate(org.apache.cayenne.access.DataContextCrossDBTest)
>>    
>> testSelectCompound1 
>> (org.apache.cayenne.access.DataContextFlattenedAttributesTest)
>>    
>> testSelectCompound2 
>> (org.apache.cayenne.access.DataContextFlattenedAttributesTest)
>>    
>> testSelectEJQBQL 
>> (org.apache.cayenne.access.DataContextFlattenedAttributesTest)
>>    
>> testWithoutResultDirective 
>> (org.apache.cayenne.access.jdbc.ResultDirectiveTest)
>>    
>> testWithOnlyResultDirective 
>> (org.apache.cayenne.access.jdbc.ResultDirectiveTest)
>>    
>> testWithMixedDirectiveUse1 
>> (org.apache.cayenne.access.jdbc.ResultDirectiveTest)
>>    
>> testWithMixedDirectiveUse2 
>> (org.apache.cayenne.access.jdbc.ResultDirectiveTest)
>>    
>> testBindingForCollection 
>> (org.apache.cayenne.access.jdbc.BindDirectiveTest)
>>    
>> testBindForPassedNullParam 
>> (org.apache.cayenne.access.jdbc.BindDirectiveTest)
>>    
>> testBindWithJDBCForPassedNullParam 
>> (org.apache.cayenne.access.jdbc.BindDirectiveTest)
>>    
>> testBindForNotPassedParam 
>> (org.apache.cayenne.access.jdbc.BindDirectiveTest)
>>    
>> testBindWithJDBCForNotPassedParam 
>> (org.apache.cayenne.access.jdbc.BindDirectiveTest)
>>   testNewObject(org.apache.cayenne.access.IdentityColumnsTest)
>>   testCAY823(org.apache.cayenne.access.IdentityColumnsTest)
>>   testUnrelatedUpdate(org.apache.cayenne.access.IdentityColumnsTest)
>>    
>> testMultipleNewObjectsSeparateTables 
>> (org.apache.cayenne.access.IdentityColumnsTest)
>>    
>> testMultipleNewObjects(org.apache.cayenne.access.IdentityColumnsTest)
>>    
>> testCompoundPKWithGeneratedColumn 
>> (org.apache.cayenne.access.IdentityColumnsTest)
>>    
>> testUpdateDependentWithNewMaster 
>> (org.apache.cayenne.access.IdentityColumnsTest)
>>    
>> testPropagateToDependent 
>> (org.apache.cayenne.access.IdentityColumnsTest)
>
> -- 
>
> -------------------------->
> Aristedes Maniatis
> GPG fingerprint CBFB 84B4 738D 4E87 5E5C  5EFA EF6A 7D2E 3E49 102A
>