[jira] [Commented] (HBASE-21456) Make WALFactory only used for creating WALProviders

["Reid Chan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-21456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683874#comment-16683874 ] 

Reid Chan commented on HBASE-21456:
-----------------------------------

Looks like Ted is working on it, but still in HBASE-21246.

Do we reach a consensus, or any info i needed to be synced?


> Make WALFactory only used for creating WALProviders
> ---------------------------------------------------
>
>                 Key: HBASE-21456
>                 URL: https://issues.apache.org/jira/browse/HBASE-21456
>             Project: HBase
>          Issue Type: Sub-task
>          Components: wal
>            Reporter: Josh Elser
>            Priority: Major
>
> As a Factory, WALFactory should only have one job: creating instances of WALProvider.
> However, over the years, it has been a landing place for lots of wal-related methods (e.g. constructing readers, WALEntryStream, and more). We want all of this to live in the WALProvider.
> We can do this in two steps: have the WALFactory methods invoke the method on the WALProvider (handled elsewhere), then here we can replace usage of the WALFactory "wrapper methods" with the WALProvider itself.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)