You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "yaooqinn (via GitHub)" <gi...@apache.org> on 2024/04/01 10:27:21 UTC

[PR] [SPARK-47666][SQL][3.4] Fix NPE when reading mysql bit array as LongType [spark]

yaooqinn opened a new pull request, #45793:
URL: https://github.com/apache/spark/pull/45793

   ### What changes were proposed in this pull request?
   
   This PR fixes NPE when reading mysql bit array as LongType
   
   ### Why are the changes needed?
   
   bugfix
   
   ### Does this PR introduce _any_ user-facing change?
   
   no
   
   ### How was this patch tested?
   
   new tests
   ### Was this patch authored or co-authored using generative AI tooling?
   
   no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-47666][SQL][3.4] Fix NPE when reading mysql bit array as LongType [spark]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #45793:
URL: https://github.com/apache/spark/pull/45793#issuecomment-2031954620

   Thanks @HyukjinKwon @dongjoon-hyun 
   
   Merged to 3.4


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-47666][SQL][3.4] Fix NPE when reading mysql bit array as LongType [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #45793:
URL: https://github.com/apache/spark/pull/45793#issuecomment-2029979040

   Could you fix the UT failures?
   ```
   [info] MySQLOverMariaConnectorIntegrationSuite:
   [info] - SPARK-47537: ensure use the right jdbc driver (2 milliseconds)
   [info] - Basic test (26 milliseconds)
   [info] - Numeric types *** FAILED *** (53 milliseconds)
   [info]   Array([false,549,17,77777,123456789,123456789012345,123456789012345.12345678901234500000,42.75,1.0000000000000002], [null,null,null,null,null,null,null,null,null]) had length 2 instead of expected length 1 (MySQLIntegrationSuite.scala:106)
   ...
   [info] MySQLIntegrationSuite:
   [info] - SPARK-47537: ensure use the right jdbc driver (13 milliseconds)
   [info] - Basic test (43 milliseconds)
   [info] - Numeric types *** FAILED *** (41 milliseconds)
   [info]   Array([false,549,17,77777,123456789,123456789012345,123456789012345.12345678901234500000,42.75,1.0000000000000002], [null,null,null,null,null,null,null,null,null]) had length 2 instead of expected length 1 (MySQLIntegrationSuite.scala:106)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-47666][SQL][3.4] Fix NPE when reading mysql bit array as LongType [spark]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn closed pull request #45793: [SPARK-47666][SQL][3.4] Fix NPE when reading mysql bit array as LongType
URL: https://github.com/apache/spark/pull/45793


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-47666][SQL][3.4] Fix NPE when reading mysql bit array as LongType [spark]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #45793:
URL: https://github.com/apache/spark/pull/45793#issuecomment-2029545554

   Thank you @HyukjinKwon, merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org