You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/07/19 11:16:21 UTC
[GitHub] [incubator-seatunnel] lhyundeadsoul opened a new pull request, #2214: StateT of SeaTunnelSource should extend `Serializable`
lhyundeadsoul opened a new pull request, #2214:
URL: https://github.com/apache/incubator-seatunnel/pull/2214
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] lhyundeadsoul commented on a diff in pull request #2214: StateT of SeaTunnelSource should extend `Serializable`
Posted by GitBox <gi...@apache.org>.
lhyundeadsoul commented on code in PR #2214:
URL: https://github.com/apache/incubator-seatunnel/pull/2214#discussion_r925114397
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/source/SeaTunnelSource.java:
##########
@@ -94,6 +94,8 @@ SourceSplitEnumerator<SplitT, StateT> restoreEnumerator(SourceSplitEnumerator.Co
*
* @return enumerator state serializer.
*/
- Serializer<StateT> getEnumeratorStateSerializer();
+ default Serializer<StateT> getEnumeratorStateSerializer(){
+ return new DefaultSerializer<>();
+ }
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X merged pull request #2214: StateT of SeaTunnelSource should extend `Serializable`
Posted by GitBox <gi...@apache.org>.
Hisoka-X merged PR #2214:
URL: https://github.com/apache/incubator-seatunnel/pull/2214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on pull request #2214: StateT of SeaTunnelSource should extend `Serializable`
Posted by GitBox <gi...@apache.org>.
ashulin commented on PR #2214:
URL: https://github.com/apache/incubator-seatunnel/pull/2214#issuecomment-1192103805
@Hisoka-X PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] lhyundeadsoul commented on pull request #2214: StateT of SeaTunnelSource should extend `Serializable`
Posted by GitBox <gi...@apache.org>.
lhyundeadsoul commented on PR #2214:
URL: https://github.com/apache/incubator-seatunnel/pull/2214#issuecomment-1189873125
@ashulin CI error :`Caused by: java.lang.ClassNotFoundException: org.apache.seatunnel.connectors.seatunnel.file.sink.local.LocalFileSink` has no matter with this PR. This error has already been in the current dev branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2214: StateT of SeaTunnelSource should extend `Serializable`
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #2214:
URL: https://github.com/apache/incubator-seatunnel/pull/2214#discussion_r925101529
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/source/SeaTunnelSource.java:
##########
@@ -94,6 +94,8 @@ SourceSplitEnumerator<SplitT, StateT> restoreEnumerator(SourceSplitEnumerator.Co
*
* @return enumerator state serializer.
*/
- Serializer<StateT> getEnumeratorStateSerializer();
+ default Serializer<StateT> getEnumeratorStateSerializer(){
+ return new DefaultSerializer<>();
+ }
Review Comment:
```suggestion
default Serializer<StateT> getEnumeratorStateSerializer() {
return new DefaultSerializer<>();
}
```
Keep the code style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org