You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/11/17 15:04:09 UTC

[GitHub] [bookkeeper] Vanlightly commented on a change in pull request #2901: Construct and inject bookie components

Vanlightly commented on a change in pull request #2901:
URL: https://github.com/apache/bookkeeper/pull/2901#discussion_r751330359



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLoggerAllocator.java
##########
@@ -185,7 +185,7 @@ private synchronized BufferedLogChannel allocateNewLog(File dirForNextEntryLog,
 
 
     private synchronized void closePreAllocateLog() {
-        if (preallocatedLogId != -1) {
+        if (preallocation != null) {

Review comment:
       Yeah, that was causing a test to fail so I fixed it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org