You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "BiteTheDDDDt (via GitHub)" <gi...@apache.org> on 2023/06/06 10:35:00 UTC
[GitHub] [doris] BiteTheDDDDt opened a new pull request, #20509: [Bug](planner) fix pre condition check fail on max(null)
BiteTheDDDDt opened a new pull request, #20509:
URL: https://github.com/apache/doris/pull/20509
## Proposed changes
fix pre condition check fail on max(null)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #20509: [Bug](planner) fix pre condition check fail on max(null)
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #20509:
URL: https://github.com/apache/doris/pull/20509#issuecomment-1578747158
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20509: [Bug](planner) fix pre condition check fail on max(null)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20509:
URL: https://github.com/apache/doris/pull/20509#issuecomment-1580986128
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20509: [Bug](planner) fix pre condition check fail on max(null)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20509:
URL: https://github.com/apache/doris/pull/20509#issuecomment-1580986209
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #20509: [Bug](planner) fix pre condition check fail on max(null)
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #20509:
URL: https://github.com/apache/doris/pull/20509#discussion_r1220748298
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java:
##########
@@ -986,14 +986,6 @@ public String toColumnLabel() {
// Convert this expr, including all children, to its Thrift representation.
public TExpr treeToThrift() {
- if (type.isNull()) {
- // Hack to ensure BE never sees TYPE_NULL. If an expr makes it this far without
- // being cast to a non-NULL type, the type doesn't matter and we can cast it
- // arbitrarily.
- Preconditions.checkState(this instanceof NullLiteral || this instanceof SlotRef
- || this instanceof VariableExpr);
- return NullLiteral.create(ScalarType.BOOLEAN).treeToThrift();
- }
Review Comment:
remove this means be could process all expressions with null type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #20509: [Bug](planner) fix pre condition check fail on max(null)
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #20509:
URL: https://github.com/apache/doris/pull/20509#discussion_r1220760313
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java:
##########
@@ -986,14 +986,6 @@ public String toColumnLabel() {
// Convert this expr, including all children, to its Thrift representation.
public TExpr treeToThrift() {
- if (type.isNull()) {
- // Hack to ensure BE never sees TYPE_NULL. If an expr makes it this far without
- // being cast to a non-NULL type, the type doesn't matter and we can cast it
- // arbitrarily.
- Preconditions.checkState(this instanceof NullLiteral || this instanceof SlotRef
- || this instanceof VariableExpr);
- return NullLiteral.create(ScalarType.BOOLEAN).treeToThrift();
- }
Review Comment:
>
The current backend will automatically treat null_type as bool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #20509: [Bug](planner) fix pre condition check fail on max(null)
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #20509:
URL: https://github.com/apache/doris/pull/20509#issuecomment-1578406238
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt merged pull request #20509: [Bug](planner) fix pre condition check fail on max(null)
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt merged PR #20509:
URL: https://github.com/apache/doris/pull/20509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org