You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/03/10 10:10:06 UTC

[GitHub] [iotdb] wangchao316 opened a new pull request #2797: [IOTDB-1204] set parameter in iotdb-cluster.properties

wangchao316 opened a new pull request #2797:
URL: https://github.com/apache/iotdb/pull/2797


   The WAIT_CLIENT_TIMEOUT_MS and maxConnectionForEachNode
   parameter controls the connection generation speed and affects cluster link access. Therefore, it can be configured in the iotdb-cluster file.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] neuyilan commented on a change in pull request #2797: [IOTDB-1204] set parameter in iotdb-cluster.properties

Posted by GitBox <gi...@apache.org>.
neuyilan commented on a change in pull request #2797:
URL: https://github.com/apache/iotdb/pull/2797#discussion_r591374985



##########
File path: cluster/src/assembly/resources/conf/iotdb-cluster.properties
##########
@@ -157,4 +157,11 @@ max_number_of_logs_per_fetch_on_disk=1000
 
 # When consistency level is set to mid, query will fail if the log lag exceeds max_read_log_lag
 # This default value is 1000
-max_read_log_lag=1000
\ No newline at end of file
+max_read_log_lag=1000
+
+# Max number of clients in a ClientPool of a member for one node.
+max_client_pernode_permember_number=1000
+
+# Wait for some timeout, if the old client is not released
+# A new client is created

Review comment:
       I think the annotation could be more clearer if it can be configurated by the user.
   ```suggestion
   # If the number of connections created for a node exceeds  `max_client_pernode_permember_number`, we need to wait so much time for other connections to be released until timeout, or a new connection will be created.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] wangchao316 commented on a change in pull request #2797: [IOTDB-1204] set parameter in iotdb-cluster.properties

Posted by GitBox <gi...@apache.org>.
wangchao316 commented on a change in pull request #2797:
URL: https://github.com/apache/iotdb/pull/2797#discussion_r591436112



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/config/ClusterConfig.java
##########
@@ -71,6 +71,9 @@
   /** max number of clients in a ClientPool of a member for one node. */
   private int maxClientPerNodePerMember = 1000;
 
+  /** Wait for some timeout, if the old client is not released A new client is created */

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] neuyilan merged pull request #2797: [IOTDB-1204] set parameter in iotdb-cluster.properties

Posted by GitBox <gi...@apache.org>.
neuyilan merged pull request #2797:
URL: https://github.com/apache/iotdb/pull/2797


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] neuyilan commented on a change in pull request #2797: [IOTDB-1204] set parameter in iotdb-cluster.properties

Posted by GitBox <gi...@apache.org>.
neuyilan commented on a change in pull request #2797:
URL: https://github.com/apache/iotdb/pull/2797#discussion_r591375414



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/config/ClusterConfig.java
##########
@@ -71,6 +71,9 @@
   /** max number of clients in a ClientPool of a member for one node. */
   private int maxClientPerNodePerMember = 1000;
 
+  /** Wait for some timeout, if the old client is not released A new client is created */

Review comment:
       The same as above

##########
File path: cluster/src/assembly/resources/conf/iotdb-cluster.properties
##########
@@ -157,4 +157,11 @@ max_number_of_logs_per_fetch_on_disk=1000
 
 # When consistency level is set to mid, query will fail if the log lag exceeds max_read_log_lag
 # This default value is 1000
-max_read_log_lag=1000
\ No newline at end of file
+max_read_log_lag=1000
+
+# Max number of clients in a ClientPool of a member for one node.
+max_client_pernode_permember_number=1000
+
+# Wait for some timeout, if the old client is not released
+# A new client is created

Review comment:
       I think the annotation could be more clearer if it can be configurated by the user.
   ```suggestion
   # If the number of connections created for a node exceeds  `max_client_pernode_permember_number`, you need to wait so much time for other connections to be released until timeout, or a new connection will be created.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org