You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2010/03/08 07:55:58 UTC
DO NOT REPLY [Bug 48870] New: avoid parallel arrays of base types
https://issues.apache.org/bugzilla/show_bug.cgi?id=48870
Summary: avoid parallel arrays of base types
Product: Tomcat 7
Version: unspecified
Platform: All
OS/Version: All
Status: NEW
Severity: enhancement
Priority: P2
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: hauser@acm.org
Created an attachment (id=25103)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=25103)
patch_parallelArrays.txt
having kind of 'synchronized' arrays, i.e. one of Strings and another one of
Integers appears to be a questionable programming pattern to me.
Pls find attached a hopefully more OO approach
see also bug 48158
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 48870] avoid parallel arrays of base types
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48870
--- Comment #1 from Ralf Hauser <ha...@acm.org> 2010-03-08 06:58:52 UTC ---
oops, the related RFE should have been Bug 48863
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 48870] avoid parallel arrays of base types
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48870
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #3 from Mark Thomas <ma...@apache.org> 2011-02-18 16:48:12 EST ---
Fixed in trunk and will be in 7.0.9 onwards. Since I agree with Chris's views,
the patch applied was along those lines.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: DO NOT REPLY [Bug 48870] New: avoid parallel arrays of base types
Posted by Tim Whittington <ti...@apache.org>.
I propose to replace the parallel arrays with a
ClassLoaderFactory.Repository(type, location) class and a
ClassLoaderFactory.RepositoryType enum.
(I know this is small fry, but just trying to get my feet under the
desk so to speak...)
Is the lack of such conventions now just a hangover from pre Java 5+
days, an intentional thing we'd like to hang onto, or just something
that wasn't important enough to change?
cheers
tim
On Mon, Mar 8, 2010 at 7:55 PM, <bu...@apache.org> wrote:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=48870
>
> Summary: avoid parallel arrays of base types
> Product: Tomcat 7
> Version: unspecified
> Platform: All
> OS/Version: All
> Status: NEW
> Severity: enhancement
> Priority: P2
> Component: Catalina
> AssignedTo: dev@tomcat.apache.org
> ReportedBy: hauser@acm.org
>
>
> Created an attachment (id=25103)
> --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25103)
> patch_parallelArrays.txt
>
> having kind of 'synchronized' arrays, i.e. one of Strings and another one of
> Integers appears to be a questionable programming pattern to me.
>
> Pls find attached a hopefully more OO approach
>
> see also bug 48158
>
> --
> Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are the assignee for the bug.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 48870] avoid parallel arrays of base types
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48870
--- Comment #2 from Christopher Schultz <ch...@christopherschultz.net> 2010-11-09 17:45:05 EST ---
Ralf,
Why did you submit a patch with deprecated items in it? Instead of documenting
the items to be deprecated, just go all the way with the enum.
Also, I'm not sure that BootLocation necessarily needs to implement
CharSequence. I think it would be cleaner for BootLocation to simply contain a
String (location) and enum type.
I don't happen to like the name BootLocation but that's just a matter of taste.
Maybe RepositoryLocation?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 48870] avoid parallel arrays of base types
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48870
Tim Whittington <ti...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P2 |P4
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org