You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "hvanhovell (via GitHub)" <gi...@apache.org> on 2023/07/10 19:26:23 UTC
[GitHub] [spark] hvanhovell opened a new pull request, #41925: [SPARK-44353][CONNECT][SQL] Remove StructType.toAttributes
hvanhovell opened a new pull request, #41925:
URL: https://github.com/apache/spark/pull/41925
### What changes were proposed in this pull request?
This PR removes StructType.toAttribute. It is being replace by DataTypeUtils.toAttribute(..).
### Why are the changes needed?
We want to move the DataType hierarchy into sql/api. We need to remove any catalyst specific API.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on pull request #41925: [SPARK-44353][CONNECT][SQL] Remove StructType.toAttributes
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on PR #41925:
URL: https://github.com/apache/spark/pull/41925#issuecomment-1629594577
cc @amaliujia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on pull request #41925: [SPARK-44353][CONNECT][SQL] Remove StructType.toAttributes
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on PR #41925:
URL: https://github.com/apache/spark/pull/41925#issuecomment-1631922767
Merging. Failure is related to ongoing buf work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #41925: [SPARK-44353][CONNECT][SQL] Remove StructType.toAttributes
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #41925:
URL: https://github.com/apache/spark/pull/41925#issuecomment-1633511786
It seems remove StructType.toAttributes will lead to break change.
Users always use this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell closed pull request #41925: [SPARK-44353][CONNECT][SQL] Remove StructType.toAttributes
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell closed pull request #41925: [SPARK-44353][CONNECT][SQL] Remove StructType.toAttributes
URL: https://github.com/apache/spark/pull/41925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org