[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4636: Documentation for completionConfig

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #4636: Documentation for completionConfig
URL: https://github.com/apache/incubator-pinot/pull/4636#discussion_r327833343
 
 

 ##########
 File path: docs/tableconfig_schema.rst
 ##########
 @@ -113,6 +113,25 @@ The ``segmentsConfig`` section has information about configuring the following:
       "segmentAssignmentStrategy": "BalanceNumSegmentAssignmentStrategy"
     },
 
+* Completion Config
+
+  You can also add a ``completionConfig`` section under the ``segmentsConfig`` section. Completion config holds information related to realtime segment completion. There's just 1 field in this config as of now, which is the ``completionMode``. The value of the ``completioMode`` decides how non-winner servers should replace the completed segment during realtime segment completion. Currently, the supported values are
 
 Review comment:
   s/1/one/
   
   Please add a couple of sentences on winner or non-winner (better use commit leader and commit follower) in the architecture section and then add a sentence here to refer to the arch section for what these mean. You can also point to the realtime design document  segment completion protocol section. for more read.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org