[jira] [Issue Comment Edited] (CXF-3873) Detail exceptions in JAASLoginInInterceptor (patch)

["Andrei Shakirin (Issue Comment Edited) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CXF-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132724#comment-13132724 ] 

Andrei Shakirin edited comment on CXF-3873 at 10/21/11 3:01 PM:
----------------------------------------------------------------

Correct patch (previous one was not for this issue, sorry)
                
      was (Author: ashakirin):
    Correct patch (previous one was not for this issue)
                  
> Detail exceptions in JAASLoginInInterceptor (patch)
> ---------------------------------------------------
>
>                 Key: CXF-3873
>                 URL: https://issues.apache.org/jira/browse/CXF-3873
>             Project: CXF
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.5
>         Environment: Windows
>            Reporter: Andrei Shakirin
>         Attachments: JAASLoginInterceptor-patch.java, SAAJOutInterceptor-patch.java
>
>
> Hi,
> I find one thing in JAASLoginInInterceptor a little bit dangerous from security perspective - exception handling.
> JAASLoginInInterceptor throws different exceptions with detail error messages in cases:
> - if user/password are not defined (SecurityException: NO_USER_PASSWORD)
> - and if authentication is failed (AuthenticationException: "Unauthorized : " + ex.getMessage())
> It is very practical for the development, but can give some advices to malicious application.
> I will prefere to throw generic security violation exception for both cases.
> Patch is attached

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira