[incubator-uniffle] branch master updated: [MINOR] test: untracked files created in ShuffleFlushManagerTest (#745)

[ck...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ckj pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new 938ebe8f [MINOR] test: untracked files created in ShuffleFlushManagerTest (#745)
938ebe8f is described below

commit 938ebe8f9f074d85488fdd79cf50df93352e4317
Author: Kaijie Chen <ck...@apache.org>
AuthorDate: Wed Mar 22 17:15:40 2023 +0800

    [MINOR] test: untracked files created in ShuffleFlushManagerTest (#745)
    
    ### What changes were proposed in this pull request?
    
    Fix remoteStorage path in fallbackWrittenWhenMultiStorageManagerEnableTest
    
    ### Why are the changes needed?
    
    Untracked files created in fallbackWrittenWhenMultiStorageManagerEnableTest
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    Before:
    
    ```console
    $ mvn test -Dtest=ShuffleFlushManagerTest#fallbackWrittenWhenMultiStorageManagerEnableTest
    ...
    $ git status
    On branch master
    Your branch is up to date with 'origin/master'.
    
    Untracked files:
      (use "git add <file>..." to include in what will be committed)
            server/test/
    
    nothing added to commit but untracked files present (use "git add" to track)
    $ ls server/test
    fallbackWrittenWhenMultiStorageManagerEnableTest/
    ```
    
    After:
    
    ```console
    $ mvn test -Dtest=ShuffleFlushManagerTest#fallbackWrittenWhenMultiStorageManagerEnableTest
    ...
    $ git status
    On branch fix-leak
    nothing to commit, working tree clean
    ```
---
 .../test/java/org/apache/uniffle/server/ShuffleFlushManagerTest.java   | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/server/src/test/java/org/apache/uniffle/server/ShuffleFlushManagerTest.java b/server/src/test/java/org/apache/uniffle/server/ShuffleFlushManagerTest.java
index 2d075b8e..497f6ca2 100644
--- a/server/src/test/java/org/apache/uniffle/server/ShuffleFlushManagerTest.java
+++ b/server/src/test/java/org/apache/uniffle/server/ShuffleFlushManagerTest.java
@@ -508,9 +508,8 @@ public class ShuffleFlushManagerTest extends HdfsTestBase {
         LocalStorageManagerFallbackStrategy.class.getCanonicalName());
 
     StorageManager storageManager = StorageManagerFactory.getInstance().createStorageManager(shuffleServerConf);
-    String remoteStorage = "test";
     String appId = "fallbackWrittenWhenMultiStorageManagerEnableTest";
-    storageManager.registerRemoteStorage(appId, new RemoteStorageInfo(remoteStorage));
+    storageManager.registerRemoteStorage(appId, new RemoteStorageInfo(remoteStorage.getPath()));
 
     ShuffleFlushManager flushManager = new ShuffleFlushManager(
         shuffleServerConf,