You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/12/11 17:55:28 UTC
Review Request 41259: HiveServer Upgrade Fails Because Of Missing
Kerberos Properties
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41259/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sumit Mohanty.
Bugs: AMBARI-14343
https://issues.apache.org/jira/browse/AMBARI-14343
Repository: ambari
Description
-------
When upgrading Hive from HDP 2.1 to HDP 2.3, Hive server will not start correctly if it has been Kerberized. This is because new properties introduced in HDP 2.2 and 2.3 are not being calculated and set on {{hive-site}}.
- If *not* kerberized, then we do nothing
- If Kerberized
{code}
"hive.cluster.delegation.token.store.class": "org.apache.hadoop.hive.thrift.ZooKeeperTokenStore",
"hive.zookeeper.quorum": "server1:2182,server2:2181,server2:2181"
"hive.cluster.delegation.token.store.zookeeper.connectString": "server1:2182,server2:2181,server2:2181"
{code}
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveKerberosConfigAction.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/YarnConfigCalculation.java 5953553
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ZooKeeperQuorumCalculator.java PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 015284d
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 1eab4ca
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/HiveKerberosConfigActionTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/41259/diff/
Testing
-------
mvn clean test
Thanks,
Jonathan Hurley
Re: Review Request 41259: HiveServer Upgrade Fails Because Of Missing
Kerberos Properties
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41259/
-----------------------------------------------------------
(Updated Dec. 11, 2015, 1:04 p.m.)
Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sumit Mohanty.
Bugs: AMBARI-14343
https://issues.apache.org/jira/browse/AMBARI-14343
Repository: ambari
Description
-------
When upgrading Hive from HDP 2.1 to HDP 2.3, Hive server will not start correctly if it has been Kerberized. This is because new properties introduced in HDP 2.2 and 2.3 are not being calculated and set on {{hive-site}}.
- If *not* kerberized, then we do nothing
- If Kerberized
{code}
"hive.cluster.delegation.token.store.class": "org.apache.hadoop.hive.thrift.ZooKeeperTokenStore",
"hive.zookeeper.quorum": "server1:2182,server2:2181,server2:2181"
"hive.cluster.delegation.token.store.zookeeper.connectString": "server1:2182,server2:2181,server2:2181"
{code}
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveKerberosConfigAction.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/YarnConfigCalculation.java 5953553
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ZooKeeperQuorumCalculator.java PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 015284d
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 1eab4ca
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 51c6029
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/HiveKerberosConfigActionTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/41259/diff/
Testing
-------
mvn clean test
Thanks,
Jonathan Hurley
Re: Review Request 41259: HiveServer Upgrade Fails Because Of Missing
Kerberos Properties
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41259/#review109970
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/YarnConfigCalculation.java (line 66)
<https://reviews.apache.org/r/41259/#comment169711>
Nice
- Alejandro Fernandez
On Dec. 11, 2015, 4:55 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41259/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2015, 4:55 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14343
> https://issues.apache.org/jira/browse/AMBARI-14343
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When upgrading Hive from HDP 2.1 to HDP 2.3, Hive server will not start correctly if it has been Kerberized. This is because new properties introduced in HDP 2.2 and 2.3 are not being calculated and set on {{hive-site}}.
>
> - If *not* kerberized, then we do nothing
> - If Kerberized
> {code}
> "hive.cluster.delegation.token.store.class": "org.apache.hadoop.hive.thrift.ZooKeeperTokenStore",
> "hive.zookeeper.quorum": "server1:2182,server2:2181,server2:2181"
> "hive.cluster.delegation.token.store.zookeeper.connectString": "server1:2182,server2:2181,server2:2181"
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveKerberosConfigAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/YarnConfigCalculation.java 5953553
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ZooKeeperQuorumCalculator.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 015284d
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 1eab4ca
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/HiveKerberosConfigActionTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41259/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 41259: HiveServer Upgrade Fails Because Of Missing
Kerberos Properties
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Dec. 11, 2015, 12:40 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveKerberosConfigAction.java, line 90
> > <https://reviews.apache.org/r/41259/diff/1/?file=1160218#file1160218line90>
> >
> > Formatting, hungarian
The Compoze gods would be angry at you. I normally don't use it, but when I have to represent both a String and a boolean (because, you know we have a silly Map<String,String> everywhere), then it's just simpler to use that notation style.
I'll confirm Boolean.parse handling nulls ...
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41259/#review109968
-----------------------------------------------------------
On Dec. 11, 2015, 11:55 a.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41259/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2015, 11:55 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14343
> https://issues.apache.org/jira/browse/AMBARI-14343
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When upgrading Hive from HDP 2.1 to HDP 2.3, Hive server will not start correctly if it has been Kerberized. This is because new properties introduced in HDP 2.2 and 2.3 are not being calculated and set on {{hive-site}}.
>
> - If *not* kerberized, then we do nothing
> - If Kerberized
> {code}
> "hive.cluster.delegation.token.store.class": "org.apache.hadoop.hive.thrift.ZooKeeperTokenStore",
> "hive.zookeeper.quorum": "server1:2182,server2:2181,server2:2181"
> "hive.cluster.delegation.token.store.zookeeper.connectString": "server1:2182,server2:2181,server2:2181"
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveKerberosConfigAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/YarnConfigCalculation.java 5953553
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ZooKeeperQuorumCalculator.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 015284d
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 1eab4ca
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/HiveKerberosConfigActionTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41259/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 41259: HiveServer Upgrade Fails Because Of Missing
Kerberos Properties
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41259/#review109968
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveKerberosConfigAction.java (line 86)
<https://reviews.apache.org/r/41259/#comment169709>
Formatting, hungarian. Also, Boolean.parseBoolean may handle nulls.
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveKerberosConfigAction.java (line 90)
<https://reviews.apache.org/r/41259/#comment169708>
Formatting, hungarian
- Nate Cole
On Dec. 11, 2015, 11:55 a.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41259/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2015, 11:55 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14343
> https://issues.apache.org/jira/browse/AMBARI-14343
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When upgrading Hive from HDP 2.1 to HDP 2.3, Hive server will not start correctly if it has been Kerberized. This is because new properties introduced in HDP 2.2 and 2.3 are not being calculated and set on {{hive-site}}.
>
> - If *not* kerberized, then we do nothing
> - If Kerberized
> {code}
> "hive.cluster.delegation.token.store.class": "org.apache.hadoop.hive.thrift.ZooKeeperTokenStore",
> "hive.zookeeper.quorum": "server1:2182,server2:2181,server2:2181"
> "hive.cluster.delegation.token.store.zookeeper.connectString": "server1:2182,server2:2181,server2:2181"
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveKerberosConfigAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/YarnConfigCalculation.java 5953553
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ZooKeeperQuorumCalculator.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 015284d
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 1eab4ca
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/HiveKerberosConfigActionTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41259/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>