You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/07/03 11:46:00 UTC
[GitHub] [ozone] mukul1987 opened a new pull request #2386: HDDS-5405. Refactor pom files for HadoopRpc and Grpc/Ratis compilation properties.
mukul1987 opened a new pull request #2386:
URL: https://github.com/apache/ozone/pull/2386
## What changes were proposed in this pull request?
Refactor the pom files to differentiate proto files compiled for hadooprpc and grpc related proto files
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5405
## How was this patch tested?
compilation succeeds and existing unit tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] mukul1987 merged pull request #2386: HDDS-5405. Refactor pom files for HadoopRpc and Grpc/Ratis compilation properties.
Posted by GitBox <gi...@apache.org>.
mukul1987 merged pull request #2386:
URL: https://github.com/apache/ozone/pull/2386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] mukul1987 commented on pull request #2386: HDDS-5405. Refactor pom files for HadoopRpc and Grpc/Ratis compilation properties.
Posted by GitBox <gi...@apache.org>.
mukul1987 commented on pull request #2386:
URL: https://github.com/apache/ozone/pull/2386#issuecomment-873933614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] mukul1987 commented on pull request #2386: HDDS-5405. Refactor pom files for HadoopRpc and Grpc/Ratis compilation properties.
Posted by GitBox <gi...@apache.org>.
mukul1987 commented on pull request #2386:
URL: https://github.com/apache/ozone/pull/2386#issuecomment-873934357
> Just to clarify my understanding, where we use hadoop rpc we use hadoop.rpc.version, where we use ratis grpc like datanode, we use grpc protobuf version.
>
> And also one more question, We have proto version printing previously hadoop rpc protobuf version, a question do we want to add 2 one with hadoop rpc and other grpc protobuf version also?
Yes, thats correct. I am now also including the protobuf versions in the output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] mukul1987 merged pull request #2386: HDDS-5405. Refactor pom files for HadoopRpc and Grpc/Ratis compilation properties.
Posted by GitBox <gi...@apache.org>.
mukul1987 merged pull request #2386:
URL: https://github.com/apache/ozone/pull/2386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] mukul1987 commented on pull request #2386: HDDS-5405. Refactor pom files for HadoopRpc and Grpc/Ratis compilation properties.
Posted by GitBox <gi...@apache.org>.
mukul1987 commented on pull request #2386:
URL: https://github.com/apache/ozone/pull/2386#issuecomment-873933614
Thanks for the reviews @ayushtkn and @bharatviswa504, I have addressed the review comments.
Also, I have created a jira to harmonize the protobuf version across both protocols.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org