You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by yl...@apache.org on 2023/11/18 13:49:05 UTC

svn commit: r1913930 - in /httpd/httpd/trunk/modules/proxy: balancers/mod_lbmethod_bybusyness.c mod_proxy_balancer.c proxy_util.c proxy_util.h

Author: ylavic
Date: Sat Nov 18 13:49:04 2023
New Revision: 1913930

URL: http://svn.apache.org/viewvc?rev=1913930&view=rev
Log:
mod_proxy: Follow up to r1912245: ap_proxy_ prefix for extern functions.

Even if they are not part of the API (not in mod_proxy.h) hence requires no
MMN bump, {get,set,increment_,decrement_}busy_count() being AP_PROXY_DECLARE()d
could name-collide with a third-party module's functions.

Rename them using the ap_proxy_ prefix, with an underscore after the verb for
for all of them too (for consistency), that is:
    ap_proxy_{get,set,increment,decrement}_busy_count()


Modified:
    httpd/httpd/trunk/modules/proxy/balancers/mod_lbmethod_bybusyness.c
    httpd/httpd/trunk/modules/proxy/mod_proxy_balancer.c
    httpd/httpd/trunk/modules/proxy/proxy_util.c
    httpd/httpd/trunk/modules/proxy/proxy_util.h

Modified: httpd/httpd/trunk/modules/proxy/balancers/mod_lbmethod_bybusyness.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/balancers/mod_lbmethod_bybusyness.c?rev=1913930&r1=1913929&r2=1913930&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/proxy/balancers/mod_lbmethod_bybusyness.c (original)
+++ httpd/httpd/trunk/modules/proxy/balancers/mod_lbmethod_bybusyness.c Sat Nov 18 13:49:04 2023
@@ -30,13 +30,13 @@ static APR_OPTIONAL_FN_TYPE(proxy_balanc
 static int is_best_bybusyness(proxy_worker *current, proxy_worker *prev_best, void *baton)
 {
     int *total_factor = (int *)baton;
-    apr_size_t current_busy = getbusy_count(current);
+    apr_size_t current_busy = ap_proxy_get_busy_count(current);
     apr_size_t prev_best_busy = 0;
 
     current->s->lbstatus += current->s->lbfactor;
     *total_factor += current->s->lbfactor;
     if (prev_best)
-        prev_best_busy = getbusy_count(prev_best);
+        prev_best_busy = ap_proxy_get_busy_count(prev_best);
      
 
     return (
@@ -72,7 +72,7 @@ static apr_status_t reset(proxy_balancer
     worker = (proxy_worker **)balancer->workers->elts;
     for (i = 0; i < balancer->workers->nelts; i++, worker++) {
         (*worker)->s->lbstatus = 0;
-        setbusy_count(*worker, 0); 
+        ap_proxy_set_busy_count(*worker, 0); 
     }
     return APR_SUCCESS;
 }

Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_balancer.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy_balancer.c?rev=1913930&r1=1913929&r2=1913930&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/proxy/mod_proxy_balancer.c (original)
+++ httpd/httpd/trunk/modules/proxy/mod_proxy_balancer.c Sat Nov 18 13:49:04 2023
@@ -623,8 +623,8 @@ static int proxy_balancer_pre_request(pr
         *worker = runtime;
     }
 
-    increment_busy_count(*worker);
-    apr_pool_cleanup_register(r->pool, *worker, decrement_busy_count,
+    ap_proxy_increment_busy_count(*worker);
+    apr_pool_cleanup_register(r->pool, *worker, ap_proxy_decrement_busy_count,
                               apr_pool_cleanup_null);
 
     /* Add balancer/worker info to env. */
@@ -1563,7 +1563,7 @@ static void balancer_display_page(reques
                           "</httpd:redirect>\n", NULL);
                 ap_rprintf(r,
                            "          <httpd:busy>%" APR_SIZE_T_FMT "</httpd:busy>\n",
-                           getbusy_count(worker));
+                           ap_proxy_get_busy_count(worker));
                 ap_rprintf(r, "          <httpd:lbset>%d</httpd:lbset>\n",
                            worker->s->lbset);
                 /* End proxy_worker_stat */
@@ -1736,7 +1736,7 @@ static void balancer_display_page(reques
                 ap_rvputs(r, ap_proxy_parse_wstatus(r->pool, worker), NULL);
                 ap_rputs("</td>", r);
                 ap_rprintf(r, "<td>%" APR_SIZE_T_FMT "</td>", worker->s->elected);
-                ap_rprintf(r, "<td>%" APR_SIZE_T_FMT "</td>", getbusy_count(worker));
+                ap_rprintf(r, "<td>%" APR_SIZE_T_FMT "</td>", ap_proxy_get_busy_count(worker));
                 ap_rprintf(r, "<td>%d</td><td>", worker->s->lbstatus);
                 ap_rputs(apr_strfsize(worker->s->transferred, fbuf), r);
                 ap_rputs("</td><td>", r);

Modified: httpd/httpd/trunk/modules/proxy/proxy_util.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/proxy_util.c?rev=1913930&r1=1913929&r2=1913930&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/proxy/proxy_util.c (original)
+++ httpd/httpd/trunk/modules/proxy/proxy_util.c Sat Nov 18 13:49:04 2023
@@ -5392,7 +5392,7 @@ PROXY_DECLARE(apr_status_t) ap_proxy_tun
     return APR_SUCCESS;
 }
 
-PROXY_DECLARE(apr_status_t) decrement_busy_count(void *worker_)
+PROXY_DECLARE(apr_status_t) ap_proxy_decrement_busy_count(void *worker_)
 {
     apr_size_t val;
     proxy_worker *worker = worker_;
@@ -5435,7 +5435,7 @@ PROXY_DECLARE(apr_status_t) decrement_bu
     return APR_SUCCESS;
 }
 
-PROXY_DECLARE(void) increment_busy_count(proxy_worker *worker)
+PROXY_DECLARE(void) ap_proxy_increment_busy_count(proxy_worker *worker)
 {
     apr_size_t val;
 #if APR_SIZEOF_VOIDP == 4
@@ -5475,7 +5475,7 @@ PROXY_DECLARE(void) increment_busy_count
 #endif
 }
 
-PROXY_DECLARE(apr_size_t) getbusy_count(proxy_worker *worker)
+PROXY_DECLARE(apr_size_t) ap_proxy_get_busy_count(proxy_worker *worker)
 {
     apr_size_t val;
 #if APR_SIZEOF_VOIDP == 4
@@ -5494,7 +5494,7 @@ PROXY_DECLARE(apr_size_t) getbusy_count(
     return val;
 }
 
-PROXY_DECLARE(void) setbusy_count(proxy_worker *worker, apr_size_t to)
+PROXY_DECLARE(void) ap_proxy_set_busy_count(proxy_worker *worker, apr_size_t to)
 {
 #if APR_SIZEOF_VOIDP == 4
     AP_DEBUG_ASSERT(sizeof(apr_size_t) == sizeof(apr_uint32_t));

Modified: httpd/httpd/trunk/modules/proxy/proxy_util.h
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/proxy_util.h?rev=1913930&r1=1913929&r2=1913930&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/proxy/proxy_util.h (original)
+++ httpd/httpd/trunk/modules/proxy/proxy_util.h Sat Nov 18 13:49:04 2023
@@ -46,7 +46,7 @@ void proxy_util_register_hooks(apr_pool_
  * @param worker Pointer to the worker structure.
  * @return      apr_size_t value atomically read for the worker.
  */
-PROXY_DECLARE(apr_size_t) getbusy_count(proxy_worker *worker);
+PROXY_DECLARE(apr_size_t) ap_proxy_get_busy_count(proxy_worker *worker);
 
 /*
  * Set the busy counter from the shared worker memory
@@ -55,7 +55,7 @@ PROXY_DECLARE(apr_size_t) getbusy_count(
  * @param to value to set the busy counter.
  * @return      void
  */
-PROXY_DECLARE(void) setbusy_count(proxy_worker *worker, apr_size_t to);
+PROXY_DECLARE(void) ap_proxy_set_busy_count(proxy_worker *worker, apr_size_t to);
 
 /*
  * decrement the busy counter from the shared worker memory
@@ -65,7 +65,7 @@ PROXY_DECLARE(void) setbusy_count(proxy_
  * @param worker_ Pointer to the worker structure.
  * @return      apr_status_t returns APR_SUCCESS.
  */
-PROXY_DECLARE(apr_status_t) decrement_busy_count(void *worker_);
+PROXY_DECLARE(apr_status_t) ap_proxy_decrement_busy_count(void *worker_);
 
 /*
  * increment the busy counter from the shared worker memory
@@ -73,7 +73,7 @@ PROXY_DECLARE(apr_status_t) decrement_bu
  * @param worker Pointer to the worker structure.
  * @return      void
  */
-PROXY_DECLARE(void) increment_busy_count(proxy_worker *worker);
+PROXY_DECLARE(void) ap_proxy_increment_busy_count(proxy_worker *worker);
 
 /** @} */