svn commit: r1695139 - in /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile: JavaClass.java LineNumber.java

[se...@apache.org]

Author: sebb
Date: Mon Aug 10 17:26:37 2015
New Revision: 1695139

URL: http://svn.apache.org/r1695139
Log:
TODOs

Modified:
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LineNumber.java

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java?rev=1695139&r1=1695138&r2=1695139&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java Mon Aug 10 17:26:37 2015
@@ -75,7 +75,7 @@ public class JavaClass extends AccessFla
     static boolean debug = false; // Debugging on/off
     final static char sep = File.separatorChar; // directory separator
     
-    private static BCELComparator _cmp = new BCELComparator() {
+    private static BCELComparator _cmp = new BCELComparator() { // TODO could be final (setter unused)
 
         public boolean equals( Object o1, Object o2 ) {
             JavaClass THIS = (JavaClass) o1;
@@ -886,7 +886,7 @@ public class JavaClass extends AccessFla
     /**
      * @param comparator Comparison strategy object
      */
-    public static void setComparator( BCELComparator comparator ) {
+    public static void setComparator( BCELComparator comparator ) { // TODO unused
         _cmp = comparator;
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LineNumber.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LineNumber.java?rev=1695139&r1=1695138&r2=1695139&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LineNumber.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LineNumber.java Mon Aug 10 17:26:37 2015
@@ -36,10 +36,10 @@ public final class LineNumber implements
     private static final long serialVersionUID = 169537400672820016L;
     
     /** Program Counter (PC) corresponds to line */
-    private short start_pc;
+    private short start_pc; // TODO could be final (setter unused)
     
     /** number in source file */
-    private short line_number;
+    private short line_number; // TODO could be final (setter unused)
 
     /**
      * Initialize from another object.
@@ -113,7 +113,7 @@ public final class LineNumber implements
     /**
      * @param line_number the source line number
      */
-    public final void setLineNumber( int line_number ) {
+    public final void setLineNumber( int line_number ) { // TODO unused
         this.line_number = (short) line_number;
     }
 
@@ -121,7 +121,7 @@ public final class LineNumber implements
     /**
      * @param start_pc the pc for this line number
      */
-    public final void setStartPC( int start_pc ) {
+    public final void setStartPC( int start_pc ) { // TODO unused
         this.start_pc = (short) start_pc;
     }