You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/04 07:11:50 UTC
[GitHub] [incubator-doris] morningman opened a new pull request, #9953: [feature-wip](multi-catalog)(step2) Introduce Internal Data Source
morningman opened a new pull request, #9953:
URL: https://github.com/apache/incubator-doris/pull/9953
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9953: [feature-wip](multi-catalog)(step2) Introduce Internal Data Source
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9953:
URL: https://github.com/apache/incubator-doris/pull/9953#issuecomment-1146988271
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei merged pull request #9953: [feature-wip](multi-catalog)(step2) Introduce Internal Data Source
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #9953:
URL: https://github.com/apache/incubator-doris/pull/9953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9953: [feature-wip](multi-catalog)(step2) Introduce Internal Data Source
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9953:
URL: https://github.com/apache/incubator-doris/pull/9953#issuecomment-1149325892
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morrySnow commented on pull request #9953: [feature-wip](multi-catalog)(step2) Introduce Internal Data Source
Posted by GitBox <gi...@apache.org>.
morrySnow commented on PR #9953:
URL: https://github.com/apache/incubator-doris/pull/9953#issuecomment-1147110648
> In order to avoid modifying too much code at one time, I still keep these methods in the `Catalog`, but these methods will directly call the methods in `InternalDataSource`. In a future commit, these methods will be removed from the `Catalog`.
Do we need to add 'Deprecated' annotation on all methods need to be removed in future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morrySnow commented on pull request #9953: [feature-wip](multi-catalog)(step2) Introduce Internal Data Source
Posted by GitBox <gi...@apache.org>.
morrySnow commented on PR #9953:
URL: https://github.com/apache/incubator-doris/pull/9953#issuecomment-1147111236
Fix check style error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #9953: [feature-wip](multi-catalog)(step2) Introduce Internal Data Source
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #9953:
URL: https://github.com/apache/incubator-doris/pull/9953#issuecomment-1148771196
> > In order to avoid modifying too much code at one time, I still keep these methods in the `Catalog`, but these methods will directly call the methods in `InternalDataSource`. In a future commit, these methods will be removed from the `Catalog`.
>
> Do we need to add 'Deprecated' annotation on all methods need to be removed in future?
I will remove them in next PR, very soon, so no need to add
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9953: [feature-wip](multi-catalog)(step2) Introduce Internal Data Source
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9953:
URL: https://github.com/apache/incubator-doris/pull/9953#issuecomment-1149961215
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #9953: [feature-wip](multi-catalog)(step2) Introduce Internal Data Source
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #9953:
URL: https://github.com/apache/incubator-doris/pull/9953#issuecomment-1148771962
> Fix check style error?
I fixed part of them, but the java doc check is too much, and most of them are for the origin old method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org