You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by "Soni, Pankaj" <Pa...@dell.com.INVALID> on 2023/05/05 11:34:20 UTC
RE: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2
I tested this image (apache/superset:pr-23388-dev) earlier, It was working fine with emails having screenshot.
And the fix was added in 2.1.0 but I am still facing the same issue (Error: Failed taking a screenshot Message: 'geckodriver' executable needs to be in PATH.)
Can anyone please have a look, Mails are very important feature for Superset.
Thanks,
Pankaj
Internal Use - Confidential
-----Original Message-----
From: Tai Dupree <td...@gmail.com>
Sent: Friday, March 17, 2023 11:37 PM
To: dev@superset.apache.org
Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2
[EXTERNAL EMAIL]
Yes, I was able to receive an email report. You need to use an image tagged with dev, you can try apache/superset:pr-23388-dev.
On Fri, Mar 17, 2023 at 2:47 AM Soni, Pankaj <Pa...@dell.com.invalid>
wrote:
> Hi,
> Are you also able to get screenshots in the mail?
> As per your suggestion I tried your fix from recently pushed image:
> "apache/superset:e3a7d2014df179088e14a5fc953dc66f69ba0f04-py39"
> This incorporates the fix for webdriver. I am able to get reports but
> still screenshot gives same error "Failed taking a screenshot Message:
> 'geckodriver' executable needs to be in PATH"
>
> Thanks,
> Pankaj
>
>
> Internal Use - Confidential
>
> -----Original Message-----
> From: Tai Dupree <td...@gmail.com>
> Sent: Friday, March 17, 2023 11:50 AM
> To: dev@superset.apache.org
> Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset
> 2.1.0rc2
>
>
> [EXTERNAL EMAIL]
>
> I was just able to receive an email report just fine, so I don't think
> the issue is with this release (aside from what's addressed in my PR).
> That connection timeout error is usually networking/config related.
> Are you sure you can reach the superset web server from the worker,
> and that smtp is configured correctly?
>
> On Thu, Mar 16, 2023 at 10:58 PM multazim deshmukh
> <mu...@gmail.com>
> wrote:
>
> > Hi Pankaj,
> >
> > Can you give more information to understand the root cause.
> > 1. Did you upgrade to 2.1.0rc2 from a previous version? If so, which
> > version?
> > 2. Did you try Tai’s fix ?
> > 3. Any details in the log?
> >
> > On Friday, March 17, 2023, Pankaj soni <pa...@gmail.com>
> wrote:
> >
> > > Sorry to say, but nothing works to fix alert and report.
> > > Not only screenshot but also simple reports are getting timeout error.
> > >
> > > Overall alert and report is completely broken and not working in
> > > any
> way.
> > >
> > > Thanks,
> > > Pankaj
> > >
> > > On Thu, 16 Mar, 2023, 06:31 Tai Dupree, <td...@gmail.com> wrote:
> > >
> > >> FWIW, here's a fix PR
> > >> https://urldefense.com/v3/__https://github.com/apache/superset/pu
> > >> ll
> > >> /23388__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyMq_
> > >> Tm Vaf5Y0ZM0tZx08OF9YD4rmT63sjVdu1A$ [github[.]com]
> > >>
> > >> On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree
> > >> <td...@gmail.com>
> > wrote:
> > >>
> > >> > Hi,
> > >> >
> > >> > So for the alerts/reports issue this config needs to be overridden:
> > >> >
> > https://urldefense.com/v3/__https://github.com/apache/superset/blob/
> > da
> > 3791ad3daa209631a588394600d1__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p
> > 9x z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63XwZHw3E$
> > [github[.]com]
> > >> a8b635e814/superset/config.py#L1307
> > >> >
> > >> > I suppose these defaults no longer work with the new
> > >> > Firefox/webdriver version. They also seem chrome specific too,
> > >> > so probably don't make
> > >> sense
> > >> > as a default. I don't think this should block the release
> > >> > though since
> > >> the
> > >> > firefox/webdriver is only part of the dev image and not part of
> > >> > any official release. Maybe we can just add a note in upgrading
> > >> > for
> this.
> > >> >
> > >> >
> > >> >
> > >> > On Wed, Mar 15, 2023 at 9:00 AM Sam Firke
> > >> > <sa...@gmail.com>
> > >> wrote:
> > >> >
> > >> >> I'm also seeing errors with Alerts and Reports in rc2. Looking
> > >> >> at the
> > >> logs
> > >> >> it appears to be this issue:
> > >> >> https://urldefense.com/v3/__https://github.com/apache/superset
> > >> >> /i
> > >> >> ssues/22326__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9Rj
> > >> >> gQ smyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63giKK5aw$ [github[.]com]
> > >> >>
> > >> >> On Wed, Mar 15, 2023, 5:27 AM Pankaj soni
> > >> >> <pankajsoni.mgml@gmail.com
> > >
> > >> >> wrote:
> > >> >>
> > >> >> > Not able to send alerts, screenshot as alerts and reports as
> well.
> > >> >> >
> > >> >> > On Wed, 15 Mar, 2023, 14:42 Pankaj soni, <
> > pankajsoni.mgml@gmail.com>
> > >> >> > wrote:
> > >> >> >
> > >> >> > > -1: Alert & Report section is completely broken as no
> > >> >> > > mails,
> > >> >> screenshots
> > >> >> > > are triggered due to error mentioned in image
> > >> >> > >
> > >> >> > > On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson,
> > >> >> > > <el...@preset.io.invalid> wrote:
> > >> >> > >
> > >> >> > >> Hello Superset Community,
> > >> >> > >>
> > >> >> > >> This is a call for the vote to release Apache Superset
> > >> >> > >> version
> > >> 2.1.0.
> > >> >> > >>
> > >> >> > >> The release candidate:
> > >> >> > >> https://urldefense.com/v3/__https://dist.apache.org/repos
> > >> >> > >> /d
> > >> >> > >> ist/dev/superset/2.1.0rc2/__;!!LpKI!j4vMZKp0bgaggE6smVZkH
> > >> >> > >> UA
> > >> >> > >> uixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63Phlq
> > >> >> > >> Ej
> > >> >> > >> o$ [dist[.]apache[.]org]
> > >> >> > >>
> > >> >> > >> Git tag for the release:
> > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/sup
> > >> >> > >> er
> > >> >> > >> set/tree/2.1.0rc2__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p
> > >> >> > >> 9x z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63j9QUUPs$
> > >> >> > >> [github[.]com]
> > >> >> > >>
> > >> >> > >> The Change Log for the release:
> > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/sup
> > >> >> > >> er
> > >> >> > >> set/blob/2.1.0rc2/CHANGELOG.md__;!!LpKI!j4vMZKp0bgaggE6sm
> > >> >> > >> VZ
> > >> >> > >> kHUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63
> > >> >> > >> M-
> > >> >> > >> MLnFs$ [github[.]com]
> > >> >> > >>
> > >> >> > >> The Updating instructions for the release:
> > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/sup
> > >> >> > >> er
> > >> >> > >> set/blob/2.1.0rc2/UPDATING.md__;!!LpKI!j4vMZKp0bgaggE6smV
> > >> >> > >> Zk
> > >> >> > >> HUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63_
> > >> >> > >> BM
> > >> >> > >> pXQI$ [github[.]com]
> > >> >> > >>
> > >> >> > >> Public keys are available at:
> > >> >> > >> https://urldefense.com/v3/__https://www.apache.org/dist/s
> > >> >> > >> up
> > >> >> > >> erset/KEYS__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz
> > >> >> > >> _9 RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63xX6J9hQ$
> > >> >> > >> [apache[.]org]
> > >> >> > >>
> > >> >> > >> The vote will be open for at least 72 hours or until the
> > necessary
> > >> >> > number
> > >> >> > >> of votes are reached.
> > >> >> > >>
> > >> >> > >> Please vote accordingly:
> > >> >> > >>
> > >> >> > >> [ ] +1 approve
> > >> >> > >> [ ] +0 no opinion
> > >> >> > >> [ ] -1 disapprove with the reason
> > >> >> > >>
> > >> >> > >> Thanks,
> > >> >> > >> The Apache Superset Team
> > >> >> > >>
> > >> >> > >>
> > >> >> >
> > >> >>
> > >> >
> > >> >
> > >> > --
> > >> > -Tai Dupree
> > >> >
> > >>
> > >>
> > >> --
> > >> -Tai Dupree
> > >>
> > >
> >
> > --
> > Regards
> > Multazim Deshmukh
> > https://urldefense.com/v3/__https://www.linkedin.com/in/multazim-des
> > hm
> > ukh-a5b68429/__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsm
> > yM q_TmVaf5Y0ZM0tZx08OF9YD4rmT63CPRFHeU$ [linkedin[.]com]
> >
>
>
> --
> -Tai Dupree
>
--
-Tai Dupree
Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2
Posted by Sam Firke <sa...@firke.com>.
Yes, both work with 2.1.0-dev. The difference between those images is that the -dev image is bundled with additional software, including Firefox. You can see that from looking at the Dockerfile: https://github.com/apache/superset/blob/master/Dockerfile#L105 The browser is needed to take screenshots.
My approach has been to modify my docker-compose file so that I'm using 2.1.0 for the main application container and 2.1.0-dev for the worker containers. I posted about this on Github Discussions <https://github.com/apache/superset/discussions/22245>.
I expect you and I are not the only ones to be confused by this. This comes up in Slack regularly. I updated the Alerts & Reports docs <https://superset.apache.org/docs/installation/alerts-reports/>to explain why one has to run a "dev" image in production in this case - see the paragraphs beginning with the text "Note: All the components required" ...
I think there's an opportunity to make this easier on new users by bundling the software needed for Alerts & Reports into the main image (my preference) or into a separate new image that isn't called "dev" so that reporting works out of the box. If there's support for that, I'd be happy to help however I can.
Sam
P.S. If you made it this far and are interested in clarifying labels of docker images, check out this thread re: issues with the current state of pointing new users to the latest tag <https://github.com/apache/superset/discussions/22244>.
On Sun, May 7, 2023, at 9:52 AM, Soni, Pankaj wrote:
> Thanks,
> Emails for text report/alert works for me, but not with screenshot. Emails with screenshot is working for you?
>
> I am using 2.1.0 and it doesn't work.
> How about 2.1.0-dev I believe 2.1.0 and 2.1.0-dev are same. Ideally
> shouldn’t the fix present in 2.1.0 itself.
>
> Get Outlook for Android<https://aka.ms/AAb9ysg>
> ________________________________
> From: Sam Firke <sa...@firke.com>
> Sent: Friday, May 5, 2023 9:41:05 PM
> To: dev@superset.apache.org <de...@superset.apache.org>
> Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2
>
>
> [EXTERNAL EMAIL]
>
> This is fixed in 2.1.0, I'm running the 2.1.0-dev image as my docker-compose worker container and emails work correctly.
>
> You might consider posting your situation in Slack to see if someone can help troubleshoot the config?
>
> On Fri, May 5, 2023, at 7:34 AM, Soni, Pankaj wrote:
> > I tested this image (apache/superset:pr-23388-dev) earlier, It was working fine with emails having screenshot.
> > And the fix was added in 2.1.0 but I am still facing the same issue (Error: Failed taking a screenshot Message: 'geckodriver' executable needs to be in PATH.)
> >
> > Can anyone please have a look, Mails are very important feature for Superset.
> >
> >
> > Thanks,
> > Pankaj
> >
> > Internal Use - Confidential
> >
> > -----Original Message-----
> > From: Tai Dupree <td...@gmail.com>
> > Sent: Friday, March 17, 2023 11:37 PM
> > To: dev@superset.apache.org
> > Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2
> >
> >
> > [EXTERNAL EMAIL]
> >
> > Yes, I was able to receive an email report. You need to use an image tagged with dev, you can try apache/superset:pr-23388-dev.
> >
> > On Fri, Mar 17, 2023 at 2:47 AM Soni, Pankaj <Pa...@dell.com.invalid>
> > wrote:
> >
> > > Hi,
> > > Are you also able to get screenshots in the mail?
> > > As per your suggestion I tried your fix from recently pushed image:
> > > "apache/superset:e3a7d2014df179088e14a5fc953dc66f69ba0f04-py39"
> > > This incorporates the fix for webdriver. I am able to get reports but
> > > still screenshot gives same error "Failed taking a screenshot Message:
> > > 'geckodriver' executable needs to be in PATH"
> > >
> > > Thanks,
> > > Pankaj
> > >
> > >
> > > Internal Use - Confidential
> > >
> > > -----Original Message-----
> > > From: Tai Dupree <td...@gmail.com>
> > > Sent: Friday, March 17, 2023 11:50 AM
> > > To: dev@superset.apache.org
> > > Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset
> > > 2.1.0rc2
> > >
> > >
> > > [EXTERNAL EMAIL]
> > >
> > > I was just able to receive an email report just fine, so I don't think
> > > the issue is with this release (aside from what's addressed in my PR).
> > > That connection timeout error is usually networking/config related.
> > > Are you sure you can reach the superset web server from the worker,
> > > and that smtp is configured correctly?
> > >
> > > On Thu, Mar 16, 2023 at 10:58 PM multazim deshmukh
> > > <mu...@gmail.com>
> > > wrote:
> > >
> > > > Hi Pankaj,
> > > >
> > > > Can you give more information to understand the root cause.
> > > > 1. Did you upgrade to 2.1.0rc2 from a previous version? If so, which
> > > > version?
> > > > 2. Did you try Tai’s fix ?
> > > > 3. Any details in the log?
> > > >
> > > > On Friday, March 17, 2023, Pankaj soni <pa...@gmail.com>
> > > wrote:
> > > >
> > > > > Sorry to say, but nothing works to fix alert and report.
> > > > > Not only screenshot but also simple reports are getting timeout error.
> > > > >
> > > > > Overall alert and report is completely broken and not working in
> > > > > any
> > > way.
> > > > >
> > > > > Thanks,
> > > > > Pankaj
> > > > >
> > > > > On Thu, 16 Mar, 2023, 06:31 Tai Dupree, <td...@gmail.com> wrote:
> > > > >
> > > > >> FWIW, here's a fix PR
> > > > >> https://urldefense.com/v3/__https://github.com/apache/superset/pu
> > > > >> ll
> > > > >> /23388__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyMq_
> > > > >> Tm Vaf5Y0ZM0tZx08OF9YD4rmT63sjVdu1A$ [github[.]com]
> > > > >>
> > > > >> On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree
> > > > >> <td...@gmail.com>
> > > > wrote:
> > > > >>
> > > > >> > Hi,
> > > > >> >
> > > > >> > So for the alerts/reports issue this config needs to be overridden:
> > > > >> >
> > > > https://urldefense.com/v3/__https://github.com/apache/superset/blob/
> > > > da
> > > > 3791ad3daa209631a588394600d1__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p
> > > > 9x z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63XwZHw3E$
> > > > [github[.]com]
> > > > >> a8b635e814/superset/config.py#L1307
> > > > >> >
> > > > >> > I suppose these defaults no longer work with the new
> > > > >> > Firefox/webdriver version. They also seem chrome specific too,
> > > > >> > so probably don't make
> > > > >> sense
> > > > >> > as a default. I don't think this should block the release
> > > > >> > though since
> > > > >> the
> > > > >> > firefox/webdriver is only part of the dev image and not part of
> > > > >> > any official release. Maybe we can just add a note in upgrading
> > > > >> > for
> > > this.
> > > > >> >
> > > > >> >
> > > > >> >
> > > > >> > On Wed, Mar 15, 2023 at 9:00 AM Sam Firke
> > > > >> > <sa...@gmail.com>
> > > > >> wrote:
> > > > >> >
> > > > >> >> I'm also seeing errors with Alerts and Reports in rc2. Looking
> > > > >> >> at the
> > > > >> logs
> > > > >> >> it appears to be this issue:
> > > > >> >> https://urldefense.com/v3/__https://github.com/apache/superset
> > > > >> >> /i
> > > > >> >> ssues/22326__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9Rj
> > > > >> >> gQ smyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63giKK5aw$ [github[.]com]
> > > > >> >>
> > > > >> >> On Wed, Mar 15, 2023, 5:27 AM Pankaj soni
> > > > >> >> <pankajsoni.mgml@gmail.com
> > > > >
> > > > >> >> wrote:
> > > > >> >>
> > > > >> >> > Not able to send alerts, screenshot as alerts and reports as
> > > well.
> > > > >> >> >
> > > > >> >> > On Wed, 15 Mar, 2023, 14:42 Pankaj soni, <
> > > > pankajsoni.mgml@gmail.com>
> > > > >> >> > wrote:
> > > > >> >> >
> > > > >> >> > > -1: Alert & Report section is completely broken as no
> > > > >> >> > > mails,
> > > > >> >> screenshots
> > > > >> >> > > are triggered due to error mentioned in image
> > > > >> >> > >
> > > > >> >> > > On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson,
> > > > >> >> > > <el...@preset.io.invalid> wrote:
> > > > >> >> > >
> > > > >> >> > >> Hello Superset Community,
> > > > >> >> > >>
> > > > >> >> > >> This is a call for the vote to release Apache Superset
> > > > >> >> > >> version
> > > > >> 2.1.0.
> > > > >> >> > >>
> > > > >> >> > >> The release candidate:
> > > > >> >> > >> https://urldefense.com/v3/__https://dist.apache.org/repos
> > > > >> >> > >> /d
> > > > >> >> > >> ist/dev/superset/2.1.0rc2/__;!!LpKI!j4vMZKp0bgaggE6smVZkH
> > > > >> >> > >> UA
> > > > >> >> > >> uixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63Phlq
> > > > >> >> > >> Ej
> > > > >> >> > >> o$ [dist[.]apache[.]org]
> > > > >> >> > >>
> > > > >> >> > >> Git tag for the release:
> > > > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/sup
> > > > >> >> > >> er
> > > > >> >> > >> set/tree/2.1.0rc2__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p
> > > > >> >> > >> 9x z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63j9QUUPs$
> > > > >> >> > >> [github[.]com]
> > > > >> >> > >>
> > > > >> >> > >> The Change Log for the release:
> > > > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/sup
> > > > >> >> > >> er
> > > > >> >> > >> set/blob/2.1.0rc2/CHANGELOG.md__;!!LpKI!j4vMZKp0bgaggE6sm
> > > > >> >> > >> VZ
> > > > >> >> > >> kHUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63
> > > > >> >> > >> M-
> > > > >> >> > >> MLnFs$ [github[.]com]
> > > > >> >> > >>
> > > > >> >> > >> The Updating instructions for the release:
> > > > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/sup
> > > > >> >> > >> er
> > > > >> >> > >> set/blob/2.1.0rc2/UPDATING.md__;!!LpKI!j4vMZKp0bgaggE6smV
> > > > >> >> > >> Zk
> > > > >> >> > >> HUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63_
> > > > >> >> > >> BM
> > > > >> >> > >> pXQI$ [github[.]com]
> > > > >> >> > >>
> > > > >> >> > >> Public keys are available at:
> > > > >> >> > >> https://urldefense.com/v3/__https://www.apache.org/dist/s
> > > > >> >> > >> up
> > > > >> >> > >> erset/KEYS__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz
> > > > >> >> > >> _9 RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63xX6J9hQ$
> > > > >> >> > >> [apache[.]org]
> > > > >> >> > >>
> > > > >> >> > >> The vote will be open for at least 72 hours or until the
> > > > necessary
> > > > >> >> > number
> > > > >> >> > >> of votes are reached.
> > > > >> >> > >>
> > > > >> >> > >> Please vote accordingly:
> > > > >> >> > >>
> > > > >> >> > >> [ ] +1 approve
> > > > >> >> > >> [ ] +0 no opinion
> > > > >> >> > >> [ ] -1 disapprove with the reason
> > > > >> >> > >>
> > > > >> >> > >> Thanks,
> > > > >> >> > >> The Apache Superset Team
> > > > >> >> > >>
> > > > >> >> > >>
> > > > >> >> >
> > > > >> >>
> > > > >> >
> > > > >> >
> > > > >> > --
> > > > >> > -Tai Dupree
> > > > >> >
> > > > >>
> > > > >>
> > > > >> --
> > > > >> -Tai Dupree
> > > > >>
> > > > >
> > > >
> > > > --
> > > > Regards
> > > > Multazim Deshmukh
> > > > https://urldefense.com/v3/__https://www.linkedin.com/in/multazim-des
> > > > hm
> > > > ukh-a5b68429/__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsm
> > > > yM q_TmVaf5Y0ZM0tZx08OF9YD4rmT63CPRFHeU$ [linkedin[.]com]
> > > >
> > >
> > >
> > > --
> > > -Tai Dupree
> > >
> >
> >
> > --
> > -Tai Dupree
> >
>
Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2
Posted by "Soni, Pankaj" <Pa...@dell.com.INVALID>.
Thanks,
Emails for text report/alert works for me, but not with screenshot. Emails with screenshot is working for you?
I am using 2.1.0 and it doesn't work.
How about 2.1.0-dev I believe 2.1.0 and 2.1.0-dev are same. Ideally
shouldn’t the fix present in 2.1.0 itself.
Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Sam Firke <sa...@firke.com>
Sent: Friday, May 5, 2023 9:41:05 PM
To: dev@superset.apache.org <de...@superset.apache.org>
Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2
[EXTERNAL EMAIL]
This is fixed in 2.1.0, I'm running the 2.1.0-dev image as my docker-compose worker container and emails work correctly.
You might consider posting your situation in Slack to see if someone can help troubleshoot the config?
On Fri, May 5, 2023, at 7:34 AM, Soni, Pankaj wrote:
> I tested this image (apache/superset:pr-23388-dev) earlier, It was working fine with emails having screenshot.
> And the fix was added in 2.1.0 but I am still facing the same issue (Error: Failed taking a screenshot Message: 'geckodriver' executable needs to be in PATH.)
>
> Can anyone please have a look, Mails are very important feature for Superset.
>
>
> Thanks,
> Pankaj
>
> Internal Use - Confidential
>
> -----Original Message-----
> From: Tai Dupree <td...@gmail.com>
> Sent: Friday, March 17, 2023 11:37 PM
> To: dev@superset.apache.org
> Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2
>
>
> [EXTERNAL EMAIL]
>
> Yes, I was able to receive an email report. You need to use an image tagged with dev, you can try apache/superset:pr-23388-dev.
>
> On Fri, Mar 17, 2023 at 2:47 AM Soni, Pankaj <Pa...@dell.com.invalid>
> wrote:
>
> > Hi,
> > Are you also able to get screenshots in the mail?
> > As per your suggestion I tried your fix from recently pushed image:
> > "apache/superset:e3a7d2014df179088e14a5fc953dc66f69ba0f04-py39"
> > This incorporates the fix for webdriver. I am able to get reports but
> > still screenshot gives same error "Failed taking a screenshot Message:
> > 'geckodriver' executable needs to be in PATH"
> >
> > Thanks,
> > Pankaj
> >
> >
> > Internal Use - Confidential
> >
> > -----Original Message-----
> > From: Tai Dupree <td...@gmail.com>
> > Sent: Friday, March 17, 2023 11:50 AM
> > To: dev@superset.apache.org
> > Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset
> > 2.1.0rc2
> >
> >
> > [EXTERNAL EMAIL]
> >
> > I was just able to receive an email report just fine, so I don't think
> > the issue is with this release (aside from what's addressed in my PR).
> > That connection timeout error is usually networking/config related.
> > Are you sure you can reach the superset web server from the worker,
> > and that smtp is configured correctly?
> >
> > On Thu, Mar 16, 2023 at 10:58 PM multazim deshmukh
> > <mu...@gmail.com>
> > wrote:
> >
> > > Hi Pankaj,
> > >
> > > Can you give more information to understand the root cause.
> > > 1. Did you upgrade to 2.1.0rc2 from a previous version? If so, which
> > > version?
> > > 2. Did you try Tai’s fix ?
> > > 3. Any details in the log?
> > >
> > > On Friday, March 17, 2023, Pankaj soni <pa...@gmail.com>
> > wrote:
> > >
> > > > Sorry to say, but nothing works to fix alert and report.
> > > > Not only screenshot but also simple reports are getting timeout error.
> > > >
> > > > Overall alert and report is completely broken and not working in
> > > > any
> > way.
> > > >
> > > > Thanks,
> > > > Pankaj
> > > >
> > > > On Thu, 16 Mar, 2023, 06:31 Tai Dupree, <td...@gmail.com> wrote:
> > > >
> > > >> FWIW, here's a fix PR
> > > >> https://urldefense.com/v3/__https://github.com/apache/superset/pu
> > > >> ll
> > > >> /23388__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyMq_
> > > >> Tm Vaf5Y0ZM0tZx08OF9YD4rmT63sjVdu1A$ [github[.]com]
> > > >>
> > > >> On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree
> > > >> <td...@gmail.com>
> > > wrote:
> > > >>
> > > >> > Hi,
> > > >> >
> > > >> > So for the alerts/reports issue this config needs to be overridden:
> > > >> >
> > > https://urldefense.com/v3/__https://github.com/apache/superset/blob/
> > > da
> > > 3791ad3daa209631a588394600d1__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p
> > > 9x z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63XwZHw3E$
> > > [github[.]com]
> > > >> a8b635e814/superset/config.py#L1307
> > > >> >
> > > >> > I suppose these defaults no longer work with the new
> > > >> > Firefox/webdriver version. They also seem chrome specific too,
> > > >> > so probably don't make
> > > >> sense
> > > >> > as a default. I don't think this should block the release
> > > >> > though since
> > > >> the
> > > >> > firefox/webdriver is only part of the dev image and not part of
> > > >> > any official release. Maybe we can just add a note in upgrading
> > > >> > for
> > this.
> > > >> >
> > > >> >
> > > >> >
> > > >> > On Wed, Mar 15, 2023 at 9:00 AM Sam Firke
> > > >> > <sa...@gmail.com>
> > > >> wrote:
> > > >> >
> > > >> >> I'm also seeing errors with Alerts and Reports in rc2. Looking
> > > >> >> at the
> > > >> logs
> > > >> >> it appears to be this issue:
> > > >> >> https://urldefense.com/v3/__https://github.com/apache/superset
> > > >> >> /i
> > > >> >> ssues/22326__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9Rj
> > > >> >> gQ smyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63giKK5aw$ [github[.]com]
> > > >> >>
> > > >> >> On Wed, Mar 15, 2023, 5:27 AM Pankaj soni
> > > >> >> <pankajsoni.mgml@gmail.com
> > > >
> > > >> >> wrote:
> > > >> >>
> > > >> >> > Not able to send alerts, screenshot as alerts and reports as
> > well.
> > > >> >> >
> > > >> >> > On Wed, 15 Mar, 2023, 14:42 Pankaj soni, <
> > > pankajsoni.mgml@gmail.com>
> > > >> >> > wrote:
> > > >> >> >
> > > >> >> > > -1: Alert & Report section is completely broken as no
> > > >> >> > > mails,
> > > >> >> screenshots
> > > >> >> > > are triggered due to error mentioned in image
> > > >> >> > >
> > > >> >> > > On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson,
> > > >> >> > > <el...@preset.io.invalid> wrote:
> > > >> >> > >
> > > >> >> > >> Hello Superset Community,
> > > >> >> > >>
> > > >> >> > >> This is a call for the vote to release Apache Superset
> > > >> >> > >> version
> > > >> 2.1.0.
> > > >> >> > >>
> > > >> >> > >> The release candidate:
> > > >> >> > >> https://urldefense.com/v3/__https://dist.apache.org/repos
> > > >> >> > >> /d
> > > >> >> > >> ist/dev/superset/2.1.0rc2/__;!!LpKI!j4vMZKp0bgaggE6smVZkH
> > > >> >> > >> UA
> > > >> >> > >> uixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63Phlq
> > > >> >> > >> Ej
> > > >> >> > >> o$ [dist[.]apache[.]org]
> > > >> >> > >>
> > > >> >> > >> Git tag for the release:
> > > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/sup
> > > >> >> > >> er
> > > >> >> > >> set/tree/2.1.0rc2__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p
> > > >> >> > >> 9x z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63j9QUUPs$
> > > >> >> > >> [github[.]com]
> > > >> >> > >>
> > > >> >> > >> The Change Log for the release:
> > > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/sup
> > > >> >> > >> er
> > > >> >> > >> set/blob/2.1.0rc2/CHANGELOG.md__;!!LpKI!j4vMZKp0bgaggE6sm
> > > >> >> > >> VZ
> > > >> >> > >> kHUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63
> > > >> >> > >> M-
> > > >> >> > >> MLnFs$ [github[.]com]
> > > >> >> > >>
> > > >> >> > >> The Updating instructions for the release:
> > > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/sup
> > > >> >> > >> er
> > > >> >> > >> set/blob/2.1.0rc2/UPDATING.md__;!!LpKI!j4vMZKp0bgaggE6smV
> > > >> >> > >> Zk
> > > >> >> > >> HUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63_
> > > >> >> > >> BM
> > > >> >> > >> pXQI$ [github[.]com]
> > > >> >> > >>
> > > >> >> > >> Public keys are available at:
> > > >> >> > >> https://urldefense.com/v3/__https://www.apache.org/dist/s
> > > >> >> > >> up
> > > >> >> > >> erset/KEYS__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz
> > > >> >> > >> _9 RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63xX6J9hQ$
> > > >> >> > >> [apache[.]org]
> > > >> >> > >>
> > > >> >> > >> The vote will be open for at least 72 hours or until the
> > > necessary
> > > >> >> > number
> > > >> >> > >> of votes are reached.
> > > >> >> > >>
> > > >> >> > >> Please vote accordingly:
> > > >> >> > >>
> > > >> >> > >> [ ] +1 approve
> > > >> >> > >> [ ] +0 no opinion
> > > >> >> > >> [ ] -1 disapprove with the reason
> > > >> >> > >>
> > > >> >> > >> Thanks,
> > > >> >> > >> The Apache Superset Team
> > > >> >> > >>
> > > >> >> > >>
> > > >> >> >
> > > >> >>
> > > >> >
> > > >> >
> > > >> > --
> > > >> > -Tai Dupree
> > > >> >
> > > >>
> > > >>
> > > >> --
> > > >> -Tai Dupree
> > > >>
> > > >
> > >
> > > --
> > > Regards
> > > Multazim Deshmukh
> > > https://urldefense.com/v3/__https://www.linkedin.com/in/multazim-des
> > > hm
> > > ukh-a5b68429/__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsm
> > > yM q_TmVaf5Y0ZM0tZx08OF9YD4rmT63CPRFHeU$ [linkedin[.]com]
> > >
> >
> >
> > --
> > -Tai Dupree
> >
>
>
> --
> -Tai Dupree
>
Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2
Posted by Sam Firke <sa...@firke.com>.
This is fixed in 2.1.0, I'm running the 2.1.0-dev image as my docker-compose worker container and emails work correctly.
You might consider posting your situation in Slack to see if someone can help troubleshoot the config?
On Fri, May 5, 2023, at 7:34 AM, Soni, Pankaj wrote:
> I tested this image (apache/superset:pr-23388-dev) earlier, It was working fine with emails having screenshot.
> And the fix was added in 2.1.0 but I am still facing the same issue (Error: Failed taking a screenshot Message: 'geckodriver' executable needs to be in PATH.)
>
> Can anyone please have a look, Mails are very important feature for Superset.
>
>
> Thanks,
> Pankaj
>
> Internal Use - Confidential
>
> -----Original Message-----
> From: Tai Dupree <td...@gmail.com>
> Sent: Friday, March 17, 2023 11:37 PM
> To: dev@superset.apache.org
> Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2
>
>
> [EXTERNAL EMAIL]
>
> Yes, I was able to receive an email report. You need to use an image tagged with dev, you can try apache/superset:pr-23388-dev.
>
> On Fri, Mar 17, 2023 at 2:47 AM Soni, Pankaj <Pa...@dell.com.invalid>
> wrote:
>
> > Hi,
> > Are you also able to get screenshots in the mail?
> > As per your suggestion I tried your fix from recently pushed image:
> > "apache/superset:e3a7d2014df179088e14a5fc953dc66f69ba0f04-py39"
> > This incorporates the fix for webdriver. I am able to get reports but
> > still screenshot gives same error "Failed taking a screenshot Message:
> > 'geckodriver' executable needs to be in PATH"
> >
> > Thanks,
> > Pankaj
> >
> >
> > Internal Use - Confidential
> >
> > -----Original Message-----
> > From: Tai Dupree <td...@gmail.com>
> > Sent: Friday, March 17, 2023 11:50 AM
> > To: dev@superset.apache.org
> > Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset
> > 2.1.0rc2
> >
> >
> > [EXTERNAL EMAIL]
> >
> > I was just able to receive an email report just fine, so I don't think
> > the issue is with this release (aside from what's addressed in my PR).
> > That connection timeout error is usually networking/config related.
> > Are you sure you can reach the superset web server from the worker,
> > and that smtp is configured correctly?
> >
> > On Thu, Mar 16, 2023 at 10:58 PM multazim deshmukh
> > <mu...@gmail.com>
> > wrote:
> >
> > > Hi Pankaj,
> > >
> > > Can you give more information to understand the root cause.
> > > 1. Did you upgrade to 2.1.0rc2 from a previous version? If so, which
> > > version?
> > > 2. Did you try Tai’s fix ?
> > > 3. Any details in the log?
> > >
> > > On Friday, March 17, 2023, Pankaj soni <pa...@gmail.com>
> > wrote:
> > >
> > > > Sorry to say, but nothing works to fix alert and report.
> > > > Not only screenshot but also simple reports are getting timeout error.
> > > >
> > > > Overall alert and report is completely broken and not working in
> > > > any
> > way.
> > > >
> > > > Thanks,
> > > > Pankaj
> > > >
> > > > On Thu, 16 Mar, 2023, 06:31 Tai Dupree, <td...@gmail.com> wrote:
> > > >
> > > >> FWIW, here's a fix PR
> > > >> https://urldefense.com/v3/__https://github.com/apache/superset/pu
> > > >> ll
> > > >> /23388__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyMq_
> > > >> Tm Vaf5Y0ZM0tZx08OF9YD4rmT63sjVdu1A$ [github[.]com]
> > > >>
> > > >> On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree
> > > >> <td...@gmail.com>
> > > wrote:
> > > >>
> > > >> > Hi,
> > > >> >
> > > >> > So for the alerts/reports issue this config needs to be overridden:
> > > >> >
> > > https://urldefense.com/v3/__https://github.com/apache/superset/blob/
> > > da
> > > 3791ad3daa209631a588394600d1__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p
> > > 9x z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63XwZHw3E$
> > > [github[.]com]
> > > >> a8b635e814/superset/config.py#L1307
> > > >> >
> > > >> > I suppose these defaults no longer work with the new
> > > >> > Firefox/webdriver version. They also seem chrome specific too,
> > > >> > so probably don't make
> > > >> sense
> > > >> > as a default. I don't think this should block the release
> > > >> > though since
> > > >> the
> > > >> > firefox/webdriver is only part of the dev image and not part of
> > > >> > any official release. Maybe we can just add a note in upgrading
> > > >> > for
> > this.
> > > >> >
> > > >> >
> > > >> >
> > > >> > On Wed, Mar 15, 2023 at 9:00 AM Sam Firke
> > > >> > <sa...@gmail.com>
> > > >> wrote:
> > > >> >
> > > >> >> I'm also seeing errors with Alerts and Reports in rc2. Looking
> > > >> >> at the
> > > >> logs
> > > >> >> it appears to be this issue:
> > > >> >> https://urldefense.com/v3/__https://github.com/apache/superset
> > > >> >> /i
> > > >> >> ssues/22326__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9Rj
> > > >> >> gQ smyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63giKK5aw$ [github[.]com]
> > > >> >>
> > > >> >> On Wed, Mar 15, 2023, 5:27 AM Pankaj soni
> > > >> >> <pankajsoni.mgml@gmail.com
> > > >
> > > >> >> wrote:
> > > >> >>
> > > >> >> > Not able to send alerts, screenshot as alerts and reports as
> > well.
> > > >> >> >
> > > >> >> > On Wed, 15 Mar, 2023, 14:42 Pankaj soni, <
> > > pankajsoni.mgml@gmail.com>
> > > >> >> > wrote:
> > > >> >> >
> > > >> >> > > -1: Alert & Report section is completely broken as no
> > > >> >> > > mails,
> > > >> >> screenshots
> > > >> >> > > are triggered due to error mentioned in image
> > > >> >> > >
> > > >> >> > > On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson,
> > > >> >> > > <el...@preset.io.invalid> wrote:
> > > >> >> > >
> > > >> >> > >> Hello Superset Community,
> > > >> >> > >>
> > > >> >> > >> This is a call for the vote to release Apache Superset
> > > >> >> > >> version
> > > >> 2.1.0.
> > > >> >> > >>
> > > >> >> > >> The release candidate:
> > > >> >> > >> https://urldefense.com/v3/__https://dist.apache.org/repos
> > > >> >> > >> /d
> > > >> >> > >> ist/dev/superset/2.1.0rc2/__;!!LpKI!j4vMZKp0bgaggE6smVZkH
> > > >> >> > >> UA
> > > >> >> > >> uixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63Phlq
> > > >> >> > >> Ej
> > > >> >> > >> o$ [dist[.]apache[.]org]
> > > >> >> > >>
> > > >> >> > >> Git tag for the release:
> > > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/sup
> > > >> >> > >> er
> > > >> >> > >> set/tree/2.1.0rc2__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p
> > > >> >> > >> 9x z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63j9QUUPs$
> > > >> >> > >> [github[.]com]
> > > >> >> > >>
> > > >> >> > >> The Change Log for the release:
> > > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/sup
> > > >> >> > >> er
> > > >> >> > >> set/blob/2.1.0rc2/CHANGELOG.md__;!!LpKI!j4vMZKp0bgaggE6sm
> > > >> >> > >> VZ
> > > >> >> > >> kHUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63
> > > >> >> > >> M-
> > > >> >> > >> MLnFs$ [github[.]com]
> > > >> >> > >>
> > > >> >> > >> The Updating instructions for the release:
> > > >> >> > >> https://urldefense.com/v3/__https://github.com/apache/sup
> > > >> >> > >> er
> > > >> >> > >> set/blob/2.1.0rc2/UPDATING.md__;!!LpKI!j4vMZKp0bgaggE6smV
> > > >> >> > >> Zk
> > > >> >> > >> HUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63_
> > > >> >> > >> BM
> > > >> >> > >> pXQI$ [github[.]com]
> > > >> >> > >>
> > > >> >> > >> Public keys are available at:
> > > >> >> > >> https://urldefense.com/v3/__https://www.apache.org/dist/s
> > > >> >> > >> up
> > > >> >> > >> erset/KEYS__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz
> > > >> >> > >> _9 RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63xX6J9hQ$
> > > >> >> > >> [apache[.]org]
> > > >> >> > >>
> > > >> >> > >> The vote will be open for at least 72 hours or until the
> > > necessary
> > > >> >> > number
> > > >> >> > >> of votes are reached.
> > > >> >> > >>
> > > >> >> > >> Please vote accordingly:
> > > >> >> > >>
> > > >> >> > >> [ ] +1 approve
> > > >> >> > >> [ ] +0 no opinion
> > > >> >> > >> [ ] -1 disapprove with the reason
> > > >> >> > >>
> > > >> >> > >> Thanks,
> > > >> >> > >> The Apache Superset Team
> > > >> >> > >>
> > > >> >> > >>
> > > >> >> >
> > > >> >>
> > > >> >
> > > >> >
> > > >> > --
> > > >> > -Tai Dupree
> > > >> >
> > > >>
> > > >>
> > > >> --
> > > >> -Tai Dupree
> > > >>
> > > >
> > >
> > > --
> > > Regards
> > > Multazim Deshmukh
> > > https://urldefense.com/v3/__https://www.linkedin.com/in/multazim-des
> > > hm
> > > ukh-a5b68429/__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsm
> > > yM q_TmVaf5Y0ZM0tZx08OF9YD4rmT63CPRFHeU$ [linkedin[.]com]
> > >
> >
> >
> > --
> > -Tai Dupree
> >
>
>
> --
> -Tai Dupree
>