You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by al...@apache.org on 2010/11/24 22:16:44 UTC
svn commit: r1038821 - in
/myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5:
component/input/ handler/ renderkit/input/ renderkit/input/delegate/
renderkit/input/util/ renderkit/util/
Author: aliok
Date: Wed Nov 24 21:16:42 2010
New Revision: 1038821
URL: http://svn.apache.org/viewvc?rev=1038821&view=rev
Log:
Html5
Some TODO removal and documentation
Modified:
myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/component/input/AbstractHtmlDataList.java
myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/component/input/AbstractHtmlInputDateTime.java
myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/handler/DropTargetBehaviorHandler.java
myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlDataListRenderer.java
myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlInputTextRenderer.java
myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/input/delegate/HtmlDataListSuggestionRendererHelper.java
myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/input/util/Html5DateTimeFormatUtils.java
myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/util/Html5RendererUtils.java
Modified: myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/component/input/AbstractHtmlDataList.java
URL: http://svn.apache.org/viewvc/myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/component/input/AbstractHtmlDataList.java?rev=1038821&r1=1038820&r2=1038821&view=diff
==============================================================================
--- myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/component/input/AbstractHtmlDataList.java (original)
+++ myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/component/input/AbstractHtmlDataList.java Wed Nov 24 21:16:42 2010
@@ -40,7 +40,6 @@ public abstract class AbstractHtmlDataLi
{
private static final Logger log = Logger.getLogger(AbstractHtmlDataList.class.getName());
- //TODO: docme
/**
* Suggestion values to use. Can be one of comma seperated strings, array of {@link SelectItem} or collection of {@link SelectItem}.
*/
Modified: myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/component/input/AbstractHtmlInputDateTime.java
URL: http://svn.apache.org/viewvc/myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/component/input/AbstractHtmlInputDateTime.java?rev=1038821&r1=1038820&r2=1038821&view=diff
==============================================================================
--- myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/component/input/AbstractHtmlInputDateTime.java (original)
+++ myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/component/input/AbstractHtmlInputDateTime.java Wed Nov 24 21:16:42 2010
@@ -70,42 +70,42 @@ public abstract class AbstractHtmlInputD
* <td>Step should be expressed in seconds.</td>
* <td>1 minute</td>
* <td>0.01 (10 miliseconds)</td>
- * <td>N/A</td> //TODO: test it again
+ * <td>N/A</td> //XXX: test it again
* </tr>
* <tr>
* <td>date</td>
* <td>Step should be expressed in days.</td>
* <td>1 day</td>
* <td>1 (1 day)</td>
- * <td>N/A</td> //TODO: test it again
+ * <td>N/A</td> //XXX: test it again
* </tr>
* <tr>
* <td>time</td>
* <td>Step should be expressed in seconds. If the step is less than 1 second, browser should show the miliseconds input too.</td>
* <td>1 minute</td>
* <td>0.01 (10 miliseconds)</td>
- * <td>N/A</td> //TODO: test it again
+ * <td>N/A</td> //XXX: test it again
* </tr>
* <tr>
* <td>month</td>
* <td>Step should be expressed in months.</td>
* <td>1 month</td>
* <td>1 (1 month)</td>
- * <td>N/A</td> //TODO: test it again
+ * <td>N/A</td> //XXX: test it again
* </tr>
* <tr>
* <td>week</td>
* <td>Step should be expressed in weeks.</td>
* <td>1 week</td>
* <td>1 (1 week)</td>
- * <td>N/A</td> //TODO: test it again
+ * <td>N/A</td> //XXX: test it again
* </tr>
* <tr>
* <td>datetime-local</td>
* <td>Step should be expressed in seconds.</td>
* <td>1 minute</td>
* <td>0.01 (10 miliseconds)</td>
- * <td>N/A</td> //TODO: test it again
+ * <td>N/A</td> //XXX: test it again
* </tr>
* </table>
*
Modified: myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/handler/DropTargetBehaviorHandler.java
URL: http://svn.apache.org/viewvc/myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/handler/DropTargetBehaviorHandler.java?rev=1038821&r1=1038820&r2=1038821&view=diff
==============================================================================
--- myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/handler/DropTargetBehaviorHandler.java (original)
+++ myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/handler/DropTargetBehaviorHandler.java Wed Nov 24 21:16:42 2010
@@ -254,7 +254,7 @@ public class DropTargetBehaviorHandler e
holder.addClientBehavior(ClientBehaviorEvents.DRAGOVER_EVENT, dropTargetBehavior);
holder.addClientBehavior(ClientBehaviorEvents.DROP_EVENT, dropTargetBehavior);
}
- //TODO: try in a composite component!
+ //XXX: try in a composite component!
/*
* else if (UIComponent.isCompositeComponent(parent)) { // COPIED FROM AjaxHandler! // It is supposed that for
* composite components, this tag should // add itself as a target, but note that on whole api does not exists
Modified: myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlDataListRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlDataListRenderer.java?rev=1038821&r1=1038820&r2=1038821&view=diff
==============================================================================
--- myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlDataListRenderer.java (original)
+++ myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlDataListRenderer.java Wed Nov 24 21:16:42 2010
@@ -28,7 +28,6 @@ import org.apache.myfaces.buildtools.mav
import org.apache.myfaces.html5.renderkit.input.delegate.HtmlDataListSuggestionRendererHelper;
import org.apache.myfaces.html5.renderkit.input.delegate.SuggestionRendererHelper;
-//TODO: docme
@JSFRenderer(renderKitId = "HTML_BASIC", family = "javax.faces.Output", type = "org.apache.myfaces.html5.DataList")
public class HtmlDataListRenderer extends Renderer
{
Modified: myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlInputTextRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlInputTextRenderer.java?rev=1038821&r1=1038820&r2=1038821&view=diff
==============================================================================
--- myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlInputTextRenderer.java (original)
+++ myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlInputTextRenderer.java Wed Nov 24 21:16:42 2010
@@ -169,7 +169,7 @@ public class HtmlInputTextRenderer exten
*/
protected void checkInputHtmlType(UIComponent uiComponent)
{
- // TODO: this is called from too many places! reduce them!
+ // XXX: this is called from too many places! reduce them!
HtmlInputText component = (HtmlInputText) uiComponent;
String type = component.getType();
if (log.isLoggable(Level.FINE))
Modified: myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/input/delegate/HtmlDataListSuggestionRendererHelper.java
URL: http://svn.apache.org/viewvc/myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/input/delegate/HtmlDataListSuggestionRendererHelper.java?rev=1038821&r1=1038820&r2=1038821&view=diff
==============================================================================
--- myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/input/delegate/HtmlDataListSuggestionRendererHelper.java (original)
+++ myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/input/delegate/HtmlDataListSuggestionRendererHelper.java Wed Nov 24 21:16:42 2010
@@ -32,7 +32,9 @@ import org.apache.myfaces.html5.renderki
import org.apache.myfaces.html5.renderkit.util.JsfProperties;
import org.apache.myfaces.shared_html5.renderkit.RendererUtils;
-//TODO: docme
+/**
+ * Implementation of {@link SuggestionRendererHelper} for usage in {@link org.apache.myfaces.html5.component.input.HtmlDataList}s.
+ */
public class HtmlDataListSuggestionRendererHelper extends HtmlTextInputSuggestionRendererHelper
{
Modified: myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/input/util/Html5DateTimeFormatUtils.java
URL: http://svn.apache.org/viewvc/myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/input/util/Html5DateTimeFormatUtils.java?rev=1038821&r1=1038820&r2=1038821&view=diff
==============================================================================
--- myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/input/util/Html5DateTimeFormatUtils.java (original)
+++ myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/input/util/Html5DateTimeFormatUtils.java Wed Nov 24 21:16:42 2010
@@ -93,7 +93,7 @@ public class Html5DateTimeFormatUtils
}
else if (HTML5.INPUT_TYPE_DATETIME_LOCAL.equals(type))
{
- return _formatLocalDateTime(value); // TODO: with which timezone?
+ return _formatLocalDateTime(value);
}
else if (HTML5.INPUT_TYPE_DATE.equals(type))
{
Modified: myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/util/Html5RendererUtils.java
URL: http://svn.apache.org/viewvc/myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/util/Html5RendererUtils.java?rev=1038821&r1=1038820&r2=1038821&view=diff
==============================================================================
--- myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/util/Html5RendererUtils.java (original)
+++ myfaces/gsoc/html5-comp-lib/trunk/html5-comp-lib-core/src/main/java/org/apache/myfaces/html5/renderkit/util/Html5RendererUtils.java Wed Nov 24 21:16:42 2010
@@ -116,7 +116,7 @@ public class Html5RendererUtils
* so draggable="draggable" is a syntax error. for these attrs, we need to render ="true" like
* draggable="true". so, to prevent writer.writeAttribute(...) render that, this is the workaround!
*
- * TODO: file a ticket on JIRA for this issue
+ * XXX: file a ticket on JIRA for this issue
*/
if (value instanceof Boolean)