[solr] branch branch_9x updated: SOLR-16915: Set the AffinityPlacementPlugin minimalFreeDiskGB to 5 (#1817)

[ho...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

houston pushed a commit to branch branch_9x
in repository https://gitbox.apache.org/repos/asf/solr.git


The following commit(s) were added to refs/heads/branch_9x by this push:
     new 09edcf21608 SOLR-16915: Set the AffinityPlacementPlugin minimalFreeDiskGB to 5 (#1817)
09edcf21608 is described below

commit 09edcf21608950cdaebb204cc074dfd6f46eee0f
Author: Houston Putman <ho...@apache.org>
AuthorDate: Tue Aug 1 17:49:27 2023 -0400

    SOLR-16915: Set the AffinityPlacementPlugin minimalFreeDiskGB to 5 (#1817)
    
    (cherry picked from commit 5926eda577aa2ab3316898a44bb59382367d3e9e)
---
 solr/CHANGES.txt                                                      | 2 ++
 .../solr/cluster/placement/plugins/AffinityPlacementConfig.java       | 2 +-
 .../modules/configuration-guide/pages/replica-placement-plugins.adoc  | 2 +-
 .../modules/upgrade-notes/pages/major-changes-in-solr-9.adoc          | 4 ++++
 4 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
index 6da8c73c90a..a588e42fd91 100644
--- a/solr/CHANGES.txt
+++ b/solr/CHANGES.txt
@@ -49,6 +49,8 @@ Other Changes
 
 * SOLR-16803: Remove dependencies on methods defined in the SimplePostTool from Solr core and solrj modules.
 
+* SOLR-16915: Lower the AffinityPlacementPlugin's default minimalFreeDiskGB to 5 GB (Houston Putman)
+
 ==================  9.3.0 ==================
 
 Upgrade Notes
diff --git a/solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementConfig.java b/solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementConfig.java
index 2a5d2bdb4a6..2622082a296 100644
--- a/solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementConfig.java
+++ b/solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementConfig.java
@@ -28,7 +28,7 @@ import org.apache.solr.common.annotation.JsonProperty;
 /** Configuration bean for {@link AffinityPlacementFactory}. */
 public class AffinityPlacementConfig implements PlacementPluginConfig {
 
-  public static final long DEFAULT_MINIMAL_FREE_DISK_GB = 20L;
+  public static final long DEFAULT_MINIMAL_FREE_DISK_GB = 5L;
   public static final long DEFAULT_PRIORITIZED_FREE_DISK_GB = 100L;
 
   public static final AffinityPlacementConfig DEFAULT =
diff --git a/solr/solr-ref-guide/modules/configuration-guide/pages/replica-placement-plugins.adoc b/solr/solr-ref-guide/modules/configuration-guide/pages/replica-placement-plugins.adoc
index 1f5f19e14ae..4556574ea51 100644
--- a/solr/solr-ref-guide/modules/configuration-guide/pages/replica-placement-plugins.adoc
+++ b/solr/solr-ref-guide/modules/configuration-guide/pages/replica-placement-plugins.adoc
@@ -147,7 +147,7 @@ This plugin supports the following configuration parameters:
 +
 [%autowidth,frame=none]
 |===
-|Optional |Default: `20` Gigabytes
+|Optional |Default: `5` Gigabytes
 |===
 +
 If a node has strictly less GB of free disk than this value, the node is excluded from assignment decisions.
diff --git a/solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc b/solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc
index e28b08a782c..c8c2f3f5f36 100644
--- a/solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc
+++ b/solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc
@@ -72,6 +72,10 @@ Please refer to the xref:configuration-guide:commits-transaction-logs.html#hard-
 for more information on how this change will effect you.
 Upgrading existing clouds and use-cases that have custom configSets will not be affected by this change.
 
+=== Replica Placements
+* The default `minimalFreeDiskGB` value has been lowered from `20GB` to `5GB` when using the xref:configuration-guide:replica-placement-plugins.adoc#affinityplacementfactory[AffinityPlacementPlugin].
+Therefore, when using the default settings, nodes that were previously excluded from Replica placements due to low available disk space may be selected after upgrading.
+
 
 == Solr 9.3
 === Binary Releases