You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/03/27 01:01:59 UTC
Re: Review Request 32550: Add major, minor,
and patch accessors to stout's Version.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32550/
-----------------------------------------------------------
(Updated March 27, 2015, 12:01 a.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Bugs: MESOS-1795 and MESOS-2161
https://issues.apache.org/jira/browse/MESOS-1795
https://issues.apache.org/jira/browse/MESOS-2161
Repository: mesos
Description
-------
We called them majorVersion, minorVersion, and patchVersion to avoid conflicting with major() and minor() (http://man.he.net/man3/gnu_dev_major)
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 090fcf09dd96538a8748cf4443d150911e2c0d27
Diff: https://reviews.apache.org/r/32550/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 32550: Add major, minor,
and patch accessors to stout's Version.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32550/#review78080
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp
<https://reviews.apache.org/r/32550/#comment126483>
These are const, let's just expose them as fields (without the _), like we do for os::Release.
- Benjamin Hindman
On March 27, 2015, 12:01 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32550/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 12:01 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-1795 and MESOS-2161
> https://issues.apache.org/jira/browse/MESOS-1795
> https://issues.apache.org/jira/browse/MESOS-2161
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We called them majorVersion, minorVersion, and patchVersion to avoid conflicting with major() and minor() (http://man.he.net/man3/gnu_dev_major)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 090fcf09dd96538a8748cf4443d150911e2c0d27
>
> Diff: https://reviews.apache.org/r/32550/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 32550: Add major, minor,
and patch accessors to stout's Version.
Posted by Niklas Nielsen <ni...@qni.dk>.
> On March 26, 2015, 5:35 p.m., Ben Mahler wrote:
> > I'm curious, what do you need these for? We intentionally left them out, because we figured comparisons would be used rather than explicit checks against numbers.
To be able to construct a java Version object (in https://reviews.apache.org/r/32151/diff/#) where we check JNI mesos version in Java code.
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32550/#review77992
-----------------------------------------------------------
On March 26, 2015, 5:01 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32550/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 5:01 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-1795 and MESOS-2161
> https://issues.apache.org/jira/browse/MESOS-1795
> https://issues.apache.org/jira/browse/MESOS-2161
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We called them majorVersion, minorVersion, and patchVersion to avoid conflicting with major() and minor() (http://man.he.net/man3/gnu_dev_major)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 090fcf09dd96538a8748cf4443d150911e2c0d27
>
> Diff: https://reviews.apache.org/r/32550/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 32550: Add major, minor,
and patch accessors to stout's Version.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32550/#review77992
-----------------------------------------------------------
I'm curious, what do you need these for? We intentionally left them out, because we figured comparisons would be used rather than explicit checks against numbers.
- Ben Mahler
On March 27, 2015, 12:01 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32550/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 12:01 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-1795 and MESOS-2161
> https://issues.apache.org/jira/browse/MESOS-1795
> https://issues.apache.org/jira/browse/MESOS-2161
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We called them majorVersion, minorVersion, and patchVersion to avoid conflicting with major() and minor() (http://man.he.net/man3/gnu_dev_major)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 090fcf09dd96538a8748cf4443d150911e2c0d27
>
> Diff: https://reviews.apache.org/r/32550/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>