[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #739: [#719] feat(netty): Optimize allocation strategy

["advancedxy (via GitHub)" <gi...@apache.org>]

advancedxy commented on code in PR #739:
URL: https://github.com/apache/incubator-uniffle/pull/739#discussion_r1141315283


##########
client-mr/src/main/java/org/apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java:
##########
@@ -130,6 +131,11 @@ public static void main(String[] args) {
         assignmentTags.addAll(Arrays.asList(rawTags.split(",")));
       }
       assignmentTags.add(Constants.SHUFFLE_SERVER_VERSION);
+      if (ClientType.GRPC_NETTY.name().equals(conf.get(RssMRConfig.RSS_CLIENT_TYPE))) {

Review Comment:
   Could we also add a conf validator for RSS_CLIENT_TYPE here?
   
   Then I think we can simply call `assignmentTags.add(conf.get(RssMRConfig.RSS_CLIENT_TYPE))` here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org