[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5327: note/sysview: add Segger System View support

[GitBox <gi...@apache.org>]

a-lunev commented on a change in pull request #5327:
URL: https://github.com/apache/incubator-nuttx/pull/5327#discussion_r794465362



##########
File path: tools/nxstyle.c
##########
@@ -307,6 +307,17 @@ static const char *g_white_list[] =
   "__asan_loadN_noabort",
   "__asan_storeN_noabort",
 
+  /* Ref:
+   * drivers/segger/note_sysview.c

Review comment:
       To follow alphabetical order of the path name I would place this block before:
   ```
   * Ref:
   * fs/nfs/rpc.h
   ```

##########
File path: drivers/segger/config/Global.h
##########
@@ -0,0 +1,45 @@
+/****************************************************************************
+ * drivers/segger/config/Global.h

Review comment:
       I think it'd better to lower case the file name (Global.h -> global.h) as almost all NuttX file names are lower case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org