[jira] [Commented] (ZOOKEEPER-2873) print error and/or abort on invalid server definition

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532887#comment-16532887 ] 

Hudson commented on ZOOKEEPER-2873:
-----------------------------------

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #86 (See [https://builds.apache.org/job/ZooKeeper-trunk/86/])
ZOOKEEPER-2873: abort startup on invalid ports (andor: rev 25fd549dcd4e01de073a2e25ef07c170389b28ea)
* (edit) src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerConfigTest.java
* (edit) src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
* (edit) src/java/test/org/apache/zookeeper/test/ReconfigTest.java


> print error and/or abort on invalid server definition
> -----------------------------------------------------
>
>                 Key: ZOOKEEPER-2873
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2873
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.4.10
>            Reporter: Christopher Smith
>            Assignee: Norbert Kalmar
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 3.6.0, 3.5.5
>
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> While bringing up a new cluster, I managed to fat-finger a sed script and put some lines like this into my config file:
> {code}
> server.1=zookeeper1:2888:2888
> {code}
> This led to a predictable spew of error messages when the client and election components fought over the single port. Since a configuration of this case is *always* an error, I suggest that it would be sensible to abort the server startup if an entry is found with the same port for both client and election. (Logging the error explicitly without shutting down is less helpful because of how fast the logs pile up.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)