You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2020/09/21 21:02:37 UTC

[GitHub] [incubator-heron] Code0x58 edited a comment on pull request #3619: Added ability to disable base_url in Helm chart

Code0x58 edited a comment on pull request #3619:
URL: https://github.com/apache/incubator-heron/pull/3619#issuecomment-696372987


   does setting `--base_url=` work as expected as I feel it should? If so, I'm thinking it would be cleaner to use something better than `default` when setting the url, and to instead use something like `value = config_value if config_value is not None else ""` - that would avoid the new coupled variable currently introduced by the PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org