[qpid-proton] 04/04: PROTON-2053: [C++] Make SASL default to on for better consistency with other bindings

[as...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

astitcher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/qpid-proton.git

commit 88869e64e999130614349021ce9ead018bfccc5b
Author: Andrew Stitcher <as...@apache.org>
AuthorDate: Mon Jul 1 18:44:11 2019 -0400

    PROTON-2053: [C++] Make SASL default to on for better consistency with other bindings
---
 cpp/src/connection_options.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/cpp/src/connection_options.cpp b/cpp/src/connection_options.cpp
index fdc770e..6371573 100644
--- a/cpp/src/connection_options.cpp
+++ b/cpp/src/connection_options.cpp
@@ -116,8 +116,9 @@ class connection_options::impl {
 
         // Skip entirely if SASL explicitly disabled
         if (!sasl_enabled.set || sasl_enabled.value) {
-            if (sasl_enabled.set)  // Explicitly set, not just default behaviour.
-                pn_sasl(pnt);      // Force a sasl instance.  Lazily create one otherwise.
+            // We now default to enabling SASL even without specific SASL configuration
+            // This gives better interoperability and consistency across bindings
+            pn_sasl(pnt);
             if (sasl_allow_insecure_mechs.set)
                 pn_sasl_set_allow_insecure_mechs(pn_sasl(pnt), sasl_allow_insecure_mechs.value);
             if (sasl_allowed_mechs.set)


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org