You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/10/16 20:49:31 UTC
[kudu-CR](branch-1.11.x) ksck: print tablet server states
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14464
Change subject: ksck: print tablet server states
......................................................................
ksck: print tablet server states
This adds a table of tserver states to the ksck output:
...
Tablet Server States
Server | State
----------------------------------+------------------
767c081ea5564c9a8ed8615c00658e1b | MAINTENANCE_MODE
Tablet Server Summary
...
When there are no special tablet server states, the section doesn't get
printed.
I wanted to reuse some of the client code to list tablet servers but didn't
want to change the public interface, so this patch also rejiggers the
ListTabletServers client logic into the client data class.
Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
Reviewed-on: http://gerrit.cloudera.org:8080/14436
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit b5716b71854cee432d188b46f5d66d200484f4f0)
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/ksck_results.cc
M src/kudu/tools/ksck_results.h
M src/kudu/tools/kudu-tool-test.cc
10 files changed, 137 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/14464/1
--
To view, visit http://gerrit.cloudera.org:8080/14464
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
Gerrit-Change-Number: 14464
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR](branch-1.11.x) ksck: print tablet server states
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14464 )
Change subject: ksck: print tablet server states
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14464
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
Gerrit-Change-Number: 14464
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Oct 2019 20:51:46 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.11.x) ksck: print tablet server states
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14464 )
Change subject: ksck: print tablet server states
......................................................................
ksck: print tablet server states
This adds a table of tserver states to the ksck output:
...
Tablet Server States
Server | State
----------------------------------+------------------
767c081ea5564c9a8ed8615c00658e1b | MAINTENANCE_MODE
Tablet Server Summary
...
When there are no special tablet server states, the section doesn't get
printed.
I wanted to reuse some of the client code to list tablet servers but didn't
want to change the public interface, so this patch also rejiggers the
ListTabletServers client logic into the client data class.
Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
Reviewed-on: http://gerrit.cloudera.org:8080/14436
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit b5716b71854cee432d188b46f5d66d200484f4f0)
Reviewed-on: http://gerrit.cloudera.org:8080/14464
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/ksck_results.cc
M src/kudu/tools/ksck_results.h
M src/kudu/tools/kudu-tool-test.cc
10 files changed, 137 insertions(+), 31 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14464
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be
Gerrit-Change-Number: 14464
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)