[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #40: [FLINK-26567] FileStoreSourceSplitReader should deal with value count

[GitBox <gi...@apache.org>]

JingsongLi commented on a change in pull request #40:
URL: https://github.com/apache/flink-table-store/pull/40#discussion_r823432457



##########
File path: flink-table-store-connector/src/test/java/org/apache/flink/table/store/connector/source/FileStoreSourceSplitReaderTest.java
##########
@@ -64,32 +67,92 @@ public static void after() {
     }
 
     @Test
-    public void testKeyAsRecord() throws Exception {
-        innerTestOnce(true);
+    public void testPrimaryKey() throws Exception {
+        innerTestOnce(false, 0);
+    }
+
+    @Test
+    public void testValueCount() throws Exception {
+        innerTestOnce(true, 0);

Review comment:
       value is a bigint.
   - has pk, value is the record
   - value count, value is the record count




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org