You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/05 13:22:17 UTC
[GitHub] [airflow] do-it-tim opened a new issue, #28745: annotations in logs pvc
do-it-tim opened a new issue, #28745:
URL: https://github.com/apache/airflow/issues/28745
### Official Helm Chart version
1.7.0 (latest released)
### Apache Airflow version
2.5.0
### Kubernetes Version
v1.22.8+d48376b
### Helm Chart configuration
_No response_
### Docker Image customisations
_No response_
### What happened
When creating the dags pvc, it is possible to inject annotations to the object.
### What you think should happen instead
There should be the possibility to inject annotations to the logs pvc as well.
### How to reproduce
_No response_
### Anything else
We are using annotations on pvc to disable the creation of backup snapshots provided by our company platform. (OpenShift)
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #28745: annotations in logs pvc
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #28745:
URL: https://github.com/apache/airflow/issues/28745#issuecomment-1385172787
Feel free to add PR adding it @do-it-tim
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] do-it-tim commented on issue #28745: annotations in logs pvc
Posted by "do-it-tim (via GitHub)" <gi...@apache.org>.
do-it-tim commented on issue #28745:
URL: https://github.com/apache/airflow/issues/28745#issuecomment-1410464424
Glad to here that.
There are differences between the creation of dags pvc versus logs pvc.
You can compare these two files:
https://github.com/apache/airflow/blob/main/chart/templates/dags-persistent-volume-claim.yaml#L32-L35
vs
https://github.com/apache/airflow/blob/main/chart/templates/logs-persistent-volume-claim.yaml
There is no possibility to add annotations in the logs pvc.
Hope this helps!
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on issue #28745: annotations in logs pvc
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on issue #28745:
URL: https://github.com/apache/airflow/issues/28745#issuecomment-1410862961
@do-it-tim added support for this in https://github.com/apache/airflow/pull/29270.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #28745: annotations in logs pvc
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #28745:
URL: https://github.com/apache/airflow/issues/28745#issuecomment-1372210315
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on issue #28745: annotations in logs pvc
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on issue #28745:
URL: https://github.com/apache/airflow/issues/28745#issuecomment-1437873467
@potiuk we can close this. It has been merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #28745: annotations in logs pvc
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed issue #28745: annotations in logs pvc
URL: https://github.com/apache/airflow/issues/28745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on issue #28745: annotations in logs pvc
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on issue #28745:
URL: https://github.com/apache/airflow/issues/28745#issuecomment-1410454908
@potiuk @do-it-tim if nobody is actively developing this, i would be more than happy to take it up. I would require some more context and concrete idea before starting though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on issue #28745: annotations in logs pvc
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on issue #28745:
URL: https://github.com/apache/airflow/issues/28745#issuecomment-1410523257
I can take it up then. @potiuk can I?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on issue #28745: annotations in logs pvc
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on issue #28745:
URL: https://github.com/apache/airflow/issues/28745#issuecomment-1410470039
Oh, thanks @do-it-tim. It would be nice to accept it from: `.Values.logs.persistence.annotations`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] do-it-tim commented on issue #28745: annotations in logs pvc
Posted by "do-it-tim (via GitHub)" <gi...@apache.org>.
do-it-tim commented on issue #28745:
URL: https://github.com/apache/airflow/issues/28745#issuecomment-1410489399
yes, think that would be the equivalent way to do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org