You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ranger.apache.org by "kirby zhou (Jira)" <ji...@apache.org> on 2022/03/02 08:41:00 UTC

[jira] [Reopened] (RANGER-2095) Add unit tests for new read only admin-auditor/kms-auditor roles functionality

     [ https://issues.apache.org/jira/browse/RANGER-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

kirby zhou reopened RANGER-2095:
--------------------------------

The patch is buggy:

 
 * testBlockAuditorRoleUserThrowsErrorForAuditKeyAdmin
 * testBlockAuditorRoleUserThrowsErrorForAuditUserAdmin
 * testBlockAuditorRoleUserSuccess

The 3 tests should test behavior of RangerBizUtil::blockAuditorRoleUser.

But it constructs a mocked RangerBizUtil, and stub blockAuditorRoleUser. The real RangerBizUtil::blockAuditorRoleUser is never being executed.

> Add unit tests for new read only admin-auditor/kms-auditor roles functionality
> ------------------------------------------------------------------------------
>
>                 Key: RANGER-2095
>                 URL: https://issues.apache.org/jira/browse/RANGER-2095
>             Project: Ranger
>          Issue Type: Improvement
>          Components: Ranger
>            Reporter: Bhavik Patel
>            Assignee: Bhavik Patel
>            Priority: Critical
>             Fix For: 1.1.0
>
>         Attachments: RANGER-2095-master.patch
>
>
> Add unit tests for new read only admin-auditor/kms-auditor roles functionality



--
This message was sent by Atlassian Jira
(v8.20.1#820001)