[GitHub] ctcyang commented on a change in pull request #12666: [MXNET-1111] Horovod support for MXNet

[GitBox <gi...@apache.org>]

ctcyang commented on a change in pull request #12666: [MXNET-1111] Horovod support for MXNet
URL: https://github.com/apache/incubator-mxnet/pull/12666#discussion_r227188363
 
 

 ##########
 File path: python/mxnet/module/bucketing_module.py
 ##########
 @@ -161,7 +161,7 @@ def output_shapes(self):
         assert self.binded
         return self._curr_module.output_shapes
 
-    def get_params(self):
+    def get_params(self, copy_to_cpu=True):
 
 Review comment:
   It's there, because it's needed to be called by the user here during MXNet training: https://github.com/ctcyang/horovod/blob/0deb0d5d5c6befda6bad49ff713a0e0061fc08da/examples/mxnet_imagenet_resnet50.py#L266
   
   Horovod only supports (input on GPU, output on GPU) type of communication. However, we found that `get_params` returns it as an NDArray on the CPU by default. That is why we need to add this argument here to make Horovod work. Since the default is set to `True`, it maintains backward compatibility with the rest of MXNet code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services