You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "ngsg (via GitHub)" <gi...@apache.org> on 2023/05/26 08:37:56 UTC
[GitHub] [hive] ngsg opened a new pull request, #4360: Hive 27375: fix map join cache reuse
ngsg opened a new pull request, #4360:
URL: https://github.com/apache/hive/pull/4360
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
SharedWorkOptimizer now assigns the same MapJoin cache key to MapJoinOperators if they have the same broadcast inputs.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
If n-way join is enabled, MapJoinOperator can have 2 or more broadcast inputs. However, current SharedWorkOptimizer compares the first broadcast input only.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
We tested this patch by running TPC-DS query 23 on 1TB orc dataset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ngsg commented on a diff in pull request #4360: HIVE-27375: fix map join cache reuse
Posted by "ngsg (via GitHub)" <gi...@apache.org>.
ngsg commented on code in PR #4360:
URL: https://github.com/apache/hive/pull/4360#discussion_r1212608492
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -985,12 +982,45 @@ private static void sharedWorkExtendedOptimization(ParseContext pctx, SharedWork
/**
* Obtain the RS input for a mapjoin operator.
*/
- private static ReduceSinkOperator obtainBroadcastInput(MapJoinOperator mapJoinOp) {
+ private static ReduceSinkOperator obtainFirstBroadcastInput(MapJoinOperator mapJoinOp) {
return mapJoinOp.getParentOperators().get(0) instanceof ReduceSinkOperator ?
(ReduceSinkOperator) mapJoinOp.getParentOperators().get(0) :
(ReduceSinkOperator) mapJoinOp.getParentOperators().get(1);
}
+ private static boolean canShareBroadcastInputs(
Review Comment:
1. Sure, I will add one.
2. I used static method because it does not rely on any of the state of SharedWorkOptimizer instance. I agree that nonstatic method should be preferred to static method and will modify this method and some other static methods such as obtainFirstBroadcastInput() to be nonstatic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] akshat0395 commented on pull request #4360: HIVE-27375: fix map join cache reuse
Posted by "akshat0395 (via GitHub)" <gi...@apache.org>.
akshat0395 commented on PR #4360:
URL: https://github.com/apache/hive/pull/4360#issuecomment-1573113064
Thanks for the patch @ngsg, LGTM +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4360: HIVE-27375: fix map join cache reuse
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4360:
URL: https://github.com/apache/hive/pull/4360#issuecomment-1572298196
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4360)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4360&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4360&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4360&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4360&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4360&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ngsg commented on a diff in pull request #4360: HIVE-27375: fix map join cache reuse
Posted by "ngsg (via GitHub)" <gi...@apache.org>.
ngsg commented on code in PR #4360:
URL: https://github.com/apache/hive/pull/4360#discussion_r1225369948
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -982,15 +943,88 @@ private static void sharedWorkExtendedOptimization(ParseContext pctx, SharedWork
(Entry<String, TableScanOperator> e) -> e.getValue().getNumChild() == 0);
}
- /**
- * Obtain the RS input for a mapjoin operator.
- */
- private static ReduceSinkOperator obtainBroadcastInput(MapJoinOperator mapJoinOp) {
+ @VisibleForTesting
+ public void runMapJoinCacheReuseOptimization(
+ ParseContext pctx, SharedWorkOptimizerCache optimizerCache) throws SemanticException {
+ // First we group together all the mapjoin operators whose first broadcast input is the same.
+ final Multimap<Operator<?>, MapJoinOperator> parentToMapJoinOperators = ArrayListMultimap.create();
+ for (Set<Operator<?>> workOperators : optimizerCache.getWorkGroups()) {
+ for (Operator<?> op : workOperators) {
+ if (op instanceof MapJoinOperator) {
+ MapJoinOperator mapJoinOp = (MapJoinOperator) op;
+ // Only allowed for mapjoin operator
+ if (!mapJoinOp.getConf().isBucketMapJoin() && !mapJoinOp.getConf().isDynamicPartitionHashJoin()) {
+ parentToMapJoinOperators.put(
+ obtainFirstBroadcastInput(mapJoinOp).getParentOperators().get(0), mapJoinOp);
+ }
+ }
+ }
+ }
+
+ // For each group, set the cache key accordingly if there is more than one operator
+ // and input RS operator are equal
+ for (Collection<MapJoinOperator> c : parentToMapJoinOperators.asMap().values()) {
+ Map<MapJoinOperator, String> mapJoinOpToCacheKey = new HashMap<>();
+ for (MapJoinOperator mapJoinOp : c) {
+ String cacheKey = null;
+ for (Entry<MapJoinOperator, String> e: mapJoinOpToCacheKey.entrySet()) {
+ if (canShareBroadcastInputs(pctx, mapJoinOp, e.getKey())) {
+ cacheKey = e.getValue();
+ break;
+ }
+ }
+
+ if (cacheKey == null) {
+ // Either it is the first map join operator or there was no equivalent broadcast input,
+ // hence generate cache key
+ cacheKey = MapJoinDesc.generateCacheKey(mapJoinOp.getOperatorId());
+ mapJoinOpToCacheKey.put(mapJoinOp, cacheKey);
+ }
+
+ mapJoinOp.getConf().setCacheKey(cacheKey);
+ }
+ }
+ }
+
+ private ReduceSinkOperator obtainFirstBroadcastInput(MapJoinOperator mapJoinOp) {
return mapJoinOp.getParentOperators().get(0) instanceof ReduceSinkOperator ?
(ReduceSinkOperator) mapJoinOp.getParentOperators().get(0) :
(ReduceSinkOperator) mapJoinOp.getParentOperators().get(1);
}
+ private boolean canShareBroadcastInputs(
+ ParseContext pctx, MapJoinOperator mapJoinOp1, MapJoinOperator mapJoinOp2) throws SemanticException {
+ if (mapJoinOp1.getNumParent() != mapJoinOp2.getNumParent()) {
+ return false;
+ }
+
+ if (mapJoinOp1.getConf().getPosBigTable() != mapJoinOp2.getConf().getPosBigTable()) {
+ return false;
+ }
+
+ for (int i = 0; i < mapJoinOp1.getNumParent(); i ++) {
+ if (i == mapJoinOp1.getConf().getPosBigTable()) {
+ continue;
+ }
+
+ ReduceSinkOperator parentRS1 = (ReduceSinkOperator) mapJoinOp1.getParentOperators().get(i);
Review Comment:
MapJoinOperators's parent operator is always ReduceSinkOperator unless it is at big table position.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4360: HIVE-27375: fix map join cache reuse
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4360:
URL: https://github.com/apache/hive/pull/4360#issuecomment-1586530150
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4360)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4360&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4360&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4360&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4360&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4360&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4360: HIVE-27375: fix map join cache reuse
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4360:
URL: https://github.com/apache/hive/pull/4360#issuecomment-1573411919
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4360)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4360&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4360&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4360&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4360&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4360&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a diff in pull request #4360: HIVE-27375: fix map join cache reuse
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #4360:
URL: https://github.com/apache/hive/pull/4360#discussion_r1225368882
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -982,15 +943,88 @@ private static void sharedWorkExtendedOptimization(ParseContext pctx, SharedWork
(Entry<String, TableScanOperator> e) -> e.getValue().getNumChild() == 0);
}
- /**
- * Obtain the RS input for a mapjoin operator.
- */
- private static ReduceSinkOperator obtainBroadcastInput(MapJoinOperator mapJoinOp) {
+ @VisibleForTesting
+ public void runMapJoinCacheReuseOptimization(
+ ParseContext pctx, SharedWorkOptimizerCache optimizerCache) throws SemanticException {
+ // First we group together all the mapjoin operators whose first broadcast input is the same.
+ final Multimap<Operator<?>, MapJoinOperator> parentToMapJoinOperators = ArrayListMultimap.create();
+ for (Set<Operator<?>> workOperators : optimizerCache.getWorkGroups()) {
+ for (Operator<?> op : workOperators) {
+ if (op instanceof MapJoinOperator) {
+ MapJoinOperator mapJoinOp = (MapJoinOperator) op;
+ // Only allowed for mapjoin operator
+ if (!mapJoinOp.getConf().isBucketMapJoin() && !mapJoinOp.getConf().isDynamicPartitionHashJoin()) {
Review Comment:
yes, please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] akshat0395 commented on a diff in pull request #4360: HIVE-27375: fix map join cache reuse
Posted by "akshat0395 (via GitHub)" <gi...@apache.org>.
akshat0395 commented on code in PR #4360:
URL: https://github.com/apache/hive/pull/4360#discussion_r1212515539
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -985,12 +982,45 @@ private static void sharedWorkExtendedOptimization(ParseContext pctx, SharedWork
/**
* Obtain the RS input for a mapjoin operator.
*/
- private static ReduceSinkOperator obtainBroadcastInput(MapJoinOperator mapJoinOp) {
+ private static ReduceSinkOperator obtainFirstBroadcastInput(MapJoinOperator mapJoinOp) {
return mapJoinOp.getParentOperators().get(0) instanceof ReduceSinkOperator ?
(ReduceSinkOperator) mapJoinOp.getParentOperators().get(0) :
(ReduceSinkOperator) mapJoinOp.getParentOperators().get(1);
}
+ private static boolean canShareBroadcastInputs(
Review Comment:
Can we add unit test for this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ngsg commented on pull request #4360: HIVE-27375: fix map join cache reuse
Posted by "ngsg (via GitHub)" <gi...@apache.org>.
ngsg commented on PR #4360:
URL: https://github.com/apache/hive/pull/4360#issuecomment-1571809159
@akshat0395 I separated MapJoinCache reuse optimization from transform() method and added a unit test for it in order to verify the entire logic with realistic situation. Could you please review the change? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] akshat0395 commented on a diff in pull request #4360: HIVE-27375: fix map join cache reuse
Posted by "akshat0395 (via GitHub)" <gi...@apache.org>.
akshat0395 commented on code in PR #4360:
URL: https://github.com/apache/hive/pull/4360#discussion_r1212516881
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -985,12 +982,45 @@ private static void sharedWorkExtendedOptimization(ParseContext pctx, SharedWork
/**
* Obtain the RS input for a mapjoin operator.
*/
- private static ReduceSinkOperator obtainBroadcastInput(MapJoinOperator mapJoinOp) {
+ private static ReduceSinkOperator obtainFirstBroadcastInput(MapJoinOperator mapJoinOp) {
return mapJoinOp.getParentOperators().get(0) instanceof ReduceSinkOperator ?
(ReduceSinkOperator) mapJoinOp.getParentOperators().get(0) :
(ReduceSinkOperator) mapJoinOp.getParentOperators().get(1);
}
+ private static boolean canShareBroadcastInputs(
Review Comment:
Any specific reason why this is a static method? Can we make it non-static?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a diff in pull request #4360: HIVE-27375: fix map join cache reuse
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #4360:
URL: https://github.com/apache/hive/pull/4360#discussion_r1225367836
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -982,15 +943,88 @@ private static void sharedWorkExtendedOptimization(ParseContext pctx, SharedWork
(Entry<String, TableScanOperator> e) -> e.getValue().getNumChild() == 0);
}
- /**
- * Obtain the RS input for a mapjoin operator.
- */
- private static ReduceSinkOperator obtainBroadcastInput(MapJoinOperator mapJoinOp) {
+ @VisibleForTesting
+ public void runMapJoinCacheReuseOptimization(
+ ParseContext pctx, SharedWorkOptimizerCache optimizerCache) throws SemanticException {
+ // First we group together all the mapjoin operators whose first broadcast input is the same.
+ final Multimap<Operator<?>, MapJoinOperator> parentToMapJoinOperators = ArrayListMultimap.create();
+ for (Set<Operator<?>> workOperators : optimizerCache.getWorkGroups()) {
+ for (Operator<?> op : workOperators) {
+ if (op instanceof MapJoinOperator) {
+ MapJoinOperator mapJoinOp = (MapJoinOperator) op;
+ // Only allowed for mapjoin operator
+ if (!mapJoinOp.getConf().isBucketMapJoin() && !mapJoinOp.getConf().isDynamicPartitionHashJoin()) {
+ parentToMapJoinOperators.put(
+ obtainFirstBroadcastInput(mapJoinOp).getParentOperators().get(0), mapJoinOp);
+ }
+ }
+ }
+ }
+
+ // For each group, set the cache key accordingly if there is more than one operator
+ // and input RS operator are equal
+ for (Collection<MapJoinOperator> c : parentToMapJoinOperators.asMap().values()) {
+ Map<MapJoinOperator, String> mapJoinOpToCacheKey = new HashMap<>();
+ for (MapJoinOperator mapJoinOp : c) {
+ String cacheKey = null;
+ for (Entry<MapJoinOperator, String> e: mapJoinOpToCacheKey.entrySet()) {
+ if (canShareBroadcastInputs(pctx, mapJoinOp, e.getKey())) {
+ cacheKey = e.getValue();
+ break;
+ }
+ }
+
+ if (cacheKey == null) {
+ // Either it is the first map join operator or there was no equivalent broadcast input,
+ // hence generate cache key
+ cacheKey = MapJoinDesc.generateCacheKey(mapJoinOp.getOperatorId());
+ mapJoinOpToCacheKey.put(mapJoinOp, cacheKey);
+ }
+
+ mapJoinOp.getConf().setCacheKey(cacheKey);
+ }
+ }
+ }
+
+ private ReduceSinkOperator obtainFirstBroadcastInput(MapJoinOperator mapJoinOp) {
return mapJoinOp.getParentOperators().get(0) instanceof ReduceSinkOperator ?
(ReduceSinkOperator) mapJoinOp.getParentOperators().get(0) :
(ReduceSinkOperator) mapJoinOp.getParentOperators().get(1);
}
+ private boolean canShareBroadcastInputs(
+ ParseContext pctx, MapJoinOperator mapJoinOp1, MapJoinOperator mapJoinOp2) throws SemanticException {
+ if (mapJoinOp1.getNumParent() != mapJoinOp2.getNumParent()) {
+ return false;
+ }
+
+ if (mapJoinOp1.getConf().getPosBigTable() != mapJoinOp2.getConf().getPosBigTable()) {
+ return false;
+ }
+
+ for (int i = 0; i < mapJoinOp1.getNumParent(); i ++) {
+ if (i == mapJoinOp1.getConf().getPosBigTable()) {
+ continue;
+ }
+
+ ReduceSinkOperator parentRS1 = (ReduceSinkOperator) mapJoinOp1.getParentOperators().get(i);
Review Comment:
is that a safe cast?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ngsg commented on pull request #4360: HIVE-27375: fix map join cache reuse
Posted by "ngsg (via GitHub)" <gi...@apache.org>.
ngsg commented on PR #4360:
URL: https://github.com/apache/hive/pull/4360#issuecomment-1585677230
I moved the comment and restored the code formatting for long conditional expression. @deniskuzZ Could you please check the changes? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a diff in pull request #4360: HIVE-27375: fix map join cache reuse
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #4360:
URL: https://github.com/apache/hive/pull/4360#discussion_r1225363957
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -982,15 +943,88 @@ private static void sharedWorkExtendedOptimization(ParseContext pctx, SharedWork
(Entry<String, TableScanOperator> e) -> e.getValue().getNumChild() == 0);
}
- /**
- * Obtain the RS input for a mapjoin operator.
- */
- private static ReduceSinkOperator obtainBroadcastInput(MapJoinOperator mapJoinOp) {
+ @VisibleForTesting
+ public void runMapJoinCacheReuseOptimization(
+ ParseContext pctx, SharedWorkOptimizerCache optimizerCache) throws SemanticException {
+ // First we group together all the mapjoin operators whose first broadcast input is the same.
+ final Multimap<Operator<?>, MapJoinOperator> parentToMapJoinOperators = ArrayListMultimap.create();
+ for (Set<Operator<?>> workOperators : optimizerCache.getWorkGroups()) {
+ for (Operator<?> op : workOperators) {
+ if (op instanceof MapJoinOperator) {
+ MapJoinOperator mapJoinOp = (MapJoinOperator) op;
+ // Only allowed for mapjoin operator
+ if (!mapJoinOp.getConf().isBucketMapJoin() && !mapJoinOp.getConf().isDynamicPartitionHashJoin()) {
Review Comment:
please keep the original code formatting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4360: HIVE-27375: fix map join cache reuse
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4360:
URL: https://github.com/apache/hive/pull/4360#issuecomment-1585699574
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4360)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4360&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4360&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4360&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4360&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4360&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4360: HIVE-27375: fix map join cache reuse
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4360:
URL: https://github.com/apache/hive/pull/4360#issuecomment-1564133169
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4360)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4360&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4360&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4360&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4360&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4360&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a diff in pull request #4360: HIVE-27375: fix map join cache reuse
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #4360:
URL: https://github.com/apache/hive/pull/4360#discussion_r1225363400
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -217,48 +218,8 @@ public ParseContext transform(ParseContext pctx) throws SemanticException {
}
if (pctx.getConf().getBoolVar(ConfVars.HIVE_SHARED_WORK_REUSE_MAPJOIN_CACHE)) {
- // Try to reuse cache for broadcast side in mapjoin operators that
- // share same input.
- // First we group together all the mapjoin operators that share same
- // reduce sink operator.
- final Multimap<Operator<?>, MapJoinOperator> parentToMapJoinOperators =
- ArrayListMultimap.create();
- for (Set<Operator<?>> workOperators : optimizerCache.getWorkGroups()) {
- for (Operator<?> op : workOperators) {
- if (op instanceof MapJoinOperator) {
- MapJoinOperator mapJoinOp = (MapJoinOperator) op;
- // Only allowed for mapjoin operator
- if (!mapJoinOp.getConf().isBucketMapJoin() &&
- !mapJoinOp.getConf().isDynamicPartitionHashJoin()) {
- parentToMapJoinOperators.put(
- obtainBroadcastInput(mapJoinOp).getParentOperators().get(0), mapJoinOp);
- }
- }
- }
- }
- // For each group, set the cache key accordingly if there is more than one operator
- // and input RS operator are equal
- for (Collection<MapJoinOperator> c : parentToMapJoinOperators.asMap().values()) {
- Map<ReduceSinkOperator, String> rsOpToCacheKey = new HashMap<>();
- for (MapJoinOperator mapJoinOp : c) {
- ReduceSinkOperator rsOp = obtainBroadcastInput(mapJoinOp);
- String cacheKey = null;
- for (Entry<ReduceSinkOperator, String> e: rsOpToCacheKey.entrySet()) {
- if (compareOperator(pctx, rsOp, e.getKey())) {
- cacheKey = e.getValue();
- break;
- }
- }
- if (cacheKey == null) {
- // Either it is the first map join operator or there was no equivalent RS,
- // hence generate cache key
- cacheKey = MapJoinDesc.generateCacheKey(mapJoinOp.getOperatorId());
- rsOpToCacheKey.put(rsOp, cacheKey);
- }
- // Set in the conf of the map join operator
- mapJoinOp.getConf().setCacheKey(cacheKey);
- }
- }
+ // Try to reuse cache for broadcast side in mapjoin operators that share the same input.
Review Comment:
could we please move that comment to the method javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ngsg commented on a diff in pull request #4360: HIVE-27375: fix map join cache reuse
Posted by "ngsg (via GitHub)" <gi...@apache.org>.
ngsg commented on code in PR #4360:
URL: https://github.com/apache/hive/pull/4360#discussion_r1225368491
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -982,15 +943,88 @@ private static void sharedWorkExtendedOptimization(ParseContext pctx, SharedWork
(Entry<String, TableScanOperator> e) -> e.getValue().getNumChild() == 0);
}
- /**
- * Obtain the RS input for a mapjoin operator.
- */
- private static ReduceSinkOperator obtainBroadcastInput(MapJoinOperator mapJoinOp) {
+ @VisibleForTesting
+ public void runMapJoinCacheReuseOptimization(
+ ParseContext pctx, SharedWorkOptimizerCache optimizerCache) throws SemanticException {
+ // First we group together all the mapjoin operators whose first broadcast input is the same.
+ final Multimap<Operator<?>, MapJoinOperator> parentToMapJoinOperators = ArrayListMultimap.create();
+ for (Set<Operator<?>> workOperators : optimizerCache.getWorkGroups()) {
+ for (Operator<?> op : workOperators) {
+ if (op instanceof MapJoinOperator) {
+ MapJoinOperator mapJoinOp = (MapJoinOperator) op;
+ // Only allowed for mapjoin operator
+ if (!mapJoinOp.getConf().isBucketMapJoin() && !mapJoinOp.getConf().isDynamicPartitionHashJoin()) {
Review Comment:
Do you mean something like this?
```
if (!mapJoinOp.getConf().isBucketMapJoin() &&
!mapJoinOp.getConf().isDynamicPartitionHashJoin()) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4360: HIVE-27375: fix map join cache reuse
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4360:
URL: https://github.com/apache/hive/pull/4360#issuecomment-1576148914
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4360)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4360&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4360&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4360&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4360&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4360&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4360&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ merged pull request #4360: HIVE-27375: fix map join cache reuse
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ merged PR #4360:
URL: https://github.com/apache/hive/pull/4360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org