You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/03 15:29:42 UTC
[GitHub] [incubator-nuttx] raiden00pl opened a new pull request #711:
arch/arm/src/nrf52: add initial interface to work with on-chip radio
raiden00pl opened a new pull request #711: arch/arm/src/nrf52: add initial interface to work with on-chip radio
URL: https://github.com/apache/incubator-nuttx/pull/711
I know this PR will not pass nxstyle with warnings like this:
```
arch/arm/src/nrf52/hardware/nrf52_radio.h:115:68: warning: Wrong column position of comment right of code
arch/arm/src/nrf52/hardware/nrf52_radio.h:116:68: warning: Wrong column position of comment right of code
```
I'm not sure how to handle these warnings correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #711:
arch/arm/src/nrf52: add initial interface to work with on-chip radio
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #711: arch/arm/src/nrf52: add initial interface to work with on-chip radio
URL: https://github.com/apache/incubator-nuttx/pull/711
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #711:
arch/arm/src/nrf52: add initial interface to work with on-chip radio
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #711: arch/arm/src/nrf52: add initial interface to work with on-chip radio
URL: https://github.com/apache/incubator-nuttx/pull/711#issuecomment-608888004
@Ouss4 Merging as is, based on your recommendation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 commented on issue #711:
arch/arm/src/nrf52: add initial interface to work with on-chip radio
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on issue #711: arch/arm/src/nrf52: add initial interface to work with on-chip radio
URL: https://github.com/apache/incubator-nuttx/pull/711#issuecomment-608549699
> I'm not sure how to handle these warnings correctly.
That would require shifting all the other comments to the same column.
I suggest we merge this as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services