You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by vi...@apache.org on 2015/12/30 20:50:56 UTC
svn commit: r1722399 - /tomcat/trunk/res/findbugs/filter-false-positives.xml
Author: violetagg
Date: Wed Dec 30 19:50:56 2015
New Revision: 1722399
URL: http://svn.apache.org/viewvc?rev=1722399&view=rev
Log:
Findbugs - false positives - known null value
Modified:
tomcat/trunk/res/findbugs/filter-false-positives.xml
Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1722399&r1=1722398&r2=1722399&view=diff
==============================================================================
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Wed Dec 30 19:50:56 2015
@@ -17,6 +17,39 @@
<FindBugsFilter>
<!-- Considered to be false positives -->
<Match>
+ <!-- Only base null is handled by this resolver -->
+ <Class name="javax.el.BeanNameELResolver"/>
+ <Or>
+ <Method name="getType" />
+ <Method name="getValue" />
+ <Method name="isReadOnly" />
+ <Method name="setValue" />
+ </Or>
+ <Bug code="NP" />
+ </Match>
+ <Match>
+ <!-- Only base null is handled by this resolver -->
+ <Class name="javax.servlet.jsp.el.ImplicitObjectELResolver"/>
+ <Or>
+ <Method name="getType" />
+ <Method name="getValue" />
+ <Method name="isReadOnly" />
+ <Method name="setValue" />
+ </Or>
+ <Bug code="NP" />
+ </Match>
+ <Match>
+ <!-- Only base null is handled by this resolver -->
+ <Class name="javax.servlet.jsp.el.ScopedAttributeELResolver"/>
+ <Or>
+ <Method name="getType" />
+ <Method name="getValue" />
+ <Method name="isReadOnly" />
+ <Method name="setValue" />
+ </Or>
+ <Bug code="NP" />
+ </Match>
+ <Match>
<!-- Cannot do anything about this. API is fixed by the specification. -->
<Class name="javax.servlet.jsp.tagext.TagData"/>
<Bug code="CN" />
@@ -164,6 +197,15 @@
<Bug code="IS" />
</Match>
<Match>
+ <!-- roles will be initialized in addAttributeValues -->
+ <Class name="org.apache.catalina.realm.JNDIRealm" />
+ <Or>
+ <Method name="getUserByPattern" />
+ <Method name="getUserBySearch" />
+ </Or>
+ <Bug code="NP" />
+ </Match>
+ <Match>
<!-- request.getRequestPathMB(), request.getQueryString() can be null because
o.a.t.util.buf.MessageBytes.toString() can return NULL -->
<Class name="org.apache.catalina.realm.RealmBase"/>
@@ -225,19 +267,11 @@
<Match>
<!-- context is never null -->
<Class name="org.apache.catalina.startup.HostConfig" />
- <Method name="deployDescriptor" />
- <Bug code="NP" />
- </Match>
- <Match>
- <!-- context is never null -->
- <Class name="org.apache.catalina.startup.HostConfig" />
- <Method name="deployDirectory" />
- <Bug code="NP" />
- </Match>
- <Match>
- <!-- context is never null -->
- <Class name="org.apache.catalina.startup.HostConfig" />
- <Method name="deployWAR" />
+ <Or>
+ <Method name="deployDescriptor" />
+ <Method name="deployDirectory" />
+ <Method name="deployWAR" />
+ </Or>
<Bug code="NP" />
</Match>
<Match>
@@ -447,6 +481,23 @@
<Bug code="ES"/>
</Match>
<Match>
+ <!-- Only base null is handled by this resolver -->
+ <Class name="org.apache.jasper.el.ELResolverImpl"/>
+ <Or>
+ <Method name="getType" />
+ <Method name="getValue" />
+ <Method name="isReadOnly" />
+ <Method name="setValue" />
+ </Or>
+ <Bug code="NP" />
+ </Match>
+ <Match>
+ <!-- base null is handled by this resolver -->
+ <Class name="org.apache.jasper.el.JasperELResolver"/>
+ <Method name="getValue" />
+ <Bug code="NP" />
+ </Match>
+ <Match>
<!-- Use of == is deliberate, String.intern() is used -->
<Class name="org.apache.jasper.xmlparser.XMLEncodingDetector"/>
<Method name="scanXMLDeclOrTextDecl"/>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org