You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/27 01:02:27 UTC
[GitHub] [spark] erenavsarogullari opened a new pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
erenavsarogullari opened a new pull request #28354:
URL: https://github.com/apache/spark/pull/28354
### What changes were proposed in this pull request?
SQL Rest API exposes query execution details and metrics as Public API. Its documentation will be useful for the end-users. Also, this is a follow-up jira with PR: #28208 and needs to be merged after #28208.
### Why are the changes needed?
SQL Rest API does not exist under Spark Rest API.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
Manually build and check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-637290265
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619700962
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-637767584
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-637290265
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28354: [WIP][SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-630303569
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619700962
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619655979
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28354: [WIP][SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-630318313
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28354: [WIP][SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-630302924
**[Test build #122817 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122817/testReport)** for PR 28354 at commit [`5723cdc`](https://github.com/apache/spark/commit/5723cdcf854e6d5e19aae9e42cbd28d62ff6573a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619705453
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619700668
**[Test build #121869 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121869/testReport)** for PR 28354 at commit [`a082de8`](https://github.com/apache/spark/commit/a082de8654fe1dc3182e4147c59a6f7688ed93f5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28354: [WIP][SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-630315301
**[Test build #122817 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122817/testReport)** for PR 28354 at commit [`5723cdc`](https://github.com/apache/spark/commit/5723cdcf854e6d5e19aae9e42cbd28d62ff6573a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28354: [WIP][SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-630307851
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619655769
**[Test build #121857 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121857/testReport)** for PR 28354 at commit [`5c24141`](https://github.com/apache/spark/commit/5c2414125483a3800de51ed4618ea2ef954ee82a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28354: [WIP][SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-630609859
@erenavsarogullari You can continue on this one now
Please remove the `[WIP]` in the title and provide a screenshot of doc after built
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #28354:
URL: https://github.com/apache/spark/pull/28354
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619659269
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28354: [WIP][SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-630318313
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28354: [WIP][SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-630307851
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619657328
**[Test build #121858 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121858/testReport)** for PR 28354 at commit [`5723cdc`](https://github.com/apache/spark/commit/5723cdcf854e6d5e19aae9e42cbd28d62ff6573a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28354: [WIP][SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-630315432
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28354: [WIP][SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-630307015
**[Test build #122818 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122818/testReport)** for PR 28354 at commit [`227cebe`](https://github.com/apache/spark/commit/227cebe24d33ebee70b89f72d18c80e5a25cea97).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28354: [WIP][SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-630303569
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619657600
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619659185
**[Test build #121857 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121857/testReport)** for PR 28354 at commit [`5c24141`](https://github.com/apache/spark/commit/5c2414125483a3800de51ed4618ea2ef954ee82a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619705453
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] erenavsarogullari commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
erenavsarogullari commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619701829
Hi @HyukjinKwon,
Thanks for the review. I removed the dependency so current documentation just points the existing functionality on `SqlResource`. So, this can go independently now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619705351
**[Test build #121869 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121869/testReport)** for PR 28354 at commit [`a082de8`](https://github.com/apache/spark/commit/a082de8654fe1dc3182e4147c59a6f7688ed93f5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619692500
I think you can just fold this into #28208.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619659269
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28354: [WIP][SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-630315432
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] erenavsarogullari commented on pull request #28354: [WIP][SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
erenavsarogullari commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-636251609
Hi @gengliangwang,
This PR is up-to-date. Please find doc screenshot as attached
Doc Link: https://github.com/erenavsarogullari/spark/blob/SPARK-31566/docs/monitoring.md
<img width="904" alt="Spark SQL Rest API Doc" src="https://user-images.githubusercontent.com/1437738/83315708-ad40cd80-a1d6-11ea-9a5c-e20b0a1d115b.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-637767334
Thanks, merging to master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-620301870
I think either a separate PR or folding into #28208 is fine.
Since #28208 is not merged yet, let's mark this one as WIP.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619700668
**[Test build #121869 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121869/testReport)** for PR 28354 at commit [`a082de8`](https://github.com/apache/spark/commit/a082de8654fe1dc3182e4147c59a6f7688ed93f5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619655979
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] erenavsarogullari commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
erenavsarogullari commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619656450
cc @gengliangwang @vanzin @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619661410
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28354: [WIP][SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-630318150
**[Test build #122818 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122818/testReport)** for PR 28354 at commit [`227cebe`](https://github.com/apache/spark/commit/227cebe24d33ebee70b89f72d18c80e5a25cea97).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-637295071
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619655769
**[Test build #121857 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121857/testReport)** for PR 28354 at commit [`5c24141`](https://github.com/apache/spark/commit/5c2414125483a3800de51ed4618ea2ef954ee82a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619661410
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-637294885
**[Test build #123419 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123419/testReport)** for PR 28354 at commit [`cf7b041`](https://github.com/apache/spark/commit/cf7b041f2fe51dec84a51041db301a1d856969cb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619661330
**[Test build #121858 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121858/testReport)** for PR 28354 at commit [`5723cdc`](https://github.com/apache/spark/commit/5723cdcf854e6d5e19aae9e42cbd28d62ff6573a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619704133
cc @gengliangwang FYI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-637295071
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-637289805
**[Test build #123419 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123419/testReport)** for PR 28354 at commit [`cf7b041`](https://github.com/apache/spark/commit/cf7b041f2fe51dec84a51041db301a1d856969cb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619657328
**[Test build #121858 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121858/testReport)** for PR 28354 at commit [`5723cdc`](https://github.com/apache/spark/commit/5723cdcf854e6d5e19aae9e42cbd28d62ff6573a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-619657600
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-637289805
**[Test build #123419 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123419/testReport)** for PR 28354 at commit [`cf7b041`](https://github.com/apache/spark/commit/cf7b041f2fe51dec84a51041db301a1d856969cb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28354: [WIP][SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-630302924
**[Test build #122817 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122817/testReport)** for PR 28354 at commit [`5723cdc`](https://github.com/apache/spark/commit/5723cdcf854e6d5e19aae9e42cbd28d62ff6573a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-637767584
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #28354: [SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #28354:
URL: https://github.com/apache/spark/pull/28354#discussion_r432822867
##########
File path: docs/monitoring.md
##########
@@ -544,6 +544,24 @@ can be identified by their `[attempt-id]`. In the API listed below, when running
<td><code>/applications/[app-id]/streaming/batches/[batch-id]/operations/[outputOp-id]</code></td>
<td>Details of the given operation and given batch.</td>
</tr>
+ <tr>
+ <td><code>/applications/[app-id]/sql</code></td>
+ <td>A list of all queries for a given application.
+ <br>
+ <code>?details=[true (default) | false]</code> lists metric details in addition to queries details.
Review comment:
how about changing
```
lists metric details in addition to queries details
```
to
```
lists/hides details of Spark plan nodes.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28354: [WIP][SPARK-31566][SQL][DOCS] Add SQL Rest API Documentation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28354:
URL: https://github.com/apache/spark/pull/28354#issuecomment-630307015
**[Test build #122818 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122818/testReport)** for PR 28354 at commit [`227cebe`](https://github.com/apache/spark/commit/227cebe24d33ebee70b89f72d18c80e5a25cea97).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org