[GitHub] rdhabalia closed pull request #2225: Set empty response to complete grpc txn

[GitBox <gi...@apache.org>]

rdhabalia closed pull request #2225: Set empty response to complete grpc txn
URL: https://github.com/apache/incubator-pulsar/pull/2225
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/JavaInstanceMain.java b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/JavaInstanceMain.java
index 0c10fdbcb8..966740da98 100644
--- a/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/JavaInstanceMain.java
+++ b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/JavaInstanceMain.java
@@ -370,9 +370,10 @@ public void resetMetrics(com.google.protobuf.Empty request,
             if (runtime != null) {
                 try {
                     runtime.resetMetrics().get();
+                    responseObserver.onNext(com.google.protobuf.Empty.getDefaultInstance());
                     responseObserver.onCompleted();
                 } catch (InterruptedException | ExecutionException e) {
-                    log.error("Exception in JavaInstance doing getAndResetMetrics", e);
+                    log.error("Exception in JavaInstance doing resetMetrics", e);
                     throw new RuntimeException(e);
                 }
             }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services