You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ju...@apache.org on 2013/01/21 05:53:06 UTC

git commit: Some arguments are always set to default in ProducerPerformance; patched by John Fung; committed by Jun Rao; kafka-710

Updated Branches:
  refs/heads/0.8 1e011bf42 -> 96dc29843


Some arguments are always set to default in ProducerPerformance; patched by John Fung; committed by Jun Rao; kafka-710


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/96dc2984
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/96dc2984
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/96dc2984

Branch: refs/heads/0.8
Commit: 96dc298438994fb5c93daa8c544bf8581a0eeb69
Parents: 1e011bf
Author: Jun Rao <ju...@gmail.com>
Authored: Sun Jan 20 20:52:54 2013 -0800
Committer: Jun Rao <ju...@gmail.com>
Committed: Sun Jan 20 20:52:54 2013 -0800

----------------------------------------------------------------------
 perf/src/main/scala/kafka/perf/PerfConfig.scala    |    2 +-
 .../scala/kafka/perf/ProducerPerformance.scala     |   14 --------------
 2 files changed, 1 insertions(+), 15 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/96dc2984/perf/src/main/scala/kafka/perf/PerfConfig.scala
----------------------------------------------------------------------
diff --git a/perf/src/main/scala/kafka/perf/PerfConfig.scala b/perf/src/main/scala/kafka/perf/PerfConfig.scala
index 5dabeb5..a8fc6b9 100644
--- a/perf/src/main/scala/kafka/perf/PerfConfig.scala
+++ b/perf/src/main/scala/kafka/perf/PerfConfig.scala
@@ -53,7 +53,7 @@ class PerfConfig(args: Array[String]) {
     .defaultsTo(200)
   val compressionCodecOpt = parser.accepts("compression-codec", "If set, messages are sent compressed")
     .withRequiredArg
-    .describedAs("compression codec ")
+    .describedAs("supported codec: NoCompressionCodec as 0, GZIPCompressionCodec as 1, SnappyCompressionCodec as 2")
     .ofType(classOf[java.lang.Integer])
     .defaultsTo(0)
   val helpOpt = parser.accepts("help", "Print usage.")

http://git-wip-us.apache.org/repos/asf/kafka/blob/96dc2984/perf/src/main/scala/kafka/perf/ProducerPerformance.scala
----------------------------------------------------------------------
diff --git a/perf/src/main/scala/kafka/perf/ProducerPerformance.scala b/perf/src/main/scala/kafka/perf/ProducerPerformance.scala
index 4822a7e..507743e 100644
--- a/perf/src/main/scala/kafka/perf/ProducerPerformance.scala
+++ b/perf/src/main/scala/kafka/perf/ProducerPerformance.scala
@@ -101,11 +101,6 @@ object ProducerPerformance extends Logging {
             .describedAs("number of threads")
             .ofType(classOf[java.lang.Integer])
             .defaultsTo(1)
-    val compressionCodecOption = parser.accepts("compression-codec", "If set, messages are sent compressed")
-            .withRequiredArg
-            .describedAs("supported codec: NoCompressionCodec as 0, GZIPCompressionCodec as 1, SnappyCompressionCodec as 2")
-            .ofType(classOf[java.lang.Integer])
-            .defaultsTo(0)
     val initialMessageIdOpt = parser.accepts("initial-message-id", "The is used for generating test data, If set, messages will be tagged with an " +
             "ID and sent by producer starting from this ID sequentially. Message content will be String type and " +
             "in the form of 'Message:000...1:xxx...'")
@@ -117,15 +112,6 @@ object ProducerPerformance extends Logging {
             .describedAs("message send time gap")
             .ofType(classOf[java.lang.Integer])
             .defaultsTo(0)
-    val produceRequestTimeoutMsOpt = parser.accepts("request-timeout-ms", "The produce request timeout in ms")
-      .withRequiredArg()
-      .ofType(classOf[java.lang.Integer])
-      .defaultsTo(3000)
-    val produceRequestRequiredAcksOpt = parser.accepts("request-num-acks", "Number of acks required for producer request " +
-      "to complete")
-      .withRequiredArg()
-      .ofType(classOf[java.lang.Integer])
-      .defaultsTo(-1)
     val csvMetricsReporterEnabledOpt = parser.accepts("csv-reporter-enabled", "If set, the CSV metrics reporter will be enabled")
     val metricsDirectoryOpt = parser.accepts("metrics-dir", "If csv-reporter-enable is set, and this parameter is" +
             "set, the csv metrics will be outputed here")