You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Ashutosh Chauhan (JIRA)" <ji...@apache.org> on 2013/09/26 04:58:05 UTC

[jira] [Commented] (HIVE-5366) Refactor a few object inspector class to eliminate redundant information

    [ https://issues.apache.org/jira/browse/HIVE-5366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778396#comment-13778396 ] 

Ashutosh Chauhan commented on HIVE-5366:
----------------------------------------

+1
                
> Refactor a few object inspector class to eliminate redundant information
> ------------------------------------------------------------------------
>
>                 Key: HIVE-5366
>                 URL: https://issues.apache.org/jira/browse/HIVE-5366
>             Project: Hive
>          Issue Type: Improvement
>          Components: Serializers/Deserializers, Types
>    Affects Versions: 0.12.0
>            Reporter: Xuefu Zhang
>            Assignee: Xuefu Zhang
>             Fix For: 0.13.0
>
>         Attachments: HIVE-5366.patch
>
>
> AbstractPrimitiveObjectInspector class has two fields:
> {code}
>   protected PrimitiveTypeEntry typeEntry;
>   protected BaseTypeParams typeParams;
> {code}
> But PrimitiveTypeEntry already has member BaseTypeParams instance, which is identical to "typeParams" we see here. Thus, there is some redundant information stored at different places. Ideally, we should have a single point of truth.
> This refactoring is required by HIVE-3976 work. This is singled out to make the review easier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira