You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/09/08 16:57:43 UTC
[GitHub] [commons-lang] wx930910 opened a new pull request #801: refactor AtomicSafeInitializerTest to improve test design
wx930910 opened a new pull request #801:
URL: https://github.com/apache/commons-lang/pull/801
Fixes [LANG-1671](https://issues.apache.org/jira/browse/LANG-1671)
### Description
Replace test class [AtomicSafeInitializerTestImpl](https://github.com/apache/commons-lang/blob/69c9593cc1da760bb4dbcf32f4ae755c54376b77/src/test/java/org/apache/commons/lang3/concurrent/AtomicSafeInitializerTest.java#L67) by mocking object created by Mockito.
<hr>
##### Key changed/added classes in this PR
- Create mocking object to replace test subclass `AtomicSafeInitializerTestImpl`, decouple test from production code.
- Extract AtomicInteger variable out of the test subclass. Use the extracted variable in assertation statement to check `initialize()` method invocation status.
- Introduce Mockito dependency
<hr>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #801: refactor AtomicSafeInitializerTest to improve test design
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #801:
URL: https://github.com/apache/commons-lang/pull/801#issuecomment-945134845
Closing, same comments as https://github.com/apache/commons-codec/pull/94 and https://github.com/apache/commons-pool/pull/98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #801: refactor AtomicSafeInitializerTest to improve test design
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #801:
URL: https://github.com/apache/commons-lang/pull/801#issuecomment-915522737
[](https://coveralls.io/builds/42738758)
Coverage remained the same at 94.951% when pulling **73ccce9ae52380c7ae8b04b913ceea6b78211e75 on wx930910:refactor-AutomicSafeInitializerTest** into **d2687419c6973572d1621afc1b8546f5262769c3 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory closed pull request #801: refactor AtomicSafeInitializerTest to improve test design
Posted by GitBox <gi...@apache.org>.
garydgregory closed pull request #801:
URL: https://github.com/apache/commons-lang/pull/801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org