You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/12/15 03:24:53 UTC

[GitHub] [inlong] gong commented on a diff in pull request #6887: [INLONG-6886][Sort] Add dirty message for doris sink

gong commented on code in PR #6887:
URL: https://github.com/apache/inlong/pull/6887#discussion_r1049177590


##########
inlong-sort/sort-connectors/doris/src/main/java/org/apache/inlong/sort/doris/table/DorisDynamicSchemaOutputFormat.java:
##########
@@ -268,6 +268,13 @@ public void open(int taskNumber, int numTasks) throws IOException {
         if (metricOption != null) {
             metricData = new SinkMetricData(metricOption, getRuntimeContext().getMetricGroup());
         }
+        if (dirtySink != null) {
+            try {
+                dirtySink.open(new Configuration());
+            } catch (Exception e) {
+                throw new IOException(e);

Review Comment:
   why throw IOException?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org