[GitHub] [bookkeeper] massakam commented on pull request #3214: Issue 3070: Fix bug where checkAllLedgers gets stuck when read throttling is enabled

[GitBox <gi...@apache.org>]

massakam commented on PR #3214:
URL: https://github.com/apache/bookkeeper/pull/3214#issuecomment-1163918086

   @dlg99 Hmm... you have a point there.
   
   However, I once tried to fix it in [the way you suggested first](https://github.com/apache/bookkeeper/pull/3214#issuecomment-1109162512), but I gave it up because the code became complicated and there was a high risk of missing the release of the acquired permit. In this approach, if an additional read is required in `EntryExistsCallback#readEntryComplete()`, it is necessary not to release the permit immediately, but after the subsequent read is complete.
   
   I think it would be better to move to throttling with a rate limiter rather than to keep the RIPs approach and leaving the possibility of getting stuck.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org