You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2019/11/05 01:22:44 UTC
[Impala-ASF-CR] IMPALA-9100: Handle duplicate occurrences of flags for tests/run-tests.py
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14629
Change subject: IMPALA-9100: Handle duplicate occurrences of flags for tests/run-tests.py
......................................................................
IMPALA-9100: Handle duplicate occurrences of flags for tests/run-tests.py
If someone passes --skip-stress multiple times to tests/run-tests.py,
it currently only removes one of the occurrences from the arguments
and allows the other one to pass through to pytest. This causes pytest
to immediately error out. This behavior is seen on the docker-based
tests, because test-with-docker.py specifies --skip-stress and
bin/run-all-tests.sh adds another --skip-stress for core runs.
This changes tests/run-tests.py to handle multiple occurrences of
--skip-stress, --skip-parallel, and --skip-serial.
Testing:
- Tested manually with duplicate skip flags.
Change-Id: I60dc9a898f69804e2a53c05b5dfab2f948a22097
---
M tests/run-tests.py
1 file changed, 14 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/14629/1
--
To view, visit http://gerrit.cloudera.org:8080/14629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I60dc9a898f69804e2a53c05b5dfab2f948a22097
Gerrit-Change-Number: 14629
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9100: Handle duplicate occurrences of flags for tests/run-tests.py
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14629 )
Change subject: IMPALA-9100: Handle duplicate occurrences of flags for tests/run-tests.py
......................................................................
Patch Set 3: Code-Review+2
Rebased, carry +2
--
To view, visit http://gerrit.cloudera.org:8080/14629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60dc9a898f69804e2a53c05b5dfab2f948a22097
Gerrit-Change-Number: 14629
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 00:26:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9100: Handle duplicate occurrences of flags for tests/run-tests.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14629 )
Change subject: IMPALA-9100: Handle duplicate occurrences of flags for tests/run-tests.py
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5274/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/14629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60dc9a898f69804e2a53c05b5dfab2f948a22097
Gerrit-Change-Number: 14629
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 00:26:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9100: Handle duplicate occurrences of flags for tests/run-tests.py
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14629 )
Change subject: IMPALA-9100: Handle duplicate occurrences of flags for tests/run-tests.py
......................................................................
Patch Set 2: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/14629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60dc9a898f69804e2a53c05b5dfab2f948a22097
Gerrit-Change-Number: 14629
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2019 22:25:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9100: Handle duplicate occurrences of flags for tests/run-tests.py
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14629 )
Change subject: IMPALA-9100: Handle duplicate occurrences of flags for tests/run-tests.py
......................................................................
IMPALA-9100: Handle duplicate occurrences of flags for tests/run-tests.py
If someone passes --skip-stress multiple times to tests/run-tests.py,
it currently only removes one of the occurrences from the arguments
and allows the other one to pass through to pytest. This causes pytest
to immediately error out. This behavior is seen on the docker-based
tests, because test-with-docker.py specifies --skip-stress and
bin/run-all-tests.sh adds another --skip-stress for core runs.
This changes tests/run-tests.py to handle multiple occurrences of
--skip-stress, --skip-parallel, and --skip-serial.
Testing:
- Tested manually with duplicate skip flags.
Change-Id: I60dc9a898f69804e2a53c05b5dfab2f948a22097
Reviewed-on: http://gerrit.cloudera.org:8080/14629
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/run-tests.py
1 file changed, 14 insertions(+), 9 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I60dc9a898f69804e2a53c05b5dfab2f948a22097
Gerrit-Change-Number: 14629
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9100: Handle duplicate occurrences of flags for tests/run-tests.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14629 )
Change subject: IMPALA-9100: Handle duplicate occurrences of flags for tests/run-tests.py
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4941/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60dc9a898f69804e2a53c05b5dfab2f948a22097
Gerrit-Change-Number: 14629
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Nov 2019 02:07:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9100: Handle duplicate occurrences of flags for tests/run-tests.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14629 )
Change subject: IMPALA-9100: Handle duplicate occurrences of flags for tests/run-tests.py
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60dc9a898f69804e2a53c05b5dfab2f948a22097
Gerrit-Change-Number: 14629
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 05:08:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9100: Handle duplicate occurrences of flags for tests/run-tests.py
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14629 )
Change subject: IMPALA-9100: Handle duplicate occurrences of flags for tests/run-tests.py
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60dc9a898f69804e2a53c05b5dfab2f948a22097
Gerrit-Change-Number: 14629
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Nov 2019 14:19:14 +0000
Gerrit-HasComments: No