You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by pe...@apache.org on 2007/10/07 10:36:55 UTC
svn commit: r582597 - /tomcat/tc6.0.x/trunk/STATUS
Author: pero
Date: Sun Oct 7 01:36:51 2007
New Revision: 582597
URL: http://svn.apache.org/viewvc?rev=582597&view=rev
Log:
add change request: call StandardServer stopAwait
Modified:
tomcat/tc6.0.x/trunk/STATUS
Modified: tomcat/tc6.0.x/trunk/STATUS
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS?rev=582597&r1=582596&r2=582597&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS (original)
+++ tomcat/tc6.0.x/trunk/STATUS Sun Oct 7 01:36:51 2007
@@ -44,4 +44,7 @@
update to jdt.loc=http://sunsite.informatik.rwth-aachen.de/eclipse/downloads/drops/R-3.3.1-200709211145/eclipse-JDT-3.3.1.zip
+1: pero
-1:
-
\ No newline at end of file
+
+* Call StopAwait at StandardServer.stop as port==-1
+ +1: pero
+ -1:
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r582597 - /tomcat/tc6.0.x/trunk/STATUS
Posted by Filip Hanik - Dev Lists <de...@hanik.com>.
I would agree with all these options, basically, the goal is to have a
reference to an actual patch, otherwise we are voting on someones idea
of a fix :)
Filip
Tim Funk wrote:
> I would think a link is a must. So step 2 can be any of
> 2a) Upload a patch to /home/`whoami`/public_html/patches
> 2b) Add a patch to BZ
> 2c) Link to SVN patch
> 2d) If the patch is an attachment in an email to tomcat-dev - there is
> some public record of the email - link to that
>
>
> -Tim
>
> Filip Hanik - Dev Lists wrote:
>> since the STATUS file is also a voting forum, there must be a
>> reference to an absolute patch/diff. otherwise, the implementation
>> can change during the voting phase.
>> so what I suggest you do is
>>
>> 1. create a .patch file, with your proposed solution
>> 2. upload it to your /home/pero/public_html/patches/ directory
>> 3. put the URL reference to the .patch file in the STATUS file
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r582597 - /tomcat/tc6.0.x/trunk/STATUS
Posted by Tim Funk <fu...@joedog.org>.
I would think a link is a must. So step 2 can be any of
2a) Upload a patch to /home/`whoami`/public_html/patches
2b) Add a patch to BZ
2c) Link to SVN patch
2d) If the patch is an attachment in an email to tomcat-dev - there is
some public record of the email - link to that
-Tim
Filip Hanik - Dev Lists wrote:
> since the STATUS file is also a voting forum, there must be a reference
> to an absolute patch/diff. otherwise, the implementation can change
> during the voting phase.
> so what I suggest you do is
>
> 1. create a .patch file, with your proposed solution
> 2. upload it to your /home/pero/public_html/patches/ directory
> 3. put the URL reference to the .patch file in the STATUS file
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r582597 - /tomcat/tc6.0.x/trunk/STATUS
Posted by Filip Hanik - Dev Lists <de...@hanik.com>.
since the STATUS file is also a voting forum, there must be a reference
to an absolute patch/diff. otherwise, the implementation can change
during the voting phase.
so what I suggest you do is
1. create a .patch file, with your proposed solution
2. upload it to your /home/pero/public_html/patches/ directory
3. put the URL reference to the .patch file in the STATUS file
this seems to work pretty well, and that is what we've been doing
the other option, is to open a BZ item, attach your patch in there
Filip
Peter Rossbach wrote:
> OK!
>
> How we can easier promote and discuss those patches? You are right, an
> email threads are not easy to reference at STATUS file. Arrg!
> I don't think that the apache developer home folder are the right
> place for those patches!
>
> Open a bug report for every possible change is also not a good
> solution. But other people can
> add there comments and ideas.
>
> Every hint to a standard procedure?
>
> Peter
>
> PS: Can we move the tomcat 5.5 STATUS file to the build project? Then
> it was easier for me to change the file at my eclipse.
>
>
> Am 08.10.2007 um 17:13 schrieb Filip Hanik - Dev Lists:
>
>> I did, but folks shouldn't have to dig through the dev archives,
>> should they :)
>>
>> Filip
>>
>> Peter Rossbach wrote:
>>> Hi Filip,
>>>
>>> has you seen my "Call stopAwait at StandardServer.stop" mail?
>>>
>>> Peter
>>>
>>>
>>> Am 07.10.2007 um 17:10 schrieb Filip Hanik - Dev Lists:
>>>
>>>> don't forget to include a link to the diff file, so that it can be
>>>> reviewed before committed, just in case someone misses the dev email
>>>>
>>>> Filip
>>>>
>>>> pero@apache.org wrote:
>>>>> Author: pero
>>>>> Date: Sun Oct 7 01:36:51 2007
>>>>> New Revision: 582597
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=582597&view=rev
>>>>> Log:
>>>>> add change request: call StandardServer stopAwait
>>>>>
>>>>> Modified:
>>>>> tomcat/tc6.0.x/trunk/STATUS
>>>>>
>>>>> Modified: tomcat/tc6.0.x/trunk/STATUS
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS?rev=582597&r1=582596&r2=582597&view=diff
>>>>>
>>>>> ==============================================================================
>>>>>
>>>>> --- tomcat/tc6.0.x/trunk/STATUS (original)
>>>>> +++ tomcat/tc6.0.x/trunk/STATUS Sun Oct 7 01:36:51 2007
>>>>> @@ -44,4 +44,7 @@
>>>>> update to
>>>>> jdt.loc=http://sunsite.informatik.rwth-aachen.de/eclipse/downloads/drops/R-3.3.1-200709211145/eclipse-JDT-3.3.1.zip
>>>>>
>>>>> +1: pero
>>>>> -1: - \ No newline at end of file
>>>>> +
>>>>> +* Call StopAwait at StandardServer.stop as port==-1
>>>>> + +1: pero
>>>>> + -1:
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>>
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
>
>
> ------------------------------------------------------------------------
>
> No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.5.488 / Virus Database: 269.14.4/1056 - Release Date: 10/7/2007 6:12 PM
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r582597 - /tomcat/tc6.0.x/trunk/STATUS
Posted by Jim Jagielski <ji...@jaguNET.com>.
On Oct 8, 2007, at 12:21 PM, Mark Thomas wrote:
> Peter Rossbach wrote:
>> OK!
>>
>> How we can easier promote and discuss those patches? You are
>> right, an
>> email threads are not easy to reference at STATUS file. Arrg!
>> I don't think that the apache developer home folder are the right
>> place
>> for those patches!
>
> It will do for now. Once we have trunk (see my latest post on svn
> re-org) we can just refer to subversion revision numbers from trunk.
>
+1
(until then, mail-archives URLs work if the patch
was posted on the list)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r582597 - /tomcat/tc6.0.x/trunk/STATUS
Posted by Mark Thomas <ma...@apache.org>.
Peter Rossbach wrote:
> OK!
>
> How we can easier promote and discuss those patches? You are right, an
> email threads are not easy to reference at STATUS file. Arrg!
> I don't think that the apache developer home folder are the right place
> for those patches!
It will do for now. Once we have trunk (see my latest post on svn
re-org) we can just refer to subversion revision numbers from trunk.
> PS: Can we move the tomcat 5.5 STATUS file to the build project? Then it
> was easier for me to change the file at my eclipse.
Fine with me.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r582597 - /tomcat/tc6.0.x/trunk/STATUS
Posted by Peter Rossbach <pr...@objektpark.de>.
OK!
How we can easier promote and discuss those patches? You are right,
an email threads are not easy to reference at STATUS file. Arrg!
I don't think that the apache developer home folder are the right
place for those patches!
Open a bug report for every possible change is also not a good
solution. But other people can
add there comments and ideas.
Every hint to a standard procedure?
Peter
PS: Can we move the tomcat 5.5 STATUS file to the build project? Then
it was easier for me to change the file at my eclipse.
Am 08.10.2007 um 17:13 schrieb Filip Hanik - Dev Lists:
> I did, but folks shouldn't have to dig through the dev archives,
> should they :)
>
> Filip
>
> Peter Rossbach wrote:
>> Hi Filip,
>>
>> has you seen my "Call stopAwait at StandardServer.stop" mail?
>>
>> Peter
>>
>>
>> Am 07.10.2007 um 17:10 schrieb Filip Hanik - Dev Lists:
>>
>>> don't forget to include a link to the diff file, so that it can
>>> be reviewed before committed, just in case someone misses the dev
>>> email
>>>
>>> Filip
>>>
>>> pero@apache.org wrote:
>>>> Author: pero
>>>> Date: Sun Oct 7 01:36:51 2007
>>>> New Revision: 582597
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=582597&view=rev
>>>> Log:
>>>> add change request: call StandardServer stopAwait
>>>>
>>>> Modified:
>>>> tomcat/tc6.0.x/trunk/STATUS
>>>>
>>>> Modified: tomcat/tc6.0.x/trunk/STATUS
>>>> URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS?
>>>> rev=582597&r1=582596&r2=582597&view=diff
>>>> ===================================================================
>>>> ===========
>>>> --- tomcat/tc6.0.x/trunk/STATUS (original)
>>>> +++ tomcat/tc6.0.x/trunk/STATUS Sun Oct 7 01:36:51 2007
>>>> @@ -44,4 +44,7 @@
>>>> update to jdt.loc=http://sunsite.informatik.rwth-aachen.de/
>>>> eclipse/downloads/drops/R-3.3.1-200709211145/eclipse-JDT-3.3.1.zip
>>>> +1: pero
>>>> -1: - \ No newline at end of file
>>>> +
>>>> +* Call StopAwait at StandardServer.stop as port==-1
>>>> + +1: pero
>>>> + -1:
>>>>
>>>>
>>>> -------------------------------------------------------------------
>>>> --
>>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>> --------------------------------------------------------------------
>>> -
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
Re: svn commit: r582597 - /tomcat/tc6.0.x/trunk/STATUS
Posted by Filip Hanik - Dev Lists <de...@hanik.com>.
I did, but folks shouldn't have to dig through the dev archives, should
they :)
Filip
Peter Rossbach wrote:
> Hi Filip,
>
> has you seen my "Call stopAwait at StandardServer.stop" mail?
>
> Peter
>
>
> Am 07.10.2007 um 17:10 schrieb Filip Hanik - Dev Lists:
>
>> don't forget to include a link to the diff file, so that it can be
>> reviewed before committed, just in case someone misses the dev email
>>
>> Filip
>>
>> pero@apache.org wrote:
>>> Author: pero
>>> Date: Sun Oct 7 01:36:51 2007
>>> New Revision: 582597
>>>
>>> URL: http://svn.apache.org/viewvc?rev=582597&view=rev
>>> Log:
>>> add change request: call StandardServer stopAwait
>>>
>>> Modified:
>>> tomcat/tc6.0.x/trunk/STATUS
>>>
>>> Modified: tomcat/tc6.0.x/trunk/STATUS
>>> URL:
>>> http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS?rev=582597&r1=582596&r2=582597&view=diff
>>>
>>> ==============================================================================
>>>
>>> --- tomcat/tc6.0.x/trunk/STATUS (original)
>>> +++ tomcat/tc6.0.x/trunk/STATUS Sun Oct 7 01:36:51 2007
>>> @@ -44,4 +44,7 @@
>>> update to
>>> jdt.loc=http://sunsite.informatik.rwth-aachen.de/eclipse/downloads/drops/R-3.3.1-200709211145/eclipse-JDT-3.3.1.zip
>>>
>>> +1: pero
>>> -1: - \ No newline at end of file
>>> +
>>> +* Call StopAwait at StandardServer.stop as port==-1
>>> + +1: pero
>>> + -1:
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>>
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r582597 - /tomcat/tc6.0.x/trunk/STATUS
Posted by Peter Rossbach <pr...@objektpark.de>.
Hi Filip,
has you seen my "Call stopAwait at StandardServer.stop" mail?
Peter
Am 07.10.2007 um 17:10 schrieb Filip Hanik - Dev Lists:
> don't forget to include a link to the diff file, so that it can be
> reviewed before committed, just in case someone misses the dev email
>
> Filip
>
> pero@apache.org wrote:
>> Author: pero
>> Date: Sun Oct 7 01:36:51 2007
>> New Revision: 582597
>>
>> URL: http://svn.apache.org/viewvc?rev=582597&view=rev
>> Log:
>> add change request: call StandardServer stopAwait
>>
>> Modified:
>> tomcat/tc6.0.x/trunk/STATUS
>>
>> Modified: tomcat/tc6.0.x/trunk/STATUS
>> URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS?
>> rev=582597&r1=582596&r2=582597&view=diff
>> =====================================================================
>> =========
>> --- tomcat/tc6.0.x/trunk/STATUS (original)
>> +++ tomcat/tc6.0.x/trunk/STATUS Sun Oct 7 01:36:51 2007
>> @@ -44,4 +44,7 @@
>> update to jdt.loc=http://sunsite.informatik.rwth-aachen.de/
>> eclipse/downloads/drops/R-3.3.1-200709211145/eclipse-JDT-3.3.1.zip
>> +1: pero
>> -1: - \ No newline at end of file
>> +
>> +* Call StopAwait at StandardServer.stop as port==-1
>> + +1: pero
>> + -1:
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r582597 - /tomcat/tc6.0.x/trunk/STATUS
Posted by Filip Hanik - Dev Lists <de...@hanik.com>.
don't forget to include a link to the diff file, so that it can be
reviewed before committed, just in case someone misses the dev email
Filip
pero@apache.org wrote:
> Author: pero
> Date: Sun Oct 7 01:36:51 2007
> New Revision: 582597
>
> URL: http://svn.apache.org/viewvc?rev=582597&view=rev
> Log:
> add change request: call StandardServer stopAwait
>
> Modified:
> tomcat/tc6.0.x/trunk/STATUS
>
> Modified: tomcat/tc6.0.x/trunk/STATUS
> URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS?rev=582597&r1=582596&r2=582597&view=diff
> ==============================================================================
> --- tomcat/tc6.0.x/trunk/STATUS (original)
> +++ tomcat/tc6.0.x/trunk/STATUS Sun Oct 7 01:36:51 2007
> @@ -44,4 +44,7 @@
> update to jdt.loc=http://sunsite.informatik.rwth-aachen.de/eclipse/downloads/drops/R-3.3.1-200709211145/eclipse-JDT-3.3.1.zip
> +1: pero
> -1:
> -
> \ No newline at end of file
> +
> +* Call StopAwait at StandardServer.stop as port==-1
> + +1: pero
> + -1:
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org